[ANSWERED] part.Resources, Remove item

[Warezcrawler]

In my mod GTI MultiMode Intakes, I am allowing switching between different intake modes. When doing this, I'm also changing the resources associated with the intake, like intakeair or intakeatm. However, so far, I've relied on "part.Resources.Clear();". This removes all resources in the part, and then I can add the new resource I want back in.

However, this have one mayor drawback, it removes all resources, and not just the ones I want it to, namely the ones I target.

So in my latest try, I used the below methods to target only relevant resources. However, I cannot seem to get them to work.

    public bool Remove(PartResource res);
    public bool Remove(string resName);
    public bool Remove(int resID);

I tried as follows (i merged the three overload methods directly into the example below, I do NOT run them at the same time, I comment out when testing). Debug messages says that I do indeed run the "Remove()" method where expected and on the expected resource. The remove methods return true!!! But my engine continues to consume IntakeAir even when switched away, so that the resource should have been removed. When I use "Clear()" the engine flameout immediately as it should. And listing all resources in the part after all show that the resource was not removed.

bool preserveResource;
PartResource partResourceDef;
//Evaluated all resources in part
for (int i = 0; i < currentPart.Resources.Count; i++)
{
	preserveResource = true;
	GTIDebug.Log("Check for resource removal: " + currentPart.Resources[i].resourceName, iDebugLevel.DebugInfo);
	//compare all resources to the target resources
    	for (int j = 0; j < modes.Count; j++)
	{
		//If it is a target resource, mark it for replacement
		if (modes[j].resourceName == currentPart.Resources[i].resourceName)
		{
			//Remove resources managed by this mod
			preserveResource = false;
			break;
		}
	}
	//Remove resource if it is marked for replacement
	if (!preserveResource)
	{
		GTIDebug.Log("Removing Resource: " + currentPart.Resources[i].resourceName, iDebugLevel.DebugInfo);
		
		//try 1
		currentPart.Resources.Remove(currentPart.Resources[i].resourceName)
		
		//try 2
		currentPart.Resources.Remove(PartResourceLibrary.Instance.GetDefinition(currentPart.Resources[i].resourceName).id)
		
		//try 3
		partResourceDef = currentPart.Resources.Get(currentPart.Resources[i].resourceName);
		currentPart.Resources.Remove(partResourceDef)
		}
}

So my questions are,

• does Remove() work at all?
• if yes, then can anybody point me toward what could be wrong in my code?

 

Edited May 1, 2017 by Warezcrawler

[FreeThinker]

I simply use

PartResource resource = part.Resources["Atmosphere"];

part.Resources.Remove(resource)

and it works.

All the methods you attemped will not work

 

Edited April 14, 2017 by FreeThinker

[Warezcrawler]

1 hour ago, FreeThinker said:

I simply use

PartResource resource = part.Resources["Atmosphere"];

part.Resources.Remove(resource)

and it works.

All the methods you attemped will not work

 

Thanks, that did it.