Best way to determine if a vessel is a kerbal

[linuxgurugamer]

Given a Vessel ( which may or may not be the active vessel), what is the best way to determine if it is a Kerbal or not?  This needs to be checked in the GameEvents.onVesselModified, it seems that when a Kerbal goes EVA, the vessel is modified, but I haven't  yet been able to properly identify if it's a kerbal

I've come up with the following which seems to work, is there a better way (ie: faster):

void testVessel(Vessel v)
{
	if (v.rootPart.Modules.Contains("Kerbal"))
                return;
      
    // do something here if NOT a kerbal
      
}

Also, this doesn't seem to work either:

if (v.isEVA && v.GetComponent<KerbalEVA>() != null)
                return;

 

I can't just compare the vessel name to the name of the crew, since it is conceivable that someone might name a ship the same as the kerbal inside.

Edited July 25, 2017 by linuxgurugamer

[linuxgurugamer]

Actually, I may be mistaken.  It appears that I'm actually seeing the onVesselModified on the original vessel, not the kerbal.

[sarbian]

The module name is KerbalEVA so I don't see how it would work with v.rootPart.Modules.Contains("Kerbal")

and the fastest would be v.rootPart.Modules.Contains<KerbalEVA>() 

[linuxgurugamer]

7 minutes ago, sarbian said:

The module name is KerbalEVA so I don't see how it would work with v.rootPart.Modules.Contains("Kerbal")

and the fastest would be v.rootPart.Modules.Contains<KerbalEVA>() 

Thanks, I did find that was working.

Related question, I'm getting an "onVesselWasModified" event for the parent vessel  when a kerbal goes EVA.  Is there an easy way to determine if this event was generated because of an EVA?

[sarbian]

I don't think so.

[linuxgurugamer]

2 minutes ago, sarbian said:

I don't think so.

Ok.

What I've seen is that the onCrewTransferred is thrown just before the onVesselModified, so I'll just have to set a flag.

Thanks

[sarbian]

Make sure to test with other scenario than EVA with a hatch (like ejected from a command seat ? Forgot how that one works) so be sure your code is not dependent on event created by UI code.. 

[linuxgurugamer]

Yup, thanks

[linuxgurugamer]

On 7/25/2017 at 9:42 AM, sarbian said:

Make sure to test with other scenario than EVA with a hatch (like ejected from a command seat ? Forgot how that one works) so be sure your code is not dependent on event created by UI code.. 

It was different, as was crew transferred, but I have them both working now.