taniwha

[1.3] Modular Fuel Tanks v5.9.1

735 posts in this topic

I get that too. Don't know if it's linked to the issue I reported. 

Share this post


Link to post
Share on other sites

@Flow: thanks, I'll look into it.

@Gordon Dry: Already fixed locally as I noticed it in flow's logs.

flow: I doubt they're related, though it is possible.

Share this post


Link to post
Share on other sites

@Flow: I have reproduced the problem even with my fix for the app launcher. I'll see what I can do.

Share this post


Link to post
Share on other sites

Posted (edited)

@taniwhaThank you for looking into it. I appreciate your work. 

Edited by Flow

Share this post


Link to post
Share on other sites

I have released MFT version 5.9.1, fixing the error reported by @Flow. Many thanks.

2 people like this

Share this post


Link to post
Share on other sites

Posted (edited)

It turns out I broke things in 5.9.1, but nothing /too/ serious: MFT tanks start out with no resources at all, but once filled, they work. Until I get it fixed (hopefully soon), you can use the auto-fill buttons in the PAW (right-click menu).

Edited by taniwha

Share this post


Link to post
Share on other sites

I found the cause of that particular bug and things seem to be ok now, just doing a little more testing before doing another release.

2 people like this

Share this post


Link to post
Share on other sites

Posted (edited)

I think i mentioned something similar to this a while back but Nertea's Cryo engines call for a "cryogenic" tank that isn't define by MTF, 

He said he doesn't maintain the patch for mtf, so i didn't think mentioning it here would hurt, If i knew how to modify them i wouldn't have issues doing it but i'm not code literate at the this time.

Edited by Grease1991

Share this post


Link to post
Share on other sites

MFT never really understood "cryogenic", only RF did (and does). Some tanks were mistakenly marked as cryogenic in earlier versions, but that was fixed a while back (KSP 0.23.5).

Share this post


Link to post
Share on other sites

Posted (edited)

Is this TAC-LS issue because of a quirk with MFT? I'm not sure where to look:

Edit:

it seems that TAC-LS itself does this with GameData\ThunderAerospace\TacLifeSupportMFT\MM_AddResourcesMFT.cfg

actually I'm trying to create a patch for MFT

Edit:

I need help, I have problems with the recursion variable stuff in my try to create that patch:
GameData\ModularFuelTanks\TAC_LS_modularFuelTanks.cfg

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:BEFORE[zzz_modularFuelTanks]
{
	!MODULE[ModuleFuelTanks] { }
	!TANK_DEFINITION[Default] { }
}

@PART[*]:HAS[!MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:FOR[zzz_modularFuelTanks]
{
	MODULE
	{
		name = ModuleFuelTanks
		volume = 3.549
		@volume *= #$/CrewCapacity$
		type = Default
//		typeAvailable = LifeSupportAll
	}
	TANK_DEFINITION {
		name = Default
		basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[MonoPropellant]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = MonoPropellant
		amount = 0
		@amount = #$../RESOURCE[MonoPropellant]/amount$
		maxamount = 0
		@maxamount = #$../RESOURCE[MonoPropellant]/maxAmount$
		note = Also MonoPropellant is needed to survive
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[ElectricCharge]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = ElectricCharge
		amount = 0
		@amount = #$../RESOURCE[ElectricCharge]/amount$
		maxamount = 0
		@maxamount = #$../RESOURCE[ElectricCharge]/maxAmount$
		note = Also ElectricCharge is needed to survive
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[Food]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = Food
		amount = 0
		@amount = #$../RESOURCE[Food]/amount$
		maxamount = 0
		@maxamount = #$../RESOURCE[Food]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[Water]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = Water
		amount = 0
		@amount = #$../RESOURCE[Water]/amount$
		maxamount = 0
		@maxamount = #$../RESOURCE[Water]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[Oxygen]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = Oxygen
		amount = 0
		@amount = #$../RESOURCE[Oxygen]/amount$
		maxamount = 0
		@maxamount = #$../RESOURCE[Oxygen]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[CarbonDioxide]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = CarbonDioxide
		amount = 0
		maxamount = 0
		@maxamount = #$../RESOURCE[CarbonDioxide]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[Waste]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = Waste
		amount = 0
		maxamount = 0
		@maxamount = #$../RESOURCE[Waste]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[WasteWater]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = WasteWater
		amount = 0
		maxamount = 0
		@maxamount = #$../RESOURCE[WasteWater]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

// If tank volume is still zero than non of the above resources where present and we delete ModuleFuelTanks
@PART[*]:HAS[@MODULE[ModuleFuelTanks]:HAS[#volume[0]]]:FINAL
{
	!MODULE[ModuleFuelTanks] {}
	!TANK_DEFINITION[*] { }
}

It's the variants of
amount = #$../RESOURCE[MonoPropellant]/amount$
maxamount = #$../RESOURCE[MonoPropellant]/maxAmount$

I tried

  • without ../
  • with ../
  • with ../../
  • with ../../../

I'm lost now.

Edited by Gordon Dry

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!


Register a new account

Sign in

Already have an account? Sign in here.


Sign In Now