Jump to content

nightingale

Members
  • Posts

    4,136
  • Joined

  • Last visited

Everything posted by nightingale

  1. Your PR looks good, but I haven't had a chance to merge it yet. There's a chance that it may break in some places where I'm not using Lingoona but should be - just let me know if you see any ^f characters show up in text anywhere. Honestly I remember when I was figuring out how to get it working to test it in KSP it was a bit of a pain. So I want to make sure - are you actually getting the science for it, but it's just not completing the contract? If so, can you provide your save file so I can take a closer look? Not sure what's going on here. I'll respond in more detail on GitHub.
  2. Thanks. I already had a report for this against Strategia, so if you can post it there as well that would help me out. https://github.com/jrossignol/Strategia/issues/87
  3. I had a look, and couldn't reproduce. I don't see anything wrong with the code either, but I'd be curious to see that log if we get one.
  4. New release: Contract Configurator 1.30.5 Major performance improvements to save loading time (thanks siimav). Fixed SI units not appearing on HasAntenna parameter (thanks Nobody6). Fixed Exploration contracts not being fully disabled when requested (thanks ussdefiant).
  5. That message actually means it's working (sort of). The Exploration contracts are special to stock, so it makes extra sure those get generated. I needed to add a little bit more logic to fully disable those. Should be good in the next release now.
  6. Not sure why that would be - raised jrossignol/ContractPack-Tourism#35 to look into this.
  7. Raised jrossignol/ContractConfigurator#693 to improve handling of CustomBarnKit. I couldn't find which mod actually changed the levels in the list below - but it doesn't really matter how it did it as there are a number of other mods out there that modify the levels (mostly ones to do with antennas and bigger solar systems). Not sure, maybe something a little special with the modded experiment and I'll either need to write code or disable it from showing up in Field Research. Raised jrossignol/ContractPack-FieldResearch#27
  8. There you go, that's your problem then. That mod is not compatible with Contract Configurator. If you'd like me to look into making it compatible, you'll have to let me know what the mod is.
  9. There isn't a Name or FirstName method on Kerbal. Would be pretty easy to add, but I think @kerbal.ToString().FirstWord() should work (didn't test though).
  10. Whoops, sorry. I got caught up with the second question and didn't realize that I never answered the first one. You can use the FirstWord() method on any string (from https://github.com/jrossignol/ContractConfigurator/wiki/String-Type):
  11. There's a couple ways. First is to break the string and use a + to concatenate them: DATA { type = string cat = I am a cat catString = @cat + " and a bat" } Second is to use the new Format method: DATA { type = string formatString = Eat <<1>> and <<2>>. formattedString = Format(@formatString, ["oats", "goats"]) } Results: The second is what you'd want to use if you ever want to support localization (and probably just better overall in terms of performance and garbage generation). Looks like no - I only ever added escaping for ".
  12. And you can confirm that Exploration Contract is disabled in the difficulty menu? If so, please provide a KSP.log and I'll look from there.
  13. It works fine for me on 1.10.1. Can you provide a screenshot of the contract you are getting that you think shouldn't be getting?
  14. Whoops, this is a problem in Contract Configurator. I've fixed the parameter to use the right localization string for the next release.
  15. Are you using a mod that changes the buildings? Otherwise you shouldn't be able to upgrade above 3.
  16. It's not the localization that is the problem, there's a bunch of bug fixes and stuff like that. So I'm guessing you're more likely to hit a bug that's worse than the flickering tooltip if you roll back. More importantly, I won't provide support if you go from 1.30.x => 1.29, so read the changlogs carefully and decide for yourself whether it's worth the risk.
  17. Pretty questionable to continue on 1.29.0, I don't know what will happen. Looking at the diffs now to see if something jumps out. Problem is that localization happened between those two versions... so there's a lot to diff. I'm going to try to repro first, so if you're around, @VoidSquid and can post your save file it may help make that go a little quicker. EDIT: No need for the save, I managed to reproduce. EDIT: I think this is a SCANsat bug. I haven't identified it completely, but I have enough for @DMagic to take a look. What's happening is that SCANsat builds its tooltip based off a cached StringBuilder using a SCANSat specific caching framework. The place that reads the tooltip releases the StringBuilder, which is questionable, but may or may not be the cause. So what *seems* to be happening is that Contract Configurator and SCANsat are using the same cached StringBuilder (as part of some performance enhancements, I started using a StringBuilder using the stock caching framework in 1.30.0, which is why rolling back past that "fixes" the issue). Now, I don't 100% know how/why this could be, since SCANsat does it's own caching and I use the stock StringBuilderCache. I did see a spot where SCANsat uses the stock one, and found a questionable method that could allow injecting the stock one into the SCANsat framework (but I didn't see a call to it, so not sure if that's correct or not). So there it is - I don't completely know what/where the issue is, but I'm fairly certain the fix needs to happen in SCANsat. DMagic hasn't been on the forums for a couple weeks - so if we don't get a response from him then I'd suggest linking this thread from a SCANsat GitHub issue.
  18. @VoidSquid - I have a vague sense of what's going on here. The Contracts appis a bit silly and doesn't have the ability to support dynamic text. Contract Configurator fakes this the same way it does everything else - through hacking internals. In this case it walks through the UI elements associated to the contracts app, and then updates it when it finds it based on what has changed. I don't really know how it could get crossed up though, as Contract Configurator looks for children of the Contracts App. I'll have a look later tonight to see if I can reproduce, unless @DMagic knows off the top of their head what could possibly be causing this.
  19. I have never heard of anything like this. Those things sound like they should not be related in any way. Can you post some screenshots (or a video) and I'll take a closer look?
  20. Hmmm.... I think that's an old bug that's come back. I'll have to take a look at why it's not persistent anymore. Going to be working on Anomaly Surveyor for a while, and then I've got a laundry list of Strategia issues to look at. Mind raising this one up on the GitHub tracker so I don't forget?
  21. Stock comet stuff is already done. I was undecided on SSPX, but I don't need much of a push (and having someone else do it is enough of a push). Just toss it in the pile with the others.
  22. I fixed the downloaded (the version that was up just had the version number wrong in one part, nothing else). The KeyNotFoundException where it's happening now shouldn't have any adverse effect (but I've still cleaned it up for next release).
  23. Yaaaaaaah.... okay, that's why it was disabled. It's funny because in my one (very quick) test it seemed okay. I'll still try to play around with it, but it may just be a lost cause.
  24. New release! Contract Configurator 1.30.4 Fixed major issue when Breaking Ground wasn't installed (thanks boribori).
  25. @boribori - Oops, looks like it's an issue when Breaking Ground isn't installed. I may have to testing with & without expansions. I'll fix it shortly. @Morphisor - Hmmm... okay, don't do that then. Curious, if you do a Module Manager reload (through the Alt-F11 menu), does it do the same thing? @KPD87 - I'm guessing you hit the same issue as boribori, for which I'll be release a fix ASAP. If it's still not working after that, please send a KSP.log file.
×
×
  • Create New...