Grappler part spams AoR errors on release

[nli2work]

I noticed my grappler parts are unable to reattach after release for some reason. checked model and config setup against stock grappler unit; all checks out. far as I can tell they should behave identically in game...

I've removed all other Mods; all part functionalities except ModuleGrappleNode and ModuleAnimateGeneric. set to same exact index order as stock grappler unit. in game everything is normal until releasing the grapple unit. first click on Release generates the following error

 

NullReferenceException: Object reference not set to an instance of an object
  at ModuleGrappleNode.Release () [0x00000] in <filename unknown>:0
  at BaseEvent.Invoke () [0x00000] in <filename unknown>:0
  at UIPartActionButton.OnClick () [0x00000] in <filename unknown>:0
  at UnityEngine.Events.InvokableCall.Invoke (System.Object[] args) [0x00000] in <filename unknown>:0
  at UnityEngine.Events.InvokableCallList.Invoke (System.Object[] parameters) [0x00000] in <filename unknown>:0
  at UnityEngine.Events.UnityEventBase.Invoke (System.Object[] parameters) [0x00000] in <filename unknown>:0
  at UnityEngine.Events.UnityEvent.Invoke () [0x00000] in <filename unknown>:0
  at UnityEngine.UI.Button.Press () [0x00000] in <filename unknown>:0
  at UnityEngine.UI.Button.OnPointerClick (UnityEngine.EventSystems.PointerEventData eventData) [0x00000] in <filename unknown>:0
  at UnityEngine.EventSystems.ExecuteEvents.Execute (IPointerClickHandler handler, UnityEngine.EventSystems.BaseEventData eventData) [0x00000] in <filename unknown>:0
  at UnityEngine.EventSystems.ExecuteEvents.Execute[IPointerClickHandler] (UnityEngine.GameObject target, UnityEngine.EventSystems.BaseEventData eventData, UnityEngine.EventSystems.EventFunction`1 functor) [0x00000] in <filename unknown>:0 
UnityEngine.Debug:Internal_LogException(Exception, Object)
UnityEngine.Debug:LogException(Exception)
UnityEngine.EventSystems.ExecuteEvents:Execute(GameObject, BaseEventData, EventFunction`1)
UnityEngine.EventSystems.StandaloneInputModule:ProcessMousePress(MouseButtonEventData)
UnityEngine.EventSystems.StandaloneInputModule:ProcessMouseEvent(Int32)
UnityEngine.EventSystems.StandaloneInputModule:ProcessMouseEvent()
UnityEngine.EventSystems.StandaloneInputModule:Process()
UnityEngine.EventSystems.EventSystem:Update()

"Release" button remains active, clicking Release once or twice more will generate same error as above, after that game spams
 

ArgumentOutOfRangeException: Argument is out of range.

Parameter name: index
  at System.Collections.Generic.List`1[PartThermalData].get_Item (Int32 index) [0x00000] in <filename unknown>:0 
  at FlightIntegrator.UpdateOcclusionSolar () [0x00000] in <filename unknown>:0 
  at FlightIntegrator.UpdateOcclusion (Boolean all) [0x00000] in <filename unknown>:0 
  at FlightIntegrator.FixedUpdate () [0x00000] in <filename unknown>:0 

 

Any ideas?

Edited May 21, 2016 by nli2work

[Atlas2342]

A rare double thread! I must try to fix it!

[nli2work]

Ok appears to be due to grappler being the root part...

[Padishar]

9 hours ago, nli2work said:

Any ideas?

It looks like the line of code in ModuleGrappleNode.Release that adds a force to the node being grappled is using the parent part rather than the part the grapple is attached to.

It should be a simple fix for Squad to make...

Edit: I have added this bug to an internal Squad bug tracker...

Edited May 21, 2016 by Padishar

[nli2work]

so when Grappler is the root part, KSP can't find the parent part to apply release force to, hence the NullRef error and Out of Range errors?

[Padishar]

Yes, the code just needs to use "this.otherPart" instead of "parent" except it needs to remember it from before the "undocking" happens which will probably set otherPart to null.