Angel-125

[1.8.x] Snacks! - Friendly, Simplified Life Support

Recommended Posts

@Angel-125  Yes I added crew in the editors. All editor readouts are working as far as I know. Only when the vessel is launched already and being processed in the background is when it states indefinite when there is a recycler on. I will check the logs and post later as well.

Share this post


Link to post
Share on other sites
7 hours ago, DaGuyAboveYou said:

@Angel-125  Yes I added crew in the editors. All editor readouts are working as far as I know. Only when the vessel is launched already and being processed in the background is when it states indefinite when there is a recycler on. I will check the logs and post later as well.

Hm, I'd definitely need to see logs. I just tested a ship with crew and an active recycler and it's running and giving me viable numbers.

Share this post


Link to post
Share on other sites
Posted (edited)

I did report already before the KSP 1.7.x -compatiblity (Snacks v1.12). Did you take my report into account?

Spoiler
On 3/31/2019 at 11:01 PM, LatiMacciato said:

no worries, sounds good and ty for response :)

EDIT: SoilRecycler rates update!!

  • new finetuned standard rates for parts that use SoilRecycler modules
  • 2 Snacks/Soil per seat per day (at 100% efficiency set)
  • Readme.md corrections

grab the latest versions HERE | gitlab-repo | Feedback is always welcome!

EDIT2 (another bug-report):
I guess the math is basically incorrectly. Test conditions:

  • 1 Snacks per meal, 1 meal per day
  • 100% recycler & production efficiency
  • ~4 Soil and 0 Snacks in the vessel


Results using ARP (alternate resource panel):

  • 0 Kerbals --> ~4 days
  • 1 Sci Kerbals --> ~6 days
  • 2 Sci Kerbals --> ~8 days

This might just be another bug, in any case it breaks the recycler functionality!

Also I notice a couple of these:
 

  Reveal hidden contents



[ERR 01:03:05.800] Exception handling event onVesselChange in class SoilRecycler:System.NullReferenceException: Object reference not set to an instance of an object
  at BaseConverter.HasSpecialist (System.String effect) [0x00000] in <filename unknown>:0 
  at Snacks.SnackProcessor.PreProcessing () [0x00000] in <filename unknown>:0 
  at Snacks.SnacksConverter.updateBackgroundConverter () [0x00000] in <filename unknown>:0 
  at Snacks.SnacksConverter.onVesselChange (.Vessel vessel) [0x00000] in <filename unknown>:0 
  at EventData`1[Vessel].Fire (.Vessel data) [0x00000] in <filename unknown>:0 

[EXC 01:03:05.800] NullReferenceException: Object reference not set to an instance of an object
	BaseConverter.HasSpecialist (System.String effect)
	Snacks.SnackProcessor.PreProcessing ()
	Snacks.SnacksConverter.updateBackgroundConverter ()
	Snacks.SnacksConverter.onVesselChange (.Vessel vessel)
	EventData`1[Vessel].Fire (.Vessel data)
	UnityEngine.Debug:LogException(Exception)
	EventData`1:Fire(Vessel)
	FlightGlobals:setActiveVessel(Vessel, Boolean)
	FlightGlobals:SetActiveVessel(Vessel)
	ShipConstruction:AssembleForLaunch(ShipConstruct, String, String, String, Game, VesselCrewManifest, Boolean, Boolean, Boolean, Boolean, Orbit, Boolean, Boolean)
	ShipConstruction:AssembleForLaunch(ShipConstruct, String, String, String, Game, VesselCrewManifest)
	FlightDriver:setStartupNewVessel()
	FlightDriver:Start()

 

I just assume the recycler-efficiency is not applying correctly at some place, regardless of setting the recycler efficiency at 10, 50 and 100% it always applies the same rate of conversation of Soil to Snacks.

The above errors appear when I start a vessel at the launchpad.

I guess I might just patch the conversation rate for now with snacks-recyclers instead modifying the RecyclerCapacity until there is a patch out.

I hope this post is somehow helpful since I know it's abit cluttered.

 

Edited by LatiMacciato

Share this post


Link to post
Share on other sites
15 hours ago, LatiMacciato said:

I did report already before the KSP 1.7.x -compatiblity (Snacks v1.12). Did you take my report into account?

  Reveal hidden contents

 

Yup, fixed in next release.

Share this post


Link to post
Share on other sites

Snacks 1.13 is now available:

- Fixed recycler and processor efficiency calculations.
- Other bug fixes.

I also verified that if recyclers aren't at 100% you won't get an indefinite expiration time, but if they're set to 100% then you will.

Share this post


Link to post
Share on other sites

@Angel-125

Great mod and my new go-to for my Kerbal feeding needs.   :)

One thing I've found is the Radial snack container is missing when the "Restocked" mod is installed. 

vo8bTfH.png?1

Logs:

 

Share this post


Link to post
Share on other sites

Sounds like something needs to be whitelisted for ReStock

Share this post


Link to post
Share on other sites
26 minutes ago, JadeOfMaar said:

Snacks! has a Restock whitelist file since v1.11.5. @Death Engineering @linuxgurugamer

Is it possible that something was left out of the whitelist?  I'm referring specifically to this statement:

2 hours ago, Death Engineering said:

One thing I've found is the Radial snack container is missing when the "Restocked" mod is installed. 

 

2 hours ago, Death Engineering said:

You need to post the output_log.txt or KSP.log file, the error is most likely listed in one of those

Share this post


Link to post
Share on other sites

@linuxgurugamer I discovered (or, was clued into) the need for the whitelist in mid-March. Snacks has had this whitelist file for nearly a month now. ;) So either the complainant is rolling on an older version of Snacks! or they've somehow done something to delete the whitelist file.

Share this post


Link to post
Share on other sites
36 minutes ago, JadeOfMaar said:

@linuxgurugamer I discovered (or, was clued into) the need for the whitelist in mid-March. Snacks has had this whitelist file for nearly a month now. ;) So either the complainant is rolling on an older version of Snacks! or they've somehow done something to delete the whitelist file.

Ok.  I saw the message while on mobile, replied that way.

Share this post


Link to post
Share on other sites
Posted (edited)

Thanks for the input. I don't see output_log.txt   or  KSP . log   files and the whitelist file is present. Using the 1.1.3 snacks but will reinstall both buds after work.

Edit

I've reinstalled everything and confirmed the white list file is present. Nothing in the logs appear to resemble the error format seen on the Restock wiki. Hoping for some developer feedback? @Angel-125. Thanks

https://1drv.ms/u/s!AlN5OvBh91ORtyDUjU8KNJX_13UJ

Edited by Death Engineering

Share this post


Link to post
Share on other sites
On 4/24/2019 at 2:40 AM, Death Engineering said:

Thanks for the input. I don't see output_log.txt   or  KSP . log   files and the whitelist file is present. Using the 1.1.3 snacks but will reinstall both buds after work.

Edit

I've reinstalled everything and confirmed the white list file is present. Nothing in the logs appear to resemble the error format seen on the Restock wiki. Hoping for some developer feedback? @Angel-125. Thanks

https://1drv.ms/u/s!AlN5OvBh91ORtyDUjU8KNJX_13UJ

IDK, I'll need help from the Restock experts. My understanding is that the existing patch works...

Share this post


Link to post
Share on other sites
On 4/28/2019 at 4:24 PM, Tonka Crash said:

@Angel-125 @Death Engineering The whitelist is incorrectly named, so it is never read or applied Snacks/ModuleManagerPatches/SnacksRestock.whitelist should be Snacks.restockwhitelist

That would explain it. If renaming it to Snacks.restockwhitelist fixes the issue, I can create a patch. Could you please confirm?

Share this post


Link to post
Share on other sites
Just now, Angel-125 said:

That would explain it. If renaming it to Snacks.restockwhitelist fixes the issue, I can create a patch. Could you please confirm?

Someone else needs to confirm, I don't use Snacks!. I've just been dealing with whitelisting parts locally since Restock launched using the info on the Restock wiki

Share this post


Link to post
Share on other sites
On 5/2/2019 at 6:15 PM, Angel-125 said:

That would explain it. If renaming it to Snacks.restockwhitelist fixes the issue, I can create a patch. Could you please confirm?

Yes, renaming the file actually fixes the problem. Radial snack tin is present again in the Life Support section! :DhsjizK0.png

 

Share this post


Link to post
Share on other sites

I tested if Kerbals can actually die from lack of snacks (I enabled the setting manually) but it did not happen, even after half a year.

Can Kerbals even die during timewarp?

Share this post


Link to post
Share on other sites
4 hours ago, MarkusA380 said:

I tested if Kerbals can actually die from lack of snacks (I enabled the setting manually) but it did not happen, even after half a year.

Can Kerbals even die during timewarp?

Yes, if you enable the death penalty. It is disabled by default.

Share this post


Link to post
Share on other sites

Umm, i found today that all the inlinecontainers are not appearing, radial tincan is fine and working, version 1.14., KSP 1.7...

I have restock and restock+ installed, mm 4.0.2

Is there a reason snacks 1.14 comes with a older mm version? 

Share this post


Link to post
Share on other sites
2 hours ago, Mikki said:

 

Is there a reason snacks 1.14 comes with a older mm version? 

It is not uncommon given the frequency of MM releases.

Share this post


Link to post
Share on other sites
16 hours ago, Mikki said:

Umm, i found today that all the inlinecontainers are not appearing, radial tincan is fine and working, version 1.14., KSP 1.7...

I have restock and restock+ installed, mm 4.0.2

Is there a reason snacks 1.14 comes with a older mm version? 

I just figured out i pasted the mod the wrong way, it works now perfectly... all containers appeared.

Please excuse my stupidity... :blush:  Uhh... 

Share this post


Link to post
Share on other sites

Quick questions, hope someone can help:

Should there be background snack processing? The non active of my two bases don't seem to do that, those lazy kerbals consume them though.

Oh also, faster timewarp stops the snack processor with error: "Missing Electric Charge" but still plenty of charge left in those batteries...

 

Share this post


Link to post
Share on other sites

Snacks 1.15 is now available:

- Fixed issue where vessels spawned in game for rescue contracts lacked Snacks.
- Fixed integration issue with WalkAbout.
- The Soil Recycler now uses the Converter Skill from Engineers instead of the Science Skill. Yup, Scientists make Snacks from rocks and (sanitation) Engineers recycle Soil into Snacks.
- The converter and recycler won't automatically shut down if they lack an input resource or an output resource is full. Instead they'll wait until they get what they need.
- Updated the recycler/processor info view in the editor's part description window.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.