linuxgurugamer

[1.8.x] RecoveryController - Let FMRS and StageRecovery work together

Recommended Posts

Hi.

I tried the new version (0.0.3.5) but I did not see any changes when I click FMRS, same behavior as the previous version reported by Critter79606

There are two lines of the log file that are suspicious:

[ERR 21:34:28.345] ToolbarControl: WARNING: RegisterMod, LoadedScene: MAINMENU, called too late for: StageRecovery_NS, Stage Recovery, button may not be registered properly

[ERR 21:34:28.354] ToolbarControl: WARNING: RegisterMod, LoadedScene: MAINMENU, called too late for: FMRS_NS, Flight Manager for Reusable Stages, button may not be registered properly

 

Here the entire log:

https://drive.google.com/open?id=1HpBPUv8MBJDDZtTF-nqNGgMwhKZfX23p

Thanks.

Share this post


Link to post
Share on other sites
1 hour ago, vagabond77 said:

Hi.

I tried the new version (0.0.3.5) but I did not see any changes when I click FMRS, same behavior as the previous version reported by Critter79606

There are two lines of the log file that are suspicious:

[ERR 21:34:28.345] ToolbarControl: WARNING: RegisterMod, LoadedScene: MAINMENU, called too late for: StageRecovery_NS, Stage Recovery, button may not be registered properly

[ERR 21:34:28.354] ToolbarControl: WARNING: RegisterMod, LoadedScene: MAINMENU, called too late for: FMRS_NS, Flight Manager for Reusable Stages, button may not be registered properly

 

Here the entire log:

https://drive.google.com/open?id=1HpBPUv8MBJDDZtTF-nqNGgMwhKZfX23p

Thanks.

Those two lines are from the ToolbarController, and are only warnings, can be ignored.

When  you say "click FMRS", are you in the editor or in flight, and what exactly are you clicking?

Share this post


Link to post
Share on other sites
1 minute ago, linuxgurugamer said:

Those two lines are from the ToolbarController, and are only warnings, can be ignored.

When  you say "click FMRS", are you in the editor or in flight, and what exactly are you clicking?

I am in the editor, right click on decoupler and try to change RecoveryOwner.

But nothing happens, FMRS remains selected.

Share this post


Link to post
Share on other sites
3 hours ago, vagabond77 said:

I need the output_log.txt next time, please.

Please download this file: https://www.dropbox.com/s/ia0rzguih2u3w1k/RecoveryControllerDLL.zip?dl=0

and copy the DLL inside it into the GameData\RecoveryController\Plugins directory

Then run it again, get the failure, and send me the output_log.txt, please.  

See this link for instructions as to where to get the file:  http://forum.kerbalspaceprogram.com/index.php?/topic/83212-how-to-get-support-read-first/

Share this post


Link to post
Share on other sites

Since I stumbled upon the same issue:

output_log (using the RecoveryController.dll from above): https://www.dropbox.com/s/5fkkze8eve65cq9/output_log(FMRS_SR_RC).txt?dl=0

I was able to switch the recovery owner between 'FMRS', 'none' and 'auto' but stage recovery was still missing. Happend in the editor and in flight.

The test craft:

Spoiler

RDgn3lC.png

 

Edited by 4x4cheesecake

Share this post


Link to post
Share on other sites
16 hours ago, linuxgurugamer said:

I need the output_log.txt next time, please.

Please download this file: https://www.dropbox.com/s/ia0rzguih2u3w1k/RecoveryControllerDLL.zip?dl=0

and copy the DLL inside it into the GameData\RecoveryController\Plugins directory

Then run it again, get the failure, and send me the output_log.txt, please.  

See this link for instructions as to where to get the file:  http://forum.kerbalspaceprogram.com/index.php?/topic/83212-how-to-get-support-read-first/

I confirm the things written by 4x4cheesecake.
"I was able to switch the owner very much between 'FMRS', 'none' and 'auto' but the stage was still missing. Happend in the editor and in flight."
 
 
Thanks.

Share this post


Link to post
Share on other sites

Ok, so it seems that the problem is now with StageRecovery not registering with the RecoveryManager.  I saw that in both log files

If it doesn't hit me in the face, I'll probably get a debug version of SR out this evening, when I do, please test it and send me the logs.

Share this post


Link to post
Share on other sites

@vagabond77 @4x4cheesecake

Please try this DLL for StageRecovery:

https://www.dropbox.com/s/dkpe9g7n89mlmx6/StageRecoveryDLL.zip?dl=0

I did make one minor change which _might_ have an influence.  Again, please send me your log files, if it works, or if it doesn't work.

Thanks

Share this post


Link to post
Share on other sites
37 minutes ago, linuxgurugamer said:

Please try this DLL for StageRecovery:

ok :)

I was able to switch between all 4 recovery owner (FMRS, SR, auto, none) and tested it in flight as well to verify, that it is not just the textbox. All 4 modes worked as expected.

I tested two setups:
1) FMRS + SR(dropbox) + RC(dropbox) ->
https://www.dropbox.com/s/8hgth7sl4e7guuz/output_log (FMRS%2CSR(DB)%2CRC(DB)).txt?dl=0
2) FMRS + SR(dropbox) + RC(github release) -> https://www.dropbox.com/s/7olxwjtli2puowd/output_log(FMRS%2CSR(DB)%2CRC(ORG)).txt?dl=0

In both cases, I was able to set and use the different recovery owner, so if you did some code changes (beside debug stuff) to RC as well, they don't seem to affect the result.

13 minutes ago, vagabond77 said:

during the creation of a new game, if you enter the settings, a lot of error messages are generated in the KSP.log file.

I didn't tried this in my previous test but now and I can confirm this. It happens just while creating a new game but opening the settings in a loaded game works fine.

Edited by 4x4cheesecake

Share this post


Link to post
Share on other sites
14 minutes ago, vagabond77 said:

Now StageRecovery seems to work, I have not yet performed extensive tests, but I noticed that during the creation of a new game, if you enter the settings, a lot of error messages are generated in the KSP.log file.

https://drive.google.com/open?id=1fcdoFBb2N5iw0AUTciCQP3XZYt7qSdQc

Which settings, or any of the settings?

Oh, I see the problem.  Will work on it this evening

 

Edited by linuxgurugamer

Share this post


Link to post
Share on other sites
2 minutes ago, linuxgurugamer said:

Which settings, or any of the settings?

As soon as you hit the 'Difficulty Options' while creating a new game. You don't even have to navigate to the stage recovery settings, just open the window. BUT it only happens on a fresh launched game. Loading a savegame -> return to main menu -> creating a new game and attempt to change the difficulty settings will work without any exceptions.

Spoiler

Wk90e3l.png

https://www.dropbox.com/s/fy0ibapgaki5lhb/output_log(SR_dif_settings).txt?dl=0

Share this post


Link to post
Share on other sites
32 minutes ago, 4x4cheesecake said:

In both cases, I was able to set and use the different recovery owner, so if you did some code changes (beside debug stuff) to RC as well, they don't seem to affect the result.

The only code change was when SR starts, I think there was a race condition and it was starting too soon.

I know what's going on with the settings, but that will take a little bit to fix.  I hope to get to it this evening

Share this post


Link to post
Share on other sites

New release, 0.0.3.7

  • Changed startup option to instantly

Share this post


Link to post
Share on other sites

I'd like to modify the source code for being able to load/save the mod to use by default inside a txt file but I can't find the sources of RecoveryController anywhere on GitHub...

Any help?

 

Edit:

Nevermind, I just found it.

Apparently, It's not in the FMRS folder.

Edited by Frank Einstein

Share this post


Link to post
Share on other sites
2 hours ago, Frank Einstein said:

I'd like to modify the source code for being able to load/save the mod to use by default inside a txt file but I can't find the sources of RecoveryController anywhere on GitHub...

Any help?

 

Edit:

Nevermind, I just found it.

Apparently, It's not in the FMRS folder.

Why would you think it would be in the FMRS folder?  The OP lists exactly where it is:

Source Code: https://github.com/linuxgurugamer/FMRS  (folder inside FMRS)

Download: https://spacedock.info/mod/1311/RecoveryController

Share this post


Link to post
Share on other sites
58 minutes ago, Frank Einstein said:

I couldn't find it at:

 https://github.com/linuxgurugamer/FMRS

but a quick google research took me there:

https://github.com/linuxgurugamer/RecoveryController

 

I just finished compiling the modification, I just need to test it now.

Oh!  sorry, I had the wrong directory in the OP, I'll get it fixed.

Probably beceuse that's where it used to be

Share this post


Link to post
Share on other sites

New release, 0.0.4

  • Updated for KSP 1.8

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.