[KSP >= 1.3.0] TweakScale - Under Lisias' Management - 2.4.7.6 - 2024-0322

[Lisias]

2 hours ago, Krazy1 said:

That's a feature... until I can fix it. She used to explode on the runway, so I'm making progress.

I managed to take off by using all the airstrip, and rotating only after the gears are on the air. Trying to rotate before blows up the control surfaces and sometimes even the rear wings themselves.

She's too heavy for the physics engine, any more strong movement on the control surfaces overstress them and after that, the ground mysteriously starts to get nearer and nearer.

Try using Rigid Attachments on the control surfaces, this makes them slightly stronger. You may want to give Kerbal Joint Reinforcement/Next a try.

[Krazy1]

@LisiasThanks for the ideas. I tried rigid attachment turned on for everything (I usually think that's cheating but this is an exception). When it spawns and "eases in gravity" some tanks explode, but maybe select spots like you said might help. I split the flaps into two smaller ones - that helped. I still have the strut/ fuel duct issue but this time not when reverting to SPH. I was just moving or offsetting and I noticed it went haywire. Can't reproduce it again. I'll just save copies for now. Anyway, I was able to get it to orbit once! 

And another issue for you...engines flame cone and smoke size is not always scaling up depending on particular engine. I'm not even sure if you expect TS to scale these but it would look nice. It's only a visual issue. I made a test file with all the engines (except SRBs). Launch from SPH - too big for launch pad.

https://www.dropbox.com/s/gfnkdge1rgfj57d/TS engine test.craft?dl=0

It looks to me that these flame cones are not scaling: spark, twitch, poodle, reliant, dart, swivel, mainsail, skipper, terrier and LV-N. Smoke is harder to tell, but RAPIER at least is not.

Have KSP 1.10 with several mods but without Configurable Containers presently.  TS 2.4.3.18.

[Lisias]

13 minutes ago, Krazy1 said:

And another issue for you...engines flame cone and smoke size is not always scaling up depending on particular engine. I'm not even sure if you expect TS to scale these but it would look nice. It's only a visual issue. I made a test file with all the engines (except SRBs). Launch from SPH - too big for launch pad.

Yep, one of the oldest technical debits on TweakScale. I really hope I manage to finally tackle this down on the 2.4.4 series, I'm trying to reserve time to attack this issue for more than an year already, but something always gets in the way (as job, family, pandemics - I'm not saying they are related, however  - a bit perhaps? ).

https://github.com/net-lisias-ksp/TweakScale/issues/27

Let's see I can have this fixed for 1.10.1 - there're only  two tasks awaiting for the 2.4.4.0 release, I accomplishing that, 2.4.4.1 will have this thing fixed as it will be a bug hunt only release (no features)

[Mossconfig]

Is there a fix for this glitch?

[TranceaddicT]

1 hour ago, Mossconfig said:

Is there a fix for this glitch?

That means you have a double-patched part with a TS module that was deactivated. Drop your craft.file and KSP.log, we can figure it out.

Until then, no harm by it.

[Mossconfig]

Thanks!

https://drive.google.com/drive/folders/1d8i8m7Jlr56O_lZc7xtQ67PbxoZ0lkDh?usp=sharing

Is this everything?

[TranceaddicT]

7 hours ago, Mossconfig said:

Thanks!

https://drive.google.com/drive/folders/1d8i8m7Jlr56O_lZc7xtQ67PbxoZ0lkDh?usp=sharing

Is this everything?

Craft file fixed.

https://drive.google.com/drive/folders/1X87TN3kak12VcnQNcgrKUVRmBcKg407x?usp=sharing

[Lisias]

8 hours ago, Mossconfig said:

Thanks!

https://drive.google.com/drive/folders/1d8i8m7Jlr56O_lZc7xtQ67PbxoZ0lkDh?usp=sharing

Is this everything?

Yes, thank you!

First, the "good, besides annoying" news: your savegames are not at risk. The not so good news is that I cannot reproduce this problem on my machine,  because on my machine the following parts are fine and scalable!

[LOG 20:37:09.792] [TweakScale] ERROR: Part ionEngine (IX-6315 "Dawn" Electric Propulsion System) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.797] [TweakScale] ERROR: Part liquidEngineMini (48-7S "Spark" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.797] [TweakScale] ERROR: Part liquidEngineMiniRescale (Rockomax 56-8U) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.797] [TweakScale] ERROR: Part liquidEngineMini.v2 (48-7S "Spark" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.798] [TweakScale] ERROR: Part microEngine (LV-1 "Ant" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.799] [TweakScale] ERROR: Part microEngine.v2 (LV-1 "Ant" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.799] [TweakScale] ERROR: Part liquidEngine3 (LV-909 "Terrier" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.799] [TweakScale] ERROR: Part liquidEngine3.v2 (LV-909 "Terrier" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.799] [TweakScale] ERROR: Part nuclearEngine ("NERVA" Solid Core Fission Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.799] [TweakScale] ERROR: Part nuclearEngine-trimodal (LV-N Atomic Rocket Motor, trimodal) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.799] [TweakScale] ERROR: Part liquidEngine (LV-T30 "Reliant" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.800] [TweakScale] ERROR: Part liquidEngine2 (LV-T45 "Swivel" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.804] [TweakScale] ERROR: Part engineLargeSkipper (RE-I5 "Skipper" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.804] [TweakScale] ERROR: Part engineLargeSkipper.125m (Coxswain) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.804] [TweakScale] ERROR: Part SSME (S3 KS-25 "Vector" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.862] [TweakScale] ERROR: Part liquidEngineMiniTurbo (Rockomax 105-7P "Thunder" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.863] [TweakScale] ERROR: Part VenLV909b (LV-900 "Beagle" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.863] [TweakScale] ERROR: Part PoodleM (NT-5R "Shiba" Rocket Motor) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0
[LOG 20:37:09.864] [TweakScale] ERROR: Part LVT15 (LV-T15 "Dachshund" Liquid Fuel Engine) didn't passed the sanity check due having a ModulePartVariants with Mass - see issue [#13]( https://github.com/net-lisias-ksp/TweakScale/issues/13 ). at error:0

I'm guessing about what had bitten you. I just released a new version of TweakScale where I expect the issue is handled correctly.

Please download and install the newest release: https://github.com/net-lisias-ksp/TweakScale/releases

You will have that "Rogue" stunt happening on you only one more time by savegame or craft file. Once you save them again, you should not be bothered by it again.

 

45 minutes ago, TranceaddicT said:

Craft file fixed.

https://drive.google.com/drive/folders/1X87TN3kak12VcnQNcgrKUVRmBcKg407x?usp=sharing

Unfortunately, it will break again. Whatever had happened on the instalment, needs to be tacked down by the newest final version of TweakScale.

 

@renejant, I think this will tackle down your problem too! Give it a try!

Edited July 19, 2020 by Lisias
Hit "Save" too soon.

[Krazy1]

Regarding the issue I saw with fuel tank cost using Configurable Containers a couple pages back: I tried SimpleFuelSwitch instead. It has all the functionality I need and it does work IF you change the fuel type before you scale it. Changing type after scaling reverts to stock fuel quantity. IMO CC borders cheating because it allows changing fuel type in game. 

[Lisias]

Just now, Krazy1 said:

Regarding the issue I saw with fuel tank cost using Configurable Containers a couple pages back: I tried SimpleFuelSwitch instead. It has all the functionality I need and it does work IF you change the fuel type before you scale it. Changing type after scaling reverts to stock fuel quantity.

Great! This means that supporting it will be easy (famous last words, I know).

I will try something at the end of the day and let you know for beta testing it.

 

1 minute ago, Krazy1 said:

IMO CC borders cheating because it allows changing fuel type in game. 

Depends of the fuel. Cryogenics needs very specialised tanks, hypergolics demands everything to be highly specialised and controlled - but in general, you can fill a flex car with alcohol, gas or a mix of them, right? As long the engine can handle the contamination, you can do it on real life too.

In KSP, everything is just a "Resource". From Liquid Fuel to Ore, it's all the same. If you have a resource rich instalment (water, metal ore, mineral ore, fertiliser, etc), being able to switch what you want to shove on that tank can make the thing more real. But I agree that not allowing a tank used for some kind of resources to be switched to some others (as LFO and water - that would ruin the water) would create some very interesting challenges.

[TranceaddicT]

3 hours ago, Lisias said:

Unfortunately, it will break again. Whatever had happened on the instalment, needs to be tacked down by the newest final version of TweakScale.

Yeah, I just wanted to get that out to him because it had been a while since he posted.

I was hoping to complete the log analysis this morn before he launched.  Looks like you beat me to the punch.

[Mossconfig]

The parts I know for sure to be  broken are fixed now, so thanks for that!

[Lisias]

3 hours ago, Mossconfig said:

The parts I know for sure to be  broken are fixed now, so thanks for that!

Just to clarify, the parts weren't exactly broken. On your specific case, it was a TweakScale glitch on handling an already known unsupported situation (and so it's not a bug neither, it's just something that TweakScale can't handle) that got unnoticed for months and your "Rogue" problem was the last line of defense against the consequences.

What I did wrong: see https://github.com/net-lisias-ksp/TweakScale/issues/125 , things will be explained there somewhere between tonight and tomorrow (I've got incredibly busy this whole week, today included).

What I did right: the last line of defense. Had people didn't complained about it, that glitch would go unnoticed for years - not to mention the theoretical potential for breakage that I managed to materialise on my test rig once, but only once (already inspect the Add'On that triggered it, and found no code that could do that, so it's just a trigger for the problem, no the culprit). Until the moment, have no confirmed reports from this from the wild. Thankfully.  

[renejant]

9 hours ago, Lisias said:

@renejant, I think this will tackle down your problem too! Give it a try!

I did, but it was a failure! the problem still persists. I even started a new game and put the "spacey" parts on it, saved the craft and ét voila! problem was back! The problem only persists on certain spacey parts that i use the most, namely SYdecouplerRadial1 (decouplers for SRB's) and the SYejectatron...  Other parts of spacey are just fine and gives no problems, so i am thinking that those parts are wrongly configured by the author... Even the Add-on hasn't been updated for years...

i am clueless on how we could fix this issue... thinking about removing those 2 parts from the Add-on, seeing there are plenty of alternatives to use... 

logfile and craft file can be downloaded here:

new tweakscale test

Edited July 19, 2020 by renejant

[TranceaddicT]

1 minute ago, renejant said:

If you want, i can provide you a new log and craft file for you?

Always provide a log and and additional files that can help.

Oh, and don't ever use the "If you want."  You don't want to ever hear that NO, on the tip of everyone's tongue. 

[renejant]

1 minute ago, TranceaddicT said:

Always provide a log and and additional files that can help.

Oh, and don't ever use the "If you want."  You don't want to ever hear that NO, on the tip of everyone's tongue. 

re-read my post again please, i adjusted it in the meanwhile you replied!

[Lisias]

1 hour ago, renejant said:

I did, but it was a failure! the problem still persists. I even started a new game and put the "spacey" parts on it, saved the craft and ét voila! problem was back! The problem only persists on certain spacey parts that i use the most, namely SYdecouplerRadial1 (decouplers for SRB's) and the SYejectatron...  Other parts of spacey are just fine and gives no problems, so i am thinking that those parts are wrongly configured by the author... Even the Add-on hasn't been updated for years...

Oh, well.. So this one is not my fault after all.  Damn.

 

1 hour ago, renejant said:

i am clueless on how we could fix this issue... thinking about removing those 2 parts from the Add-on, seeing there are plenty of alternatives to use... 

Keep that instalment for debugging purposes, if you want. It will help a lot to tackle down this pesky bug.

Until the moment, I have no evidences that this could be dangerous for you, but at least once I forced a situation on my test bed where the rogue patch would be inserted before the rightful one on a ongoing savegame, and this tricks TweakScale into thinking the good one is the rogue.

 

1 hour ago, renejant said:

logfile and craft file can be downloaded here:

new tweakscale test

Let's give this a new shot:

[LOG 00:25:10.145] Applying update FuelTanksPlus/Patch-1.9.1/@PART[*]:NEEDS[FuelTanksPlus] to SpaceY-Lifters/Parts/Decouplers/SYdecouplerRadial/SYdecouplerRadial1.cfg/PART[SYdecouplerRadial1]
[LOG 00:25:10.511] Applying update ModRocketSysLite/Patches/MRS_TweakScale/@PART[SYdecouplerRadial1]:NEEDS[TweakScale] to SpaceY-Lifters/Parts/Decouplers/SYdecouplerRadial/SYdecouplerRadial1.cfg/PART[SYdecouplerRadial1]
[LOG 00:25:10.889] Applying update SpaceY-Lifters/Patches/0_TechTree/@PART[SY*]:NEEDS[!CommunityTechTree&!HPTechTree] to SpaceY-Lifters/Parts/Decouplers/SYdecouplerRadial/SYdecouplerRadial1.cfg/PART[SYdecouplerRadial1]
[LOG 00:25:10.927] Applying update SpaceY-Lifters/Patches/SpaceY_TweakScale/@PART[SYdecouplerRadial1]:NEEDS[TweakScale] to SpaceY-Lifters/Parts/Decouplers/SYdecouplerRadial/SYdecouplerRadial1.cfg/PART[SYdecouplerRadial1]
[LOG 00:25:19.907] Applying update BetterBurnTime/SRBurnTime/@PART[*]:HAS[@RESOURCE[SolidFuel],@MODULE[ModuleEngines]:HAS[@PROPELLANT[SolidFuel]]]:FINAL to SpaceY-Lifters/Parts/Decouplers/SYdecouplerRadial/SYdecouplerRadial1.cfg/PART[SYdecouplerRadial1]
[LOG 00:25:20.084] Applying update InterstellarFuelSwitch/PatchManager/ActiveMMPatches/IntegratedDecoupler/@PART[*]:FINAL to SpaceY-Lifters/Parts/Decouplers/SYdecouplerRadial/SYdecouplerRadial1.cfg/PART[SYdecouplerRadial1]
[LOG 00:25:20.407] Applying update PartInfo/PartInfo/@PART[*]:Final to SpaceY-Lifters/Parts/Decouplers/SYdecouplerRadial/SYdecouplerRadial1.cfg/PART[SYdecouplerRadial1]

So yeah, it's still our friends MRS_TweakScale and SpaceY_TweakScale stomping each other toes.

Humm... On a second thought... Perhaps it is my fault... Try this hot-fix again (save it using the Raw button into GameData/__LOCAL/TweakScale/HotFixes directory). If I'm right, the Rogue Duplicated will vanish this time with the newest release.

-- -- 

Link to my previous attempt on this here.

Link to my first attempt here.

Edited July 19, 2020 by Lisias
Forgot the link for the hotfix! :P

[renejant]

49 minutes ago, Lisias said:

If I'm right, the Rogue Duplicated will vanish this time with the newest release.

Yes!!!! It works!

but.........HOUSTON.....we got another problem! -sigh-

The fix works, but as a side effect, after loading a craft (the ones with the tweakscalerogueduplicate problem on it) it blows up the textures of the ship 

So i don't know if you can counteract that part? because initially the fix works, so something is messing the whole thing up... i dunno if you can take a look at my files and see what goes wrong here?

Fix works, but now texture problems...

I have provided new files after i tested it. even put in a .loadmeta file of the craft that affects this...

Do mind me, that i tested this on Sandbox1.9 (old savegame) where found the problem with the textures

On the new Sandbox1.10 the rogue problem disappears and no texture problem was detected...yet! So maybe my 1.9 save got corrupted somehow???

[Lisias]

19 minutes ago, renejant said:

Yes!!!! It works!

but.........HOUSTON.....we got another problem! -sigh-

The fix works, but as a side effect, after loading a craft (the ones with the tweakscalerogueduplicate problem on it) it blows up the textures of the ship 

So I was innocent of this one, because it's the same behaviour as before the TweakScale update. Damn.

 

19 minutes ago, renejant said:

So i don't know if you can counteract that part? because initially the fix works, so something is messing the whole thing up... i dunno if you can take a look at my files and see what goes wrong here?

Fix works, but now texture problems...

I have provided new files after i tested it. even put in a .loadmeta file of the craft that affects this...

Well, get rid of the patch, take the toll of the Rogue warning for a few more days. I will work on my lint tool to expand it to be a SFS lint, and then I will cook something to fix your SFS - and then you apply again the patch to be used on the fixed SFS.

 

21 minutes ago, renejant said:

Do mind me, that i tested this on Sandbox1.9 (old savegame) where found the problem with the textures

On the new Sandbox1.10 the rogue problem disappears and no texture problem was detected...yet! So maybe my 1.9 save got corrupted somehow???

Interesting...

Please give me a copy of the KSP.log and the whole shebang (inclusing SFS) from the KSP. 1.9 with the problem and from KSP 1.10 where things are solved. This will help me a lot, because the problem lies on where the instalments differ! Way less things to check!

[TranceaddicT]

44 minutes ago, renejant said:

The fix works, but as a side effect, after loading a craft (the ones with the tweakscalerogueduplicate problem on it) it blows up the textures of the ship 

You still have that craft.file on my Google Drive.

[LittleBitMore]

All this time, many many months of using Tweakscale, and I never knew you could pick sizes IN BETWEEN the ones provided with those little arrow buttons.

I can only blame myself for my stupidity.

Edited July 20, 2020 by LittleBitMore

[TranceaddicT]

Just now, LittleBitMore said:

All this time, many many months of using Tweakscale, and I never knew you could pick sizes IN BETWEEN the ones provided with those little arrow buttons.

I can only blame myself for my stupidity.

My first rule for anything new I get my hands on ... play with the knobs, levers, and sliders.

The one constant in my life is "Should Can I do that?"

[Lisias]

1 hour ago, LittleBitMore said:

All this time, many many months of using Tweakscale, and I never knew you could pick sizes IN BETWEEN the ones provided with those little arrow buttons.

I'm the maintainer of the thing, and guess when I found we can hit CTRL-K to chain-scale subtrees of the craft?

 

1 hour ago, TranceaddicT said:

The one constant in my life is "Should Can I do that?"

I'm slightly different: "Should I had done that?" - when the answer is "no", things became pretty interesting pretty fast.  

Edited July 20, 2020 by Lisias
Hit "Save" too soon.

[LittleBitMore]

I noticed a few stock non-DLC parts, specifically some antennas and dishes, do not function with Tweakscale and have not ever functioned with it. What's the cause of this, and is it likely to be fixed in the future?

Edited July 20, 2020 by LittleBitMore

[renejant]

7 hours ago, Lisias said:

Please give me a copy of the KSP.log and the whole shebang (inclusing SFS) from the KSP. 1.9 with the problem and from KSP 1.10 where things are solved. This will help me a lot, because the problem lies on where the instalments differ! Way less things to check!

new files on server

Here they are Lisias, i have uploaded my 2 whole savegames to the server, i hope it is all you need...