ensou04 Posted November 20, 2020 Author Share Posted November 20, 2020 1 hour ago, Gabriel B said: I just have a suggestion, why don't you add stock propeller and blade sounds? thats on the works 22 minutes ago, Idleness said: I am not sure if this is an artefact of the new release / configs, or if it is a product of my own hardware but it certainly does not crackle badly in any other applications that I use. Maybe there is a setting I can adjust? I've encountered this issue but i cant seem to pin point what is causing it, there is a chance that the samples themselves are causing crackling so they have to be remastered. Try Disabling Both Audio Muffling and Limiters and see if it still happens then report back. I cant honestly check for myself because my speakers are a bit busted so it crackles by itself sometimes. Quote Link to comment Share on other sites More sharing options...
Idleness Posted November 20, 2020 Share Posted November 20, 2020 20 minutes ago, ensou04 said: I've encountered this issue but i cant seem to pin point what is causing it, there is a chance that the samples themselves are causing crackling so they have to be remastered. Try Disabling Both Audio Muffling and Limiters and see if it still happens then report back. I cant honestly check for myself because my speakers are a bit busted so it crackles by itself sometimes. I'll try this out - silly question, how am I invoking the options from within the game or will I need to start a new game with the options as you describe? Quote Link to comment Share on other sites More sharing options...
ensou04 Posted November 20, 2020 Author Share Posted November 20, 2020 (edited) 10 minutes ago, Idleness said: I'll try this out - silly question, how am I invoking the options from within the game or will I need to start a new game with the options as you describe? no need to restart, your settings will apply upon unpausing. I Think I found the problem, The Audio Limiter is probably causing it. try adjusting the Attack time to a higher number, although that means Volume reduction will be slower and some Transients of suddenly loud sounds will go through Regardless, I'll try working on it's code and see what can I do. Edited November 20, 2020 by ensou04 Quote Link to comment Share on other sites More sharing options...
Idleness Posted November 20, 2020 Share Posted November 20, 2020 6 minutes ago, ensou04 said: no need to restart, your settings will apply upon unpausing. I Think I found the problem, The Audio Limiter is probably causing it. try adjusting the Attack time to a higher number, although that means Volume reduction will be slower and some Transients of suddenly loud sounds will go through Regardless, I'll try working on it's code and see what can I do. I started a new game with the debug window. I was asking because I cannot see the RSE options from within a current game - I only see them while setting up the game. There's no toolbar button, and if a key combo invokes it I don't know what it would be. Further, I turned off the muffling and limiters and still heard it. Seemed to be when SoundLayer = Thrust_Low was active. It's 1 sound and I think it ticks/crackles at the end of the track maybe? I'll test more with adjustments to attack time (higher). Quote Link to comment Share on other sites More sharing options...
ensou04 Posted November 20, 2020 Author Share Posted November 20, 2020 2 minutes ago, Idleness said: I started a new game with the debug window. I was asking because I cannot see the RSE options from within a current game - I only see them while setting up the game. There's no toolbar button, and if a key combo invokes it I don't know what it would be. It should be in the Difficulty Options in-game. Also SoundLayer = Thrust_Low is an interior sound, the Debug window only shows ShipEffects soundlayers Quote Link to comment Share on other sites More sharing options...
Idleness Posted November 20, 2020 Share Posted November 20, 2020 1 minute ago, ensou04 said: It should be in the Difficulty Options in-game. Also SoundLayer = Thrust_Low is an interior sound, the Debug window only shows ShipEffects soundlayers Duh... sorry, brain fart there. I also just started using Waterfall and it has a button/editor in game that I was playing with. I changed to Attack = 25 and it still seemed to occur. Confirmed it's still happening even when thrust layer was inactive. Seemed to follow a specific pattern too; as if there was a transition or loop that it kept going back to when the crackles happen. Quote Link to comment Share on other sites More sharing options...
ensou04 Posted November 20, 2020 Author Share Posted November 20, 2020 (edited) 4 minutes ago, Idleness said: I changed to Attack = 25 and it still seemed to occur. Confirmed it's still happening even when thrust layer was inactive. Seemed to follow a specific pattern too; as if there was a transition or loop that it kept going back to when the crackles happen. I can confirm it is indeed the Audio Limiter, its either spending too much time calculating the current Loudness or the Reduction is not as smooth as it should be. I'm working on the fix now. EDIT: I found that its the Reduction that's causing clicking and crackling whenever it changes too drastically (in this case a change as small as 0.05). Edited November 20, 2020 by ensou04 Quote Link to comment Share on other sites More sharing options...
Beetlecat Posted November 20, 2020 Share Posted November 20, 2020 Superb! Looking forward to all the new sounds for rovers/buggies! Quote Link to comment Share on other sites More sharing options...
Stone Blue Posted November 20, 2020 Share Posted November 20, 2020 (edited) Are the sounds in IVA, the same sounds in exterior view? If not too much trouble, or not already done, might be nice to have the IVA sounds filtered much lower, less trebly/mid-range, and less loud... vOv Meebe even add some hull creaking? LOL Edited November 20, 2020 by Stone Blue Quote Link to comment Share on other sites More sharing options...
ensou04 Posted November 20, 2020 Author Share Posted November 20, 2020 (edited) Update Version v0.5.1 Use the Config/Library from v0.5.0 Work on the limiter is still being done and might be replaced in the future. Added Whitelist for Chatterer Reduced sound cracking from Audio Limiter by moving the Volume Reduction code from LateUpdate() to OnAudioFilterRead() Download (Plugin): https://github.com/ensou04/RocketSoundEnhancement/releases/tag/0.5.1 Edited November 20, 2020 by ensou04 Quote Link to comment Share on other sites More sharing options...
linuxgurugamer Posted November 20, 2020 Share Posted November 20, 2020 @ensou04any chance to get this into CKAN? Quote Link to comment Share on other sites More sharing options...
ensou04 Posted November 20, 2020 Author Share Posted November 20, 2020 @linuxgurugamer Yes, I guess its time for CKAN. I just have to figure out how to do it Quote Link to comment Share on other sites More sharing options...
linuxgurugamer Posted November 20, 2020 Share Posted November 20, 2020 3 minutes ago, ensou04 said: @linuxgurugamer Yes, I guess its time for CKAN. I just have to figure out how to do it Or you could ask me I didn't look, do you have a valid JSON .version file in the mod? Quote Link to comment Share on other sites More sharing options...
ensou04 Posted November 20, 2020 Author Share Posted November 20, 2020 (edited) 38 minutes ago, linuxgurugamer said: Or you could ask me I didn't look, do you have a valid JSON .version file in the mod? oh lol that'd be great sir also no I have not added that yet. i should probably go ahead and do it. EDIT: @linuxgurugamer ok its done, I hope I did it right Edited November 20, 2020 by ensou04 Quote Link to comment Share on other sites More sharing options...
linuxgurugamer Posted November 20, 2020 Share Posted November 20, 2020 2 hours ago, ensou04 said: oh lol that'd be great sir also no I have not added that yet. i should probably go ahead and do it. EDIT: @linuxgurugamer ok its done, I hope I did it right Nope, got a syntax error. Just an FYI, I use a site: https://jsonformatter.org/ to validate JSON And, while it's not a problem, the version file is _usually_ put into the main mod directory, not it's own directory. Not critical. You have an extra comma after the work "false". Here is the corrected: { "NAME": "Rocket Sound Enhancement", "URL": "https://raw.githubusercontent.com/ensou04/RocketSoundEnhancement/master/GameData/RocketSoundEnhancement/Versioning/RocketSoundEnhancement.version", "DOWNLOAD": "https://github.com/ensou04/RocketSoundEnhancement/releases", "GITHUB": { "USERNAME": "ensou04", "REPOSITORY": "RocketSoundEnhancement", "ALLOW_PRE_RELEASE": false }, "VERSION": { "MAJOR": 0, "MINOR": 5, "PATCH": 1, "BUILD": 0 }, "KSP_VERSION": { "MAJOR": 1, "MINOR": 10, "PATCH": 1 }, "KSP_VERSION_MIN": { "MAJOR": 1, "MINOR": 10, "PATCH": 1 }, "KSP_VERSION_MAX": { "MAJOR": 1, "MINOR": 10, "PATCH": 99 } } Quote Link to comment Share on other sites More sharing options...
ensou04 Posted November 21, 2020 Author Share Posted November 21, 2020 @linuxgurugamer ok its fixed now thanks for the heads up Quote Link to comment Share on other sites More sharing options...
Kari Posted November 21, 2020 Share Posted November 21, 2020 (edited) First of all, this is amazing, my expectations were high and they were met. But here's the sad part, I got 117 errors in shipeffects.cfg (i didn't screenshot it but I took this from the module manager log) Spoiler [LOG 18:34:38.387] ModuleManager: 18680 patches applied, found <color=orange>117 errors</color> 117 errors related to GameData/RocketSoundEnhancement/Configs/ShipEffects.cfg Here's what I have in gamedata and here's my player.log (I did play for a while so it's kinda long) Spoiler Diretório: D:\Games\SteamLibrary\steamapps\common\Kerbal Space Program\GameData Mode LastWriteTime Length Name ---- ------------- ------ ---- d----- 20/11/2020 01:23 000_ClickThroughBlocker d----- 19/11/2020 21:47 000_FilterExtensions d----- 19/11/2020 21:47 000_FilterExtensions_Configs d----- 19/11/2020 22:17 000_TexturesUnlimited d----- 19/11/2020 22:18 001_ToolbarControl d----- 19/11/2020 22:13 002_CommunityPartsTitles d----- 20/11/2020 00:21 AECS_Motion_Suppressor d----- 19/11/2020 21:43 AltimeterAutoHide d----- 20/11/2020 16:43 AnimatedDecouplers d----- 20/11/2020 01:20 AtmosphereAutopilot d----- 19/11/2020 21:47 B9PartSwitch d----- 19/11/2020 22:23 BetterBurnTime d----- 19/11/2020 21:43 BetterSRBs d----- 19/11/2020 21:47 CommunityCategoryKit d----- 19/11/2020 21:46 CommunityResourcePack d----- 19/11/2020 21:47 CommunityTechTree d----- 29/10/2020 18:04 ConformalDecals d----- 19/11/2020 22:27 ContractConfigurator d----- 19/11/2020 22:27 CraftManager d----- 19/11/2020 21:43 CrowdSourcedScience d----- 19/11/2020 21:43 CustomBarnKit d----- 19/11/2020 21:43 DistantObject d----- 19/11/2020 21:43 DodoLabs d----- 19/11/2020 21:47 DynamicBatteryStorage d----- 19/11/2020 21:43 EasyVesselSwitch d----- 19/11/2020 21:43 EditorExtensionsRedux d----- 19/11/2020 22:13 FillItUp d----- 19/11/2020 22:18 FShangarExtender d----- 19/11/2020 21:43 KAS d----- 19/11/2020 22:37 KeepItStraight d----- 17/11/2020 16:05 KeR-7 d----- 20/11/2020 18:33 KerbalEngineer d----- 19/11/2020 21:43 Kerbalism d----- 19/11/2020 21:43 KerbalismConfig d----- 19/11/2020 21:43 KerbalJointReinforcement d----- 19/11/2020 21:46 KerbalReusabilityExpansion d----- 19/11/2020 21:43 KIS d----- 20/11/2020 16:14 KiwiTechTree d----- 20/11/2020 18:28 Kopernicus d----- 19/11/2020 21:47 KXAPI d----- 20/11/2020 00:16 MagpieMods d----- 19/11/2020 22:17 MakingLessHistory d----- 19/11/2020 21:44 MechJeb2 d----- 19/11/2020 21:44 Mk2Expansion d----- 19/11/2020 21:47 ModularFlightIntegrator d----- 20/11/2020 18:22 ModularLaunchPads d----- 19/11/2020 22:18 NavHud d----- 19/11/2020 21:44 NearFutureConstruction d----- 19/11/2020 21:44 NearFutureElectrical d----- 19/11/2020 21:47 NearFutureProps d----- 19/11/2020 21:44 NearFuturePropulsion d----- 19/11/2020 21:44 NearFutureSolar d----- 19/11/2020 21:45 NearFutureSpacecraft d----- 19/11/2020 21:45 PartInfo d----- 20/11/2020 17:58 PatchManager d----- 20/11/2020 00:08 ProceduralFairings d----- 20/11/2020 16:15 RationalResources d----- 20/11/2020 16:15 RationalResourcesParts d----- 20/11/2020 00:08 RCSBuildAid d----- 19/11/2020 21:45 RealHeat d----- 20/11/2020 18:29 Rescale 2.5x d----- 19/11/2020 21:45 ResonantOrbitCalculator d----- 19/11/2020 21:45 ReStock d----- 19/11/2020 21:46 ReStockPlus d----- 20/11/2020 16:43 RetractableLiftingSurface d----- 19/11/2020 21:28 RocketSoundEnhancement d----- 20/11/2020 00:14 ScienceParamModifier d----- 29/10/2020 18:04 Shabby d----- 20/11/2020 18:04 Sigma d----- 19/11/2020 21:46 SmartDockingAid d----- 19/11/2020 21:46 SpaceTuxLibrary d----- 19/11/2020 22:13 SpeedUnitAnnex d----- 29/10/2020 00:40 Squad d----- 28/10/2020 23:16 SquadExpansion d----- 19/11/2020 21:46 Strategia d----- 20/11/2020 00:21 TimeControl d----- 19/11/2020 21:46 TrimIndicator d----- 20/11/2020 16:43 TundraExploration d----- 20/11/2020 21:56 TURD d----- 20/11/2020 00:15 Waterfall d----- 20/11/2020 00:15 WaterfallRestock d----- 19/11/2020 21:46 WaypointManager d----- 20/11/2020 17:56 WildBlueIndustries d----- 19/11/2020 21:47 ZeroMiniAVC d----- 19/11/2020 21:43 zFinal_FilterExtensions -a---- 20/11/2020 21:59 0 listmyfolder.txt -a---- 19/11/2020 21:47 141312 ModuleManager.4.1.4.dll -a---- 20/11/2020 18:34 9218 ModuleManager.Physics -a---- 20/11/2020 18:34 105689 ModuleManager.TechTree Any idea? The game runs just fine Edited November 21, 2020 by Karin Quote Link to comment Share on other sites More sharing options...
linuxgurugamer Posted November 21, 2020 Share Posted November 21, 2020 1 hour ago, ensou04 said: @linuxgurugamer ok its fixed now thanks for the heads up Ok, the RocketSoundenhancement-v0.5.1-plugin.zip is good. What about the configs, I don't see anything in there Quote Link to comment Share on other sites More sharing options...
RurouniDonut Posted November 21, 2020 Share Posted November 21, 2020 14 hours ago, ensou04 said: I'm not sure entirely how RO patches work but I'm pretty sure you need the AFTER:[RO-MODNAMEHERE] to ensure the patches from RO already exists before RSE Default library gets applied to it. you have to be sure you're removing the original sounds as well. Its probably simpler if RO natively supports the Default library though. but thats up to the RO guys. Hmm, I tried more with making the patch for at least one part but no success. Even with just a bare bones RO install with no submods. Although, I don't know much about MM at all so I could be doing something very wrong. Quote Link to comment Share on other sites More sharing options...
ensou04 Posted November 21, 2020 Author Share Posted November 21, 2020 (edited) 20 minutes ago, linuxgurugamer said: What about the configs, I don't see anything in there I'm sorry I actually forgot to change the URL as well, both configs and plugin has the correct .versions now 19 minutes ago, RurouniDonut said: Although, I don't know much about MM at all so I could be doing something very wrong. you should check out the MM handbook on its wiki page @Karin have you tried deleting MM cache? sometimes the cache causes errors Edit: ok i've checked the log you can ignore the errors. but still delete MM cache if you haven't already, its the collision module getting applied to some Procedural Fairings and 2 parts "GD_RT_unmannedTech" and "GD_RT_advUnmanned" which has no crashTolerance that's causing the errors. Edited November 21, 2020 by ensou04 Quote Link to comment Share on other sites More sharing options...
linuxgurugamer Posted November 21, 2020 Share Posted November 21, 2020 Files are generated, I've asked @HebaruSan to review, since you have two different files in different releases. Quote Link to comment Share on other sites More sharing options...
Kari Posted November 21, 2020 Share Posted November 21, 2020 31 minutes ago, ensou04 said: @Karin have you tried deleting MM cache? sometimes the cache causes errors Edit: ok i've checked the log you can ignore the errors. but still delete MM cache if you haven't already, its the collision module getting applied to some Procedural Fairings and 2 parts "GD_RT_unmannedTech" and "GD_RT_advUnmanned" which has no crashTolerance that's causing the errors. @ensou04 I deleted them but nothing changed. I used your info to find what exactly was messing up and turns out it was a filter extensions patch on remote tech and the procedural fairings was some dummy parts that represent the upgrades in the tech tree The RT patch I deleted it since I don't use RT and to fix the procedural fairings errors I added a random crash tolerance to the dummy parts and it worked, no errors now! These are the files if someone else ran into these annoying errors Spoiler GameData\zFinal_FilterExtensions\zzz_RemoteTechAddMissingModuleSPUPassive.cfg GameData\ProceduralFairings\PF_Settings.cfg Thanks for your help! Quote Link to comment Share on other sites More sharing options...
RurouniDonut Posted November 21, 2020 Share Posted November 21, 2020 10 minutes ago, ensou04 said: I'm sorry I actually forgot to change the URL as well, both configs and plugin has the correct .versions now you should check out the MM handbook on its wiki page @Karin have you tried deleting MM cache? sometimes the cache causes errors I checked it out, and as far as I can tell it should be playing the new sounds for this one part because RO just edits stock parts for the engine configs. The very heavy config already has @@Part[Size3AdvancedEngine] Which this engine is using that as well. Sorry if I'm being annoying at all. I just really want to use it :DD Quote Link to comment Share on other sites More sharing options...
Beetlecat Posted November 21, 2020 Share Posted November 21, 2020 (edited) The current zip in the "releases" section on github for v5.1 only contains the dll and a config file. The "Library and Configs" are downloadable in the v5.0 release just below (if you show all releases) -- This is going to confuse CKAN as well as us users. I definitely see the utility of splitting them off so separate packs can be loaded or skipped. Edited November 21, 2020 by Beetlecat Quote Link to comment Share on other sites More sharing options...
ensou04 Posted November 21, 2020 Author Share Posted November 21, 2020 8 hours ago, linuxgurugamer said: Files are generated, I've asked @HebaruSan to review, since you have two different files in different releases. Thanks man! appreciate the help! @Karin im glad that fixed it, are the dummy parts actual parts in game or no? because if not then i'll add a flag to the patches to make sure the Collision module only gets applied to parts that has crashTolerance 5 hours ago, Beetlecat said: I definitely see the utility of splitting them off so separate packs can be loaded or skipped. yeah because technically speaking, this is two mods in one. the configs and sound library rarely get any updates unlike the Plugin. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.