Jump to content

[1.12.x] Dynamic Battery Storage: electrical/thermal planning and timewarp compensation (August 11)


Nertea

Recommended Posts

One thing I have noticed, the drills ( resource extractors ) are showing in the power generation category rather than the power consumption category.  They generate ore, but they consume electric, so likely that's the issue.

Can can open an issue on GitHub if you want.

Also, still seeing some additional odd behavior with Labs and Snacks! Soil Recyclers consuming some oddly huge and varying amounts of electricity.  ( Orbital Science Lab around Minmus with PXL 3 lab from SSPXR + 3 Level 2 scientists plus a few other hab components using bursts of > 70 ec/s.  Have 40k battery storage ).  I know you mentioned already that Science Lab power consumption is hard to calculate / model, so I'm doing some actual run tests to figure out consumption rates for my ships / stations, but if you have any pointers on how to help provide more data to improve the NFE models.  I build and tune my reactor outputs to handle what shows as the steady state ( trying to keep a low net positive ec/s flow), but there are odd spikes where my battery capacity plummets, but I have not made any changes to whats running ( in terms of recyclers, lab research, etc. ) or run a really high timewarp.

Link to comment
Share on other sites

4 hours ago, Ocid said:

Hi

I tried to update my game from 1.4.5 to 1.7.3.

However during my save DBS spits out a lot of messages. Of a 76k line log file 50k of them are from DBS atleast when you search [Dynamic Battery Storage]. Is there anyway to fix this.

Heres the log KSP Log

Thanks.

Install the latest version of the mod :).

5 hours ago, coredumpster said:

One thing I have noticed, the drills ( resource extractors ) are showing in the power generation category rather than the power consumption category.  They generate ore, but they consume electric, so likely that's the issue.

Easy fix, it can actually be changed in the settings cfg file.

5 hours ago, coredumpster said:

Also, still seeing some additional odd behavior with Labs and Snacks! Soil Recyclers consuming some oddly huge and varying amounts of electricity.  ( Orbital Science Lab around Minmus with PXL 3 lab from SSPXR + 3 Level 2 scientists plus a few other hab components using bursts of > 70 ec/s.  Have 40k battery storage ).  I know you mentioned already that Science Lab power consumption is hard to calculate / model, so I'm doing some actual run tests to figure out consumption rates for my ships / stations, but if you have any pointers on how to help provide more data to improve the NFE models.  I build and tune my reactor outputs to handle what shows as the steady state ( trying to keep a low net positive ec/s flow), but there are odd spikes where my battery capacity plummets, but I have not made any changes to whats running ( in terms of recyclers, lab research, etc. ) or run a really high timewarp.

Well, for labs, they're just not even considered in the simulation/readout at the moment. It's an item to look into it, but not for a while...

In the case of Snacks!, it's important to figure out where the confusion is. It sounds callous, but I really only care about whether the amount of energy consumed by the snacks processor is reported correctly. The actual consumption of the module is kinda irrelevant to me :P.

Link to comment
Share on other sites

4 minutes ago, Nertea said:

Easy fix, it can actually be changed in the settings cfg file.

[ SNIP ]

Well, for labs, they're just not even considered in the simulation/readout at the moment. It's an item to look into it, but not for a while...

In the case of Snacks!, it's important to figure out where the confusion is. It sounds callous, but I really only care about whether the amount of energy consumed by the snacks processor is reported correctly. The actual consumption of the module is kinda irrelevant to me :P.

Ahh, was looking through the code on GitHub to see about generating a pull req.  Didn't think to check the CFG file!  Doh.

 

Doing a bit more poking on the rogue energy consumption.  Will try to narrow down an easy to reproduce example.

Some more detail, I'm seeing a swing in EC consumption of 73 EC/s by toggling the Snack Soil Recycler in the CTD-10 "Bagel" Centrifuge On/Off.  ( Max of 9.00 Soil / day ).  The Manager window predicts a 3 EC/s change.  Station has 3 Level 2 Scientists ( in a separate PXL-2 Deep Space Lab ).

Possibly there's more Snacks EC consumption for the recyclers than the 3 EC/s base.  Looking through the Snacks! calculators there's efficiency bonus that increase that ( along with increased resource output ).  Will keep poking at this.

Link to comment
Share on other sites

Can Unity UIs distinguish between left click button presses and right click button presses? I was thinking that it could be a potential QoL improvement if the Celestial Body selector button in the electrical panel could increment ++ with a left click and -- with a right click so that you don't have to cycle all the way through all the bodies if you accidentally pass the one you need.

Link to comment
Share on other sites

DBS 2.0.6

  • Rewrote ModuleCryoTank handler to account for misconfigured cryo Tanks
  • Improved error handling for unsupported handlers
  • Fixed a UI sorting collision with NFE reactor window
  • Added support for stock ModuleScienceConverter
  • Added support for RemoteTech (thanks TaxiService)

Please ensure you use the updated CryoTanks with this!

13 hours ago, Poodmund said:

Can Unity UIs distinguish between left click button presses and right click button presses? I was thinking that it could be a potential QoL improvement if the Celestial Body selector button in the electrical panel could increment ++ with a left click and -- with a right click so that you don't have to cycle all the way through all the bodies if you accidentally pass the one you need.

Yes it is, might be a nice improvement, you should make an issue :)

Edited by Nertea
Link to comment
Share on other sites

On 9/18/2019 at 11:41 PM, VoidSquid said:

Hey @Nertea, a big thanks for this mod, makes not only mine but the life of the little green people so much easier :) 

Just a brief question: I'm probably a bit dense, but I can't see fuel cells as EC generators in the Vessel Systems Management UI? How do I enable that? 

I just opened up the game and don't see any problems with this. Are you possibly using a mod that messes with them?

Link to comment
Share on other sites

6 hours ago, Nertea said:

Are you possibly using a mod that messes with them?

Not that I'm aware of, but:

After clean up and reinstalling the latest version manually instead of via CKAN , now it works as intended :) 

Thanks again :) 

 

6 hours ago, zer0Kerbal said:

5 will get you 10 it is ODFC.

Err... that's a bit too cryptic for old me, what do you mean by this?

Link to comment
Share on other sites

1 hour ago, VoidSquid said:

Not that I'm aware of, but:

After clean up and reinstalling the latest version manually instead of via CKAN , now it works as intended :) 

Thanks again :) 

 

Err... that's a bit too cryptic for old me, what do you mean by this?

thought it might have been On Demand Fuel Cells, a mod I curate. Glad the reinstall worked.

 

Link to comment
Share on other sites

  • 1 month later...

Version 2.1.0 released

  • KSP 1.8
  • Updated plugin to .NET 4.5
  • Add Russian localization (Sool3)
  • Improvements to solar panel... panel
    • Right clicking the target body in the solar panel simulator now decrements while left click increments
    • Target body selection will now set the maximum orbital height to be equal to the SOI size (will improve results with large scale solar systems)
Link to comment
Share on other sites

  • 2 weeks later...

Just installed this as I've been using external tools for this sort of thing, but I feel like I must be missing something - The slider for Body Orbital Height does not allow for accurate input: Far left is 1km, next value is 80km, next is 619Mm... A box into which a number could be typed would be great!

Link to comment
Share on other sites

Update 2.1.1

  • Fixed ModuleLight counting as a generator instead of a consumer
  • Fixed ModuleEngines electricity handling being divided by 100 in flight
  • Changed solar panel body altitude selection to be a text field instead of a slider
  • Solar panel body altitude is now liked to solar altitude if the selected body is the sun
Link to comment
Share on other sites

  • 2 weeks later...
On 11/25/2019 at 2:52 PM, OminousPenguin said:

Thanks @Nertea!

Any chance of backporting the latest updates for 1.7.3? I'm holding off updating to 1.8 because a few of my must-have mods are yet to be updated.

Sorry, API changes from 1.7 to 1.8 and different NET versions means this isn't trivial to do and I don't have the release pipeline to support it. 

Link to comment
Share on other sites

Good evening, 

I'm running into some kind of lag-problem when using a not stock version of the latest KSP. I'm here because I want to place a suspicion that it might be caused by your mod. Why do I claim this? Well... 

You mod came to my game as a dependency of Cryo Tanks (which somehow were requested by Kerbal Atomics). Well, nothing wrong with that. But as the rocket's size did grow, a strange lag was creeping inside the game. I remember from the past that rockets with many parts might be suspicious to lagging thanks to PhysicX fraud with every AMD processor out there. Still, the rocket in question did have way less than 100 parts. Its top might be a bit wobbly (a two part lander for the Mun) but even that is nothing I should be worried about. 

About half an hour ago, I made some observations that did speak against something that is solely caused by bad physics: the lag wont disappear if the craft gets smaller through staging (or at least not notable), and - that did turn the balance - it did happen even in Time (not Physics) Warp. That moment I remembered that there was some kind of... console (alt-f12) which jumped at me with the log window opened. And it was overflowing with error messages, all about a single topic: 

Quote

[LOG 20:37:58.783] [Dynamic Battery Storage]: [ModuleCryoTankPowerHandler]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName
[EXC 20:37:58.785] NullReferenceException: Object reference not set to an instance of an object
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselData..ctor (System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselElectricalData..ctor (System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselDataManager.RefreshVesselData () (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselDataManager.FixedUpdate () (at <0cebc2a272db4762979602ea2c4f144e>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

This gets repeated over and over (this is from the KSP.log file, and it grows so big thanks to that error that it acutally takes a notable period of time to open).

So, the rocket in question is... okay, I will simplify it a bit..., so that the log error will still be available. The rocket I want to use has the usually bunch of  stuff attached, which will make said error even worse. List of "important" parts at the affected spacecraft from top down 

Spoiler

Mk 1 command pod with one Kerbal inside

2x FL-TX900 Fuel Tank (filled with LH2/Ox for...)

CR-0120 "Erebus" Cryogenic Rocket Engine

TD-18 Decoupler

FL-A2155 Fuel Tank Adapter

2x KW Rocketry SB-2 LFT

RE-I5 "Skipper" Liquid Fuel Enigine

4x Globe X-2 SRB (attached to 1x hydraulic attachment manifold each)

I... did replace the "Erebus" and its two LH2/Ox Tanks with stock LF/Ox Tanks and engines, but it kept on logging that error...

that little part at the end gets repeated ad infinitum...

Spoiler

[LOG 20:47:04.967] [CustomBarnKit] Loading new upgrades prices
[LOG 20:47:05.015] [UiApp] Awake: EngineersReport
[LOG 20:47:05.015] [UiApp] Awake: Contracts
[LOG 20:47:05.015] [UiApp] Awake: KSPedia
[LOG 20:47:05.015] [UiApp] Awake: Missions App
[LOG 20:47:05.015] [UiApp] Awake: DeltaVApp
[LOG 20:47:05.015] [UiApp] Awake: ActionGroupsApp
[LOG 20:47:05.015] [ApplicationLauncher] OnSceneLoadedGUIReady: scene EDITOR ShouldBeVisible() True ShouldBeOnTop() False iIsPositionedAtTop True
[LOG 20:47:05.015] [ApplicationLauncher] SpawnSimpleLayout: HorizontalRightLeft
[LOG 20:47:05.021] ScaleModList: listSize 205 maxListSize 1535
[LOG 20:47:05.023] ScaleModList: listSize 246 maxListSize 1526
[LOG 20:47:05.025] ScaleModList: listSize 287 maxListSize 1526
[LOG 20:47:05.027] ScaleModList: listSize 328 maxListSize 1526
[LOG 20:47:05.029] ScaleModList: listSize 369 maxListSize 1526
[LOG 20:47:05.031] ScaleModList: listSize 328 maxListSize 1526
[LOG 20:47:05.031] FF: using stock toolbar button
[LOG 20:47:06.756] ScaleModList: listSize 369 maxListSize 1526
[LOG 20:47:06.756] [MessageSystem] Reposition 0.02 75719
[LOG 20:47:06.756] [GenericAppFrame] Reposition 0.02 75719
[LOG 20:47:06.756] [GenericAppFrame] Reposition 0.02 75719
[WRN 20:47:06.765] UIList: RemoveItem didn't find any item to remove.
[WRN 20:47:06.765] UIList: RemoveItem didn't find any item to remove.
[WRN 20:47:06.765] UIList: RemoveItem didn't find any item to remove.
[WRN 20:47:06.765] UIList: RemoveItem didn't find any item to remove.
[WRN 20:47:06.765] UIList: RemoveItem didn't find any item to remove.
[WRN 20:47:06.765] UIList: RemoveItem didn't find any item to remove.
[WRN 20:47:06.766] UIList: RemoveItem didn't find any item to remove.
[LOG 20:47:06.924] [UIApp] Adding ActionGroupsApp to Application Launcher
[LOG 20:47:06.926] ScaleModList: listSize 369 maxListSize 1485
[LOG 20:47:06.926] [ApplicationLauncher] SetHidden: 
[LOG 20:47:06.928] ScaleModList: listSize 369 maxListSize 1526
[LOG 20:47:06.928] [UIApp] Adding Missions App to Application Launcher
[LOG 20:47:06.931] ScaleModList: listSize 369 maxListSize 1485
[LOG 20:47:06.931] [UIApp] Adding Contracts to Application Launcher
[LOG 20:47:06.933] ScaleModList: listSize 369 maxListSize 1444
[LOG 20:47:06.933] [UIApp] Adding EngineersReport to Application Launcher
[LOG 20:47:06.936] ScaleModList: listSize 369 maxListSize 1403
[LOG 20:47:06.955] [ActionGroupsApp] OnAppStarted(): id: -2146846
[LOG 20:47:06.955] [GenericAppFrame] Reposition 0.2376619 75725
[LOG 20:47:06.956] [UIApp] Adding DeltaVApp to Application Launcher
[LOG 20:47:06.959] ScaleModList: listSize 369 maxListSize 1362
[LOG 20:47:06.959] [MissionsApp] OnAppStarted(): id: -2146834
[LOG 20:47:06.959] MissionsApp does not execute in this game mode, destroying this instance
[LOG 20:47:06.959] [UIApp] OnDestroy: Missions App
[LOG 20:47:06.959] ScaleModList: listSize 369 maxListSize 1362
[LOG 20:47:06.960] [GenericAppFrame] Reposition 0.2376619 75725
[LOG 20:47:06.973] [GenericAppFrame] Reposition 0.2376619 75725
[LOG 20:47:07.301] -INFO- Tac.EngineersReportLifeSupportTests[FFE00B8C][1236.69]: OnGUIEngineersReportReady
[LOG 20:47:07.301] -INFO- Tac.CheckSupplies[6B578322][1236.69]: constructor
[LOG 20:47:07.341] [GenericAppFrame] Reposition 0.3576619 75726
[LOG 20:47:07.373] [UIApp] Adding KSPedia to Application Launcher
[LOG 20:47:07.376] ScaleModList: listSize 369 maxListSize 1362
[LOG 20:47:18.793] [Dynamic Battery Storage]: [ModuleCryoTankPowerHandler]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName
[ERR 20:47:18.794] Exception handling event onPartRemove in class EditorVesselDataManager:System.NullReferenceException: Object reference not set to an instance of an object
  at DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () [0x00008] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) [0x00009] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) [0x0008f] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) [0x001db] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselData..ctor (System.Collections.Generic.List`1[T] vesselParts) [0x0001e] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselElectricalData..ctor (System.Collections.Generic.List`1[T] vesselParts) [0x00000] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.InitializeEditorConstruct (ShipConstruct ship, System.Boolean forceReset) [0x0002a] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselPartRemoved (GameEvents+HostTargetAction`2[A,B] p) [0x0003c] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at EventData`1[T].Fire (T data) [0x000b0] in <9d71e4043e394d78a6cf9193ad011698>:0 

[EXC 20:47:18.795] NullReferenceException: Object reference not set to an instance of an object
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselData..ctor (System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselElectricalData..ctor (System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.EditorVesselDataManager.InitializeEditorConstruct (ShipConstruct ship, System.Boolean forceReset) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselPartRemoved (GameEvents+HostTargetAction`2[A,B] p) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    EventData`1[T].Fire (T data) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:LogException(Exception)
    EventData`1:Fire(HostTargetAction`2)
    Part:setParent(Part)
    EditorLogic:detachPart(Part)
    EditorLogic:<SetupFSM>b__191_21()
    KerbalFSM:RunEvent(KFSMEvent)
    KerbalFSM:updateFSM(KFSMUpdateMode)
    KerbalFSM:UpdateFSM()
    EditorLogic:Update()
[LOG 20:47:18.880] [Dynamic Battery Storage]: [ModuleCryoTankPowerHandler]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName
[ERR 20:47:18.881] Exception handling event onEditorShipModified in class EditorVesselDataManager:System.NullReferenceException: Object reference not set to an instance of an object
  at DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () [0x00008] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) [0x00009] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) [0x0008f] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) [0x001db] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselData..ctor (System.Collections.Generic.List`1[T] vesselParts) [0x0001e] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselElectricalData..ctor (System.Collections.Generic.List`1[T] vesselParts) [0x00000] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.InitializeEditorConstruct (ShipConstruct ship, System.Boolean forceReset) [0x0002a] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselModified (ShipConstruct ship) [0x00024] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at EventData`1[T].Fire (T data) [0x000b0] in <9d71e4043e394d78a6cf9193ad011698>:0 

[EXC 20:47:18.883] NullReferenceException: Object reference not set to an instance of an object
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselData..ctor (System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselElectricalData..ctor (System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.EditorVesselDataManager.InitializeEditorConstruct (ShipConstruct ship, System.Boolean forceReset) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselModified (ShipConstruct ship) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    EventData`1[T].Fire (T data) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:LogException(Exception)
    EventData`1:Fire(ShipConstruct)
    EditorLogic:SetBackup()
    EditorLogic:<SetupFSM>b__191_21()
    KerbalFSM:RunEvent(KFSMEvent)
    KerbalFSM:updateFSM(KFSMUpdateMode)
    KerbalFSM:UpdateFSM()
    EditorLogic:Update()
[LOG 20:47:18.885] [Dynamic Battery Storage]: [ModuleCryoTankPowerHandler]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName
[ERR 20:47:18.886] Exception handling event onEditorShipModified in class EditorVesselDataManager:System.NullReferenceException: Object reference not set to an instance of an object
  at DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () [0x00008] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) [0x00009] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) [0x0008f] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) [0x001db] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.InitializeEditorConstruct (ShipConstruct ship, System.Boolean forceReset) [0x00043] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselModified (ShipConstruct ship) [0x00024] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at EventData`1[T].Fire (T data) [0x000b0] in <9d71e4043e394d78a6cf9193ad011698>:0 

[EXC 20:47:18.887] NullReferenceException: Object reference not set to an instance of an object
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.EditorVesselDataManager.InitializeEditorConstruct (ShipConstruct ship, System.Boolean forceReset) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselModified (ShipConstruct ship) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    EventData`1[T].Fire (T data) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:LogException(Exception)
    EventData`1:Fire(ShipConstruct)
    EditorLogic:SetBackup()
    EditorLogic:<SetupFSM>b__191_21()
    KerbalFSM:RunEvent(KFSMEvent)
    KerbalFSM:updateFSM(KFSMUpdateMode)
    KerbalFSM:UpdateFSM()
    EditorLogic:Update()
[LOG 20:47:18.890] [Dynamic Battery Storage]: [ModuleCryoTankPowerHandler]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName
[ERR 20:47:18.890] Exception handling event onEditorShipModified in class EditorVesselDataManager:System.NullReferenceException: Object reference not set to an instance of an object
  at DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () [0x00008] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) [0x00009] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) [0x0008f] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) [0x001db] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.InitializeEditorConstruct (ShipConstruct ship, System.Boolean forceReset) [0x00043] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselModified (ShipConstruct ship) [0x00024] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at EventData`1[T].Fire (T data) [0x000b0] in <9d71e4043e394d78a6cf9193ad011698>:0 

[EXC 20:47:18.891] NullReferenceException: Object reference not set to an instance of an object
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.EditorVesselDataManager.InitializeEditorConstruct (ShipConstruct ship, System.Boolean forceReset) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselModified (ShipConstruct ship) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    EventData`1[T].Fire (T data) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:LogException(Exception)
    EventData`1:Fire(ShipConstruct)
    EditorLogic:SetBackup()
    EditorLogic:<SetupFSM>b__191_21()
    KerbalFSM:RunEvent(KFSMEvent)
    KerbalFSM:updateFSM(KFSMUpdateMode)
    KerbalFSM:UpdateFSM()
    EditorLogic:Update()
[LOG 20:47:18.894] [Dynamic Battery Storage]: [ModuleCryoTankPowerHandler]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName
[ERR 20:47:18.895] Exception handling event onEditorShipModified in class EditorVesselDataManager:System.NullReferenceException: Object reference not set to an instance of an object
  at DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () [0x00008] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) [0x00009] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) [0x0008f] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) [0x001db] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.InitializeEditorConstruct (ShipConstruct ship, System.Boolean forceReset) [0x00043] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselModified (ShipConstruct ship) [0x00024] in <0cebc2a272db4762979602ea2c4f144e>:0 
  at EventData`1[T].Fire (T data) [0x000b0] in <9d71e4043e394d78a6cf9193ad011698>:0 

[EXC 20:47:18.897] NullReferenceException: Object reference not set to an instance of an object
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.GetFuelTypes () (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.ModuleCryoTankPowerHandler.Initialize (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselElectricalData.SetupDataHandler (PartModule pm) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.VesselData.RefreshData (System.Boolean fromScratch, System.Collections.Generic.List`1[T] vesselParts) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.EditorVesselDataManager.InitializeEditorConstruct (ShipConstruct ship, System.Boolean forceReset) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    DynamicBatteryStorage.EditorVesselDataManager.onEditorVesselModified (ShipConstruct ship) (at <0cebc2a272db4762979602ea2c4f144e>:0)
    EventData`1[T].Fire (T data) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:LogException(Exception)
    EventData`1:Fire(ShipConstruct)
    EditorLogic:SetBackup()
    EditorLogic:<SetupFSM>b__191_21()
    KerbalFSM:RunEvent(KFSMEvent)
    KerbalFSM:updateFSM(KFSMUpdateMode)
    KerbalFSM:UpdateFSM()
    EditorLogic:Update()
[LOG 20:47:20.787] deleting part fuelTankSmall and all children
[LOG 20:47:24.004] [ModuleCryoTank]: Reloading ConfigNodes for KW1mtankL4
[LOG 20:47:24.007] [ModuleCryoTank]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName
[LOG 20:47:24.007] [ModuleCryoTank]: Reloading ConfigNodes for KW1mtankL4
[LOG 20:47:24.009] [ModuleCryoTank]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName
[LOG 20:47:24.010] [ModuleCryoTank]: Reloading ConfigNodes for KW1mtankL4
[LOG 20:47:24.012] [ModuleCryoTank]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName
[LOG 20:47:24.012] [ModuleCryoTank]: Reloading ConfigNodes for KW1mtankL4
[LOG 20:47:24.014] [ModuleCryoTank]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName
[LOG 20:47:24.015] [PartSet]: Failed to add Resource -1483389306 to Simulation PartSet:2606 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.015] [PartSet]: Failed to add Resource -1483389306 to Simulation PartSet:2606 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.015] [PartSet]: Failed to add Resource -1483389306 to Simulation PartSet:2392 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.015] [PartSet]: Failed to add Resource -1483389306 to Simulation PartSet:2392 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.016] [PartSet]: Failed to add Resource -1483389306 to Simulation PartSet:1756 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.016] [PartSet]: Failed to add Resource -1483389306 to Simulation PartSet:1756 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.016] [PartSet]: Failed to add Resource -1154601244 to Simulation PartSet:2606 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.016] [PartSet]: Failed to add Resource -1154601244 to Simulation PartSet:2606 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.016] [PartSet]: Failed to add Resource -1154601244 to Simulation PartSet:2392 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.016] [PartSet]: Failed to add Resource -1154601244 to Simulation PartSet:2392 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.017] [PartSet]: Failed to add Resource -1154601244 to Simulation PartSet:1756 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.017] [PartSet]: Failed to add Resource -1154601244 to Simulation PartSet:1756 as corresponding Part KW Rocketry SA-4 LFT-2652517022 SimulationResource was not found.
[LOG 20:47:24.017] [Part KW1mtankL4] [ModuleB9PartSwitch 'KSPIE'] Switched subtype to LF/O
[EXC 20:47:24.037] NullReferenceException: Object reference not set to an instance of an object
    SimpleBoiloff.ModuleCryoTank.Update () (at <249ca1d9eb3c4f67a8d3a27f87ab9164>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)
[EXC 20:47:24.038] NullReferenceException: Object reference not set to an instance of an object
    SimpleBoiloff.ModuleCryoTank.Update () (at <249ca1d9eb3c4f67a8d3a27f87ab9164>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

 

And finally, my List of Mods 

Spoiler

KSP: 1.8.1 (Win64) - Unity: 2019.2.2f1 - OS: Windows 7  (6.1.0) 64bit
ClickThroughBlocker - 0.1.9.4
USI Tools - 1.3
ToolbarControl - 0.1.9.4
B9 Part Switch - 2.12.1
BD Animation Modules - 0.6.5.8
Better Science Labs Continued - 0.2
Chatterer Extended - 0.6.2
Chatterer - 0.9.98.2686
CommNetAntennasExtension - 2.1
CommNetAntennasInfo - 2.2
Community Category Kit - 5.0
Community Resource Pack - 1.3
CommunityTechTree - 3.4
Contract Configurator - 1.28
Contract Pack: Field Research - 1.2.1
Contract Pack: Bases and Stations - 3.7.1.5
Contract Pack: Tourism Plus - 1.5.2
CryoEngines - 1.1
CryoTanks - 1.4
CustomBarnKit - 1.1.20
DeployableBattery - 0.2.0.7
DeployableEngines - 1.2
DMagic Orbital Science - 1.4.3
DynamicBatteryStorage - 2.1.1
ExperimentTracker - 1.3.5
Firespitter - 7.14
HeatControl - 0.5
HideEmptyTechTreeNodes - 1.1.2
HullcamVDSContinued - 0.2
Interstellar Fuel Switch - 3.13.0.5
JanitorsCloset - 0.3.7
Community Resource Pack - 1.1
KAS - 1.5.7239.36651
KerbalAtomics - 1.1.1
Kerbal Inventory System - 1.23.7234.41726
KSP-AVC Plugin - 1.4.0.3
Kurrikane - 1.1.1
KWRocketryRebalanced - 3.2.7
NearFutureConstruction - 1.2.1
NearFutureElectrical - 1.1
NearFutureLaunchVehicles - 1.3
NearFutureProps - 0.6.1
NearFuturePropulsion - 1.2
NearFutureSolar - 1.1
NearFutureSpacecraft - 1.3
Final Frontier - 1.7.0.3466
NSS-OctoSat - 0.1.13.4
Photon Sailor - 1.5.0.5
RealChute - 1.4.7.5
RemoteTechRedevAntennas - 0.1.1
AmpYear - 1.5.6
IONRCS - 0.1.10
ResearchBodies - 1.11
SCANsat - 1.1.8.14
Science Relay - 1.0.6
SETI-Contracts - 1.2.2
SETI-ProbeParts - 1.3.0.1
SETI-Rebalance - 1.3.0.1
Simple Adjustable Fairings - Plugin - 1.6
KSP_ColorPicker - 0.1.0.1
KSP_Log - 0.1.0.1
PartHighlighter - 0.1.0.1
SpaceTuxLibrary - 0.0.2.3
Spacetux - 0.3.12.4
StationPartsExpansionRedux - 1.3.1
Surface Mounted Lights - 1.15.7274.38376
TarsierSpaceTechnology - 7.9
TAC Life Support - 0.14
Tracking Station Evolved - 1.0.5
TweakScale - 2.4.3.10
Konstruction - 1.3
Sounding Rockets - 1.3
EVAParachutesAndEjectionSeats - 0.2.0.2
KSP Interstellar Extended - 1.25.0.5
Waypoint Manager - 2.8.1

 

Okay... one test pending: I used CKAN to remove your mod (and everything, that does depend on it) and started a sandbox, where I tried to recreate my rocket as close to the one I reported above. Actually... I can recreate that rocket 1:1, because in that case just the engines came from a "lost mod". 

And... well, no Log-Spam any more (I can read interesting things inside the log Oo now), and the start, ascent and timewarp of that rocket is smoooooth as f....   Maybe the lag does come from all the other stuff flying around in background? Some of these vessels do have a  cryogenic engine too. And with my test rocket lagging even if not having such an engine... oh dear. 

Its a bit sad... because I grew kind of fond to the cryogenic engines (Mun lander return vessel with TWR of about 7.0 ^^) I got all these dependencies and patches from CKAN and now something unexpected causes such a game braking lag in my case :( I cannot  continue to play without these mods, because next to everything in my space program does already contain parts from one or another dependency...  So I have to wait for a fix, I guess.

Link to comment
Share on other sites

@Merlin4711: Some other mod is breaking my mod. This bit is relevant:

[LOG 20:37:58.783] [Dynamic Battery Storage]: [ModuleCryoTankPowerHandler]: Critical configuration error: Multiple ModuleCryoTank nodes found with identical or no moduleName

Something is breaking CryoTanks, which has very negative consequences (not just for this mod). 

Please upload a full log file and the Module Manager cache file (ModuleManager.ConfigCache from your GameData directory) so I can figure it out and yell at whoever did it. 

KSPI-E/IFS used to break things, but I thought that had been fixed on their end. I'll have a quick browse of that mod to see if that's still the case. 

Edit- yes it is still KSPIE. It still has bad configs in its directory. I would still like those two files from you but I have notified the author here: 

 

Edited by Nertea
Link to comment
Share on other sites

I'm on it...

First things first, IFS - while being part of my mod list - is just with its core lib mod present according to CKAN. Which feels strange... I will add the "real" one using CKAN and see, if it changes something. 

Beside this, I will go for that kind of event-chain:

  • adding all mods I removed yesterday for testing (cryo engines and kerbal atomics) which depend on your mod over two edges
  • Loading my save
  • going to the VAB
  • going for launch (which will trigger the endless rain of messages)
  • revert flight to VAB
  • leave VAB
  • close KSP

aaaand.... the wall-o-log is gone.  Okaaay... Camera movement at the launchpad is okay... I'll close KSP now, grabbing both files and zip them away somewhere. And... no "upload file" button, so I'll stuff them in that underused google drive of mine: ksp.log and ModuleManager.configCache

 

Okay, second test: I'll remove the IFS "real" mod and leave just that core thing inside (using CKAN)... and waiting for KSP to start (always takes eons...)

Event chain will be the same

aaaaand... the wall-o-log is back again. Camera Movement at the launch pad is laggy. Here we go: ksp.log and ModuldeManager.configCache 

Thats interesting. You know, I CAN actually use that fuel switch functionality in the VAB just having the core mod installed, which... well, what does this mean? is the IFS Core Mod already enough to power it this way, or does some other mod has a bundled and outdated version of the (non core) IFS inside? Anyway... if will insert the (non core) IFS again and give it a go. So does this mean that the only problem is currently that the (non core) IFS does not get installed by CKAN

Greetings, Merlin4711

 

EDiT: Aaaand... adding the non-core IFS removed the liquid hydrogen / oxidizer combination from my tanks. Of course, in best KSP playing style, I only noted this when I was in a suborbital trajectory and began to wonder why my cry engines wont fire, just to find out that they now contain.... Ammonia. Back to the VAB I noted that the Fuel switch thingy did disappear completely, and all I can do is switch between LF, Ox and LF/Ox variants. Weeeeelll... that's an unfortunate development. But not topic of this thread any more. 

EDiT 2: Turns out most of the stock tanks (and these from KW rocketry) now, beside showing fuel switch capabilites in their info window (even containing LH2/Ox) cant do this any more. But if I dare to add a CryoTank (like the H125-4) the VAB will start to lag, because now here a bazillion exceptions are thrown around.... "NullReferenceException". Well, looks like I'm not going to space today. Or at least not with LH2/Ox... 

Edited by Merlin4711
New insight, part 2
Link to comment
Share on other sites

You should understand the relationship between KSPI-E and IFS:

  • IFS Core is just a dll, should do nothing.
  • IFS Full contains the bugged file.
  • KSPI-E contains IFS Full (and thus the incorrect file)

So whether or not you install IFS core or not, you still have KSPI-E in there, which will cause the problems. 

Regardless, I have made FreeThinker aware of the problem, so hopefully it will be fixed in the next IFS/KSPIE release. 

Link to comment
Share on other sites

  • 2 weeks later...
On 12/27/2019 at 9:44 PM, VoidSquid said:

Hi there, @Nertea, and thanks again for this mod, quite helpful when planning missions. :)

I have a question though, I couldn't find any of the stock resource scanner, not any of the ScanSat modules as EC consumers, what am I doing wrong here?

Nothing. Neither of those two modules are supported at the moment.

Link to comment
Share on other sites

This thread is quite old. Please consider starting a new thread rather than reviving this one.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...