taniwha

[1.3.1] Modular Fuel Tanks v5.10.0

Recommended Posts

I get that too. Don't know if it's linked to the issue I reported. 

Share this post


Link to post
Share on other sites

@Flow: thanks, I'll look into it.

@Gordon Dry: Already fixed locally as I noticed it in flow's logs.

flow: I doubt they're related, though it is possible.

Share this post


Link to post
Share on other sites

@Flow: I have reproduced the problem even with my fix for the app launcher. I'll see what I can do.

Share this post


Link to post
Share on other sites

@taniwhaThank you for looking into it. I appreciate your work. 

Edited by Flow

Share this post


Link to post
Share on other sites

I have released MFT version 5.9.1, fixing the error reported by @Flow. Many thanks.

Share this post


Link to post
Share on other sites

It turns out I broke things in 5.9.1, but nothing /too/ serious: MFT tanks start out with no resources at all, but once filled, they work. Until I get it fixed (hopefully soon), you can use the auto-fill buttons in the PAW (right-click menu).

Edited by taniwha

Share this post


Link to post
Share on other sites

I found the cause of that particular bug and things seem to be ok now, just doing a little more testing before doing another release.

Share this post


Link to post
Share on other sites

I think i mentioned something similar to this a while back but Nertea's Cryo engines call for a "cryogenic" tank that isn't define by MTF, 

He said he doesn't maintain the patch for mtf, so i didn't think mentioning it here would hurt, If i knew how to modify them i wouldn't have issues doing it but i'm not code literate at the this time.

Edited by Grease1991

Share this post


Link to post
Share on other sites

MFT never really understood "cryogenic", only RF did (and does). Some tanks were mistakenly marked as cryogenic in earlier versions, but that was fixed a while back (KSP 0.23.5).

Share this post


Link to post
Share on other sites

Is this TAC-LS issue because of a quirk with MFT? I'm not sure where to look:

Edit:

it seems that TAC-LS itself does this with GameData\ThunderAerospace\TacLifeSupportMFT\MM_AddResourcesMFT.cfg

actually I'm trying to create a patch for MFT

Edit:

I need help, I have problems with the recursion variable stuff in my try to create that patch:
GameData\ModularFuelTanks\TAC_LS_modularFuelTanks.cfg

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:BEFORE[zzz_modularFuelTanks]
{
	!MODULE[ModuleFuelTanks] { }
	!TANK_DEFINITION[Default] { }
}

@PART[*]:HAS[!MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:FOR[zzz_modularFuelTanks]
{
	MODULE
	{
		name = ModuleFuelTanks
		volume = 3.549
		@volume *= #$/CrewCapacity$
		type = Default
//		typeAvailable = LifeSupportAll
	}
	TANK_DEFINITION {
		name = Default
		basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[MonoPropellant]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = MonoPropellant
		amount = 0
		@amount = #$../RESOURCE[MonoPropellant]/amount$
		maxamount = 0
		@maxamount = #$../RESOURCE[MonoPropellant]/maxAmount$
		note = Also MonoPropellant is needed to survive
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[ElectricCharge]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = ElectricCharge
		amount = 0
		@amount = #$../RESOURCE[ElectricCharge]/amount$
		maxamount = 0
		@maxamount = #$../RESOURCE[ElectricCharge]/maxAmount$
		note = Also ElectricCharge is needed to survive
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[Food]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = Food
		amount = 0
		@amount = #$../RESOURCE[Food]/amount$
		maxamount = 0
		@maxamount = #$../RESOURCE[Food]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[Water]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = Water
		amount = 0
		@amount = #$../RESOURCE[Water]/amount$
		maxamount = 0
		@maxamount = #$../RESOURCE[Water]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[Oxygen]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = Oxygen
		amount = 0
		@amount = #$../RESOURCE[Oxygen]/amount$
		maxamount = 0
		@maxamount = #$../RESOURCE[Oxygen]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[CarbonDioxide]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = CarbonDioxide
		amount = 0
		maxamount = 0
		@maxamount = #$../RESOURCE[CarbonDioxide]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[Waste]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = Waste
		amount = 0
		maxamount = 0
		@maxamount = #$../RESOURCE[Waste]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

@PART[*]:HAS[MODULE[ModuleFuelTanks],@MODULE[ModuleCommand],#CrewCapacity[>0],~RSSROConfig[]]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]:AFTER[zzz_modularFuelTanks]
{
	@MODULE[ModuleFuelTanks]
	{
		@volume += #$/RESOURCE[WasteWater]/maxAmount$
	}
}

@TANK_DEFINITION[Default]:NEEDS[modularFuelTanks|!RealFuels,TacLifeSupport]
{
	@basemass = 0.0003125 * #$/MODULE[ModuleFuelTanks]/volume$
	TANK {
		name = WasteWater
		amount = 0
		maxamount = 0
		@maxamount = #$../RESOURCE[WasteWater]/maxAmount$
		note = (TAC Life Support Mod Required)
	}
}

// If tank volume is still zero than non of the above resources where present and we delete ModuleFuelTanks
@PART[*]:HAS[@MODULE[ModuleFuelTanks]:HAS[#volume[0]]]:FINAL
{
	!MODULE[ModuleFuelTanks] {}
	!TANK_DEFINITION[*] { }
}

It's the variants of
amount = #$../RESOURCE[MonoPropellant]/amount$
maxamount = #$../RESOURCE[MonoPropellant]/maxAmount$

I tried

  • without ../
  • with ../
  • with ../../
  • with ../../../

I'm lost now.

Edited by Gordon Dry

Share this post


Link to post
Share on other sites

It seems like Ven's Stock Revamp breaks this a bit, I don't know enough to know how to fix it. Thank you if anyone can help.

Share this post


Link to post
Share on other sites

Well, it would help if you expanded on "breaks this a bit". Saying such is about as useful as saying that putting a silly expression on your faces "fixes it a bit".

Share this post


Link to post
Share on other sites

Hi!

Does this version work with 1.3.1? :) And do you know when it will get updated on CKAN?

Cheers!

Share this post


Link to post
Share on other sites
On 11/6/2017 at 4:41 PM, Kynrael said:

Hi!

Does this version work with 1.3.1? :) And do you know when it will get updated on CKAN?

Cheers!

It works on 1.3.1

Share this post


Link to post
Share on other sites

Yeah, just an NRE on editor startup (mostly harmless: just the MFT filter doesn't work). Plan on doing an update soon.

Share this post


Link to post
Share on other sites

Apparently reading is hard. just read up a bit and found my answer. I'll sit over here and wait....

 

Edited by AngrybobH

Share this post


Link to post
Share on other sites

3 MM errors. related to MFTX_ModularFuelTanks.cfg

 

Spoiler

[ERR 00:06:48.878] [ModuleManager] Error - more than one pass specifier on a node: MunarIndustries/MFTX_ModularFuelTanks/@PART[MI*]:FOR[MunarIndustries]:HAS[@RESOURCE[LiquidFuel],@RESOURCE[Oxidizer],!MODULE[ModuleFuelTanks]]:AFTER[ModularFuelTanks]
 

my bad, this was meant for Fuel Tank Expansion Rebuilt

Edited by Jesusthebird
durp

Share this post


Link to post
Share on other sites

I am getting an Incompatible Mods Detected for ModularFuelTanks v5.9.1 on KSP startup. Is v5.9.0 still available to see if that fixes my issue?

Share this post


Link to post
Share on other sites

However, it is just a message to not be surprised if there are problems, not a guarantee that there will be problems. There is one problem, mostly harmless, in that the editor filter doesn't get setup correctly. I have it fixed locally but have not had the time to do a release.

This means that despite the warning (and the NRE on entry to the editor), MFT 5.9.1 does work in 1.3.1.

Share this post


Link to post
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now