Jump to content

[1.8-1.9] Modular Fuel Tanks v5.13.1


Recommended Posts

I don't fully understand your syntax yet in TankTypes.cfg (e.g. "basemass = 0.000625 * volume" seems to be a general definition which is sometimes overwritten by "mass = 0.000625", sometimes not?), what I did so far was creating some config files for other non-stock LfOx / Lf tanks. If you could give me a bit background know how, I could also do other tank types like structural.

Also: how do you measure the dimensions of parts? There's no tape measure in the VAB.

 

Link to post
Share on other sites

Python... been a while, some 30 years actually... so if I understand your script correctly, you're enumerating and parsing all GameDate\..\.cfg files through that script which then creates its own MFT .cfg files according to the content of the parts .cfg files it finds?

Link to post
Share on other sites

It parses all of GameData cfg files for resource definitions (to get density and thus resource mass, but tnat's not actually used, probably why I never noticed the hard-coded KSP version), after that, it goes through all the part cfg files in the trees specified on the command line. But yeah, it then generates MM patches sent to stdout.

Link to post
Share on other sites

The few MFT cfg files I did, I just opened the respective tank cfg in a text editor, copied a similar MFT cfg, and changed the values accordingly.

What I don't understand atm:

For any given tank, regardless of content, we do have the volume and dry mass. With MFT, it can be filled with any content, and we know the volume as well as density of the different propellants. Why are lines like

        basemass = volume * 0.000625

needed at all?

Then we have of course the second category, parts like nose cones, that do not contain any fuel per se, for those we have the mass but no volume, that has to be calculated manually and then added to a MFT cfg file.

What do I miss here?

Edited by VoidSquid
Link to post
Share on other sites

Because MFT sets the tank mass, potentially per-resource (Real Fuels is just MFT with some extra stuff like ulage and boiloff). I'd have to go through the code again. If you do the math, you'll find that the basemass is the part's dry mass.

TBH, I don't particularly like the system, but ialdabaoth and maybe NathanKell did it up before I got involved so we're stuck with it, though there might be a way to tell MFT to just leave the tank mass alone (if not, maybe I should add one).

Link to post
Share on other sites

I see, things like ReafFuel or RSS do change my simplistic approach, naturally. Never used those mods, the few MFT cfgs I made, I made just for my own needs, stock game plus part mods like MRS or RLA.

Edited by VoidSquid
Link to post
Share on other sites

Ok then, how can I help? Making config files the way I described is a no-brainer. Adding lines according to the RF requirements should be easy too if I know what's required. My personal biggest obstacle are parts not having any fuel in them per se, nose cones etc., as I said: how do I get the exact dimensions to calculate the available volume?

Link to post
Share on other sites

Which lines are required then? Example of a cfg I made for a LfOx mod tank:

Spoiler

@PART[tanknamehere] {
    MODULE {
        name = ModuleFuelTanks
        volume = 12345
        type = Default
    }
}

That's a simple copy and paste from one of the MFT cfg files which comes with MFT.

For tanks in Squad_modularFuelTanks.cfg, some do have lines for basemass= volume * <factor>, some don't, e.g.

Spoiler

@PART[rcsTankMini] {
    MODULE {
        name = ModuleFuelTanks
        volume = 20
        type = RCS
        basemass = volume * 0.001
    }

}

@PART[RCSFuelTank] {
    MODULE {
        name = ModuleFuelTanks
        volume = 120
        type = RCS
    }

}
 

Why is that?

Even for the same fuel type, if present, <factor> in lines

basemass = volume * <factor> 

varies greatly.

I find that confusing, tbh, this is the reason I only made a a few cfg files for some LfOx tanks from various part mods, for my own needs.

Edited by VoidSquid
Link to post
Share on other sites
  • 2 weeks later...

@VoidSquid

basemass is already defined in the TANK_DEFINITION so it's not necessary to define it on a per part basis UNLESS you want to override the default definition.

For the part you inquired about, it was probably done to match the stock behavior for that part. (the default configuration matches typical stock behavior for the tank of that type)

Link to post
Share on other sites
  • 3 weeks later...

Is there a rough ETA on the update for modular fueltanks?

Please do not take this as me being pushy, if you think it's gonna be a year or never, or you just can't say or don't feel like answering, that's cool :)

I just have the itch to play some KSP again and I don't wanna drop the mod and then it updates tomorrow or something like that :D

Link to post
Share on other sites
  • 2 weeks later...

I have a local patched copy of this that works fine. The maintainer is working on it and will release a new version, presumably as soon as he can find the time. It was already close. This mod needed almost no changes.

(If you really want to and have the skill you could build my modified version: https://github.com/NathanKell/ModularFuelSystem/pull/236 )

 

Edited by ArthurP
Link to post
Share on other sites
  • 5 weeks later...

Hey there,

I have to ask a simple question. I'm using TAC life support for several years and now stumbled across this mod. It's fantastic to choose which type of fuel I want to use!
Sadly there are some issus with the use of TAC. I know these issues are known and so I simply want to aks if there is a actual workaround for using both mods together.

When using MFT most parts of TAC are no longer shown and available in the parts list. Only few parts are left over. Curios: This happens only in career mode. In Sandbox all parts are still shown. When deleting MFT all parts are available again. Happens in 1.7.3 as now in 1.8.1 too. Is there a solution for this problem? This would be great!

Thanks in advance!

Edited by Aledude Kerman
Link to post
Share on other sites

@Starwaster thanks for your reply. Yes, the parts are definitely unlocked in R&D. As said, as soon as I remove MFT from my mods the parts appear again and also my R&D is completely researched. To verify the problem I started 2 new careers, unlocked the complete R&D and had a look in the parts list - in every save the same situation: Parts there but gone when MFT activated :(

Edit:
It affects not all TAC LS parts but most of the life support hexcans and containers; food, water, oxygen, waste. The recycling modules as well as the mixed resources hexcans/containers (containing food, water and oxygen at once) are not gone when MFT installed - this might be interesting. Happens weather mods are installed via CKAN or manually, no difference. Tested several times. Screenshots attached. Log attached. Can't help myself... Thanks! :)

mft_not_installed.jpgmft_installed.jpg

randd.jpg

Link to LOG

Edited by Aledude Kerman
edit
Link to post
Share on other sites

@Aledude Kerman As I thought, TACLS is hiding containers if it detects that MFT (OR RealFuels) are present. Looking at the repo, it looks like it should affect sandbox as well since it modifies the category as well as the tech requirement. Not sure why it would still show up in the sandbox. Can look into it further later, but it definitely seems to be intentional.

 

Link to post
Share on other sites
  • 4 weeks later...
On 2/24/2020 at 4:19 AM, dlrk said:

[delete]

Please don't do that. If you asked a question and later found the answer yourself, edit your post to include the answer. This way, others can see your question and answer. Sure, you might feel a little silly in the process, but you might be someone's hero.

Link to post
Share on other sites
This thread is quite old. Please consider starting a new thread rather than reviving this one.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...