FAR + Tweakscale(type "free") = Broken CoL

[O-Doc]

Hey, I've got an interesting issue with Far + Tweakscale.

I'm running a fresh v0.25 install of KSP and have the following added:

• ModuleManager v2.5.1
  
• FAR v0.14.3
  
• Tweakcale v1.44
  

So, everything's the latest and up to date.

When I use anything in Tweakscale free mode it totally borks the FAR aero. I hate to speculate, OK, I lied. I love speculating and I'm thinking that Tweakscale is messing up the AttachNode size in rescaleNode() through the isFreeScale logic gate in Scale.cs. Then, FAR is taking those Attach.size values on the rescaled parts prior to raycasting all check during AttachNodeCdAdjust() FARBasicDragModel.cs, but that might be me reading the code wrong.

The video shows the bug being fully reproducable. It doesn't only happen when you load the craft. It will also happen while you are editing the craft but it's hard to know what triggers the change in the aero. Loading the craft from save always creates the problem. Watch for that one frame glitch when the CoL seems to almost be in the right position then moves. Could the ordering of the Update() function between the two be an issue?

Another interesting "feature" is to load your craft onto the runway and using a data display mod, check out the vertical velocity relative to the horizontal. My craft was generating three times the negative vertical velocity as it had horizontal velocity. Even the gear suspension was groaning under the weight of a 7 ton craft.

Interested parties can grab the video and corresponding log file in my drop box(58MB). It would be a shame to have to choose between these two great mods...

[O-Doc]

I just want to add one more thing. This bug did not exist in an older version of FAR which I had installed a week ago.

[tobjv]

First things first. http://forum.kerbalspaceprogram.com/threads/92229-How-To-Get-Support-%28READ-FIRST%29

Operating system:

Ram:

Version of ksp you're using:

When you installed far did you do it from a clean slate as Ferram warns on his posts?

Did you try to replicate the bug without FAR installed?

Edit:Instead of double posting just make an edit of the original post and put it like this sentence is.

[O-Doc]

Sorry, Windows 32bit w/ 4gb RAM. Everything is a clean install in a fresh downloaded v0.25 of KSP. If you look at the time on the edit, it's useful to make a new post if devs are subbed to thread and you give new information.

[ferram4]

Unless Tweakscale specifically has code that calls FAR's recalculate geometry functions after it rescales things, it has never been auto-updating FAR's aerodynamic characteristics in the editor. The fix has to come on the Tweakscale side, because any attempt to do it on my side will make things even more computationally intense in the editor than they already are.

[NathanKell]

If geometry is preserved and only size increased, could just scaling S (or the wing/control surface equivalent) do the trick? TweakScale only scales uniformly.

EDIT: actually, only wings/control surfaces. You build the drag model after tweakscale scales, so non-wing parts actually work fine.

[ferram4]

It'll need to rebuild everything after the rescale, since that would be needed to rebuild all of the wing interaction data and a few of the other geometry things. If it doesn't do that, it will not behave the same. No way around it.

Oh, and it will probably have to send that message to every wing on the vehicle to make sure that their wing interaction data is updated as well.