NecroBones

[1.4.1] Fuel Tanks Plus 2.0.2 (2018-03-14)

Recommended Posts

1 hour ago, Krzeszny said:

I'm interested. While this mod has balance issues, game-crashing issues are much worse.

What balance issues?

Share this post


Link to post
Share on other sites
On 5/22/2020 at 6:49 PM, linuxgurugamer said:

Hi all,

I have a working patch for this to avoid the crash with radial tanks and IFS.  Anybody interested?

I also have it working with the B9 Part Switch mod for texture switching 

Just noticed this, would be very interesting to see

Share this post


Link to post
Share on other sites
1 minute ago, Cavscout74 said:

Just noticed this, would be very interesting to see

I'd like to know what the balance problems are, I should be able to fix those as well

Share this post


Link to post
Share on other sites
3 minutes ago, linuxgurugamer said:

I'd like to know what the balance problems are, I should be able to fix those as well

None that I was really aware of

Share this post


Link to post
Share on other sites

I'll probably check the volume and mass values against a spreadsheet I have to make them in line with stock tanks

Share this post


Link to post
Share on other sites
Posted (edited)
On 5/28/2020 at 11:06 PM, linuxgurugamer said:

What balance issues?

1. Oscar-size tanks hold slightly too much fuel. Compare them to ReStock+ which is known to be well-balanced. Also, as I mentioned, with RS+ the mods overlap quite a few tanks. Not only Oscars but also pancake-sized tanks of all sizes.

Remember - in KSP the tanks themselves weigh 10%, and the fuel weighs 90%. This may be different with donut, spherical, baguette etc. tanks. Cube tanks have struts or something, so they could be slightly worse than donuts etc.

2. Liquid Fuel-only tanks from FTP hold 200% of the fuel they should be holding with stock balance. They shouldn't hold more than what a stock tank would - not 2 times as much, as it is in FTP.

The reason is, as I mentioned in my previous post, because internal realism in KSP makes fuel for atomic engines "take up twice the space" as normal liquid fuel would. This is intentional. IRL, cryogenic fuel takes 10 times as much space. See - Space Shuttle's orange tank.

3. Yellow satellite tanks are overpowered (cubes and the 'triangular cube') (they couldn't realistically hold that much fuel for their sizes)

By the way, it's a shame FTP has color-coded tanks even without Color-Coded Canisters installed. But that's a minor thing.

Edited by Krzeszny

Share this post


Link to post
Share on other sites
On 5/31/2020 at 11:04 AM, Krzeszny said:

By the way, it's a shame FTP has color-coded tanks even without Color-Coded Canisters installed. But that's a minor thing.

How is this a thing?  Are you saying the color-coding shouldn't be there at all without ANOTHER mod providing it?

Share this post


Link to post
Share on other sites
Posted (edited)

@Krzeszny @TranceaddicT and anyone else who wants to use this mod in 1.9:

I've created a set of patches to fix the problems in the mod.

Problems include:

  • 3 parts had incorrect bulkheadProfiles
  • Radial tanks would crash KSP
  • Fuel amounts have been all adjusted

Note:  I haven't yet gotten around to updating the tank masses, that will be next, I'd like you all to try these out and let me know how it goes:

https://www.dropbox.com/s/g95k0ftylxalac0/FTP-Patches-v3.zip?dl=0

IMPORTANT INSTALLATION INSTRUCTIONS

# FuelTanksPlus


IMPORTANT - INSTALLATION INSTRUCTIONS

Some of the parts (see below) use some Squad textures.  Unfortunately, Squad has been deprecating textures over time, some of the textures it uses have been moved into the zDeprecated directory, and are not directly accessible during loading.  This causes some textures to be missing.

To address this, I've provided a pair of scripts, one to be used on Windows and the other to be used on both Linux & OSX.  These only need to be run one time

First, copy all the files in this Zip into the FuelTanksPlus directory

Windows Instructions
====================
Open the FuelTankPlus folder folder in Windows Explorer
Double-click on the file Windows_CopyTextures.bat (note that on most systems,
you won't see the .bat)


Linux & OSX Desktop Instructions
================================
Open the FuelTanksPlus folder 
Double-click on the file:  BashCopyTextures.sh


Linux & OSX Terminal Instructions
=================================
Change to the GameData/SXT directory
Type the following:
    bash BashCopyTextures.sh
    

Affected Parts
==============

TPcone2m
TPcone3m
TPdecoupler2m
TPdecoupler3m
TPdome2m
TPdome3m
TPtank1m0mA
TPtank2m1mA
TPtank2mL05625
TPtank2mL11250
TPtank2mL15000
TPtank3m2mA
TPtank3m2mA2
TPtank3mL00938
TPtank3mL05625
TPtank3mL11250
TPtank3mL15000

Edited by linuxgurugamer

Share this post


Link to post
Share on other sites

FYI, the fuelPatch.cfg file starts off with your template.

 

@PART[PartName]:BEFORE[FuelTanksPlus]
{
	@RESOURCE[LiquidFuel]
	{
		%amount = LiquidFuel
	}
	@RESOURCE[Oxidizer]
	{
		%amount = PartName,LiquidFuel,Oxidizer
	}
}

Imma just assume that wasn't meant to be used for some other part and delete it.

Share this post


Link to post
Share on other sites

Also, the fuelPatch.cfg doesn't have the patch ordering present.

@PART[TPcone1m1]:
{
	%bulkheadProfiles = size1
}

I'm gonna assume you mean BEFORE[FuelTanksPlus] as with the the other configs provided.

 

Share this post


Link to post
Share on other sites
3 hours ago, TranceaddicT said:

Also, the fuelPatch.cfg doesn't have the patch ordering present.


@PART[TPcone1m1]:
{
	%bulkheadProfiles = size1
}

I'm gonna assume you mean BEFORE[FuelTanksPlus] as with the the other configs provided.

 

Not needed for this patch,  it's generally a good idea to not add in things to code, configs, etc. which are meaningless and/or not needed

 

10 hours ago, TranceaddicT said:

FYI, the fuelPatch.cfg file starts off with your template.

 


@PART[PartName]:BEFORE[FuelTanksPlus]
{
	@RESOURCE[LiquidFuel]
	{
		%amount = LiquidFuel
	}
	@RESOURCE[Oxidizer]
	{
		%amount = PartName,LiquidFuel,Oxidizer
	}
}

Imma just assume that wasn't meant to be used for some other part and delete it.

Leftover, doesn't hurt to leave it, but I will delete it.

Share this post


Link to post
Share on other sites
16 hours ago, linuxgurugamer said:

Not needed for this patch,  it's generally a good idea to not add in things to code, configs, etc. which are meaningless and/or not needed

Okay, well, I did it because MM is throwing warnings because of it.

[WRN 21:10:43.585] 3 warnings related to GameData/FuelTanksPlus/FixBulkheadProfiles.cfg
 

Share this post


Link to post
Share on other sites
8 hours ago, TranceaddicT said:

[WRN 21:10:43.585] 3 warnings related to GameData/FuelTanksPlus/FixBulkheadProfiles.cfg

Like I said,doesn't hurt,they were warnings, but it obviously helps to remove warnings.

But, here is an updated version:

https://www.dropbox.com/s/iywr31dl69sg4ra/FTP-Patches-v2.zip?dl=0

Share this post


Link to post
Share on other sites
On 6/4/2020 at 6:50 PM, TranceaddicT said:

How is this a thing?  Are you saying the color-coding shouldn't be there at all without ANOTHER mod providing it?

FTP tanks are color-coded like in the mod Color Coded Canisters. If you install CCC, it adds color-coding to vanilla tanks. But without it installed, FTP tanks don't look very good because vanilla tanks aren't color-coded.

I assume that FTP props are color-coded because NecroBones always uses Color Coded Canisters and he forgot to remove it.

Share this post


Link to post
Share on other sites

I had a mistake in the previous set of patches, a script had some values transposed and the fuelPatch.cfg was nonsense.

This is a corrected version:

https://www.dropbox.com/s/g95k0ftylxalac0/FTP-Patches-v3.zip?dl=0

Please let me know how it goes.  I updated the original post with the new link

 

Share this post


Link to post
Share on other sites

Has anyone had success making this work with 1.10.X? I finally got some other mods I love that have updated to 1.10 and wanted to make that leap, but I have really come to love this mod and don't want to give up its functionality.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.