[1.8.x] Impact! - impact science and contracts -v1.8.0

[linuxgurugamer]

59 minutes ago, tomf said:

New release!

I've finally got round to fixing the things found by linuxgurugamer

So it works in GPP now?

[tomf]

58 minutes ago, linuxgurugamer said:

So it works in GPP now?

It ought to

[TheOrqwithVagrant]

I just crashed one of Dres's asteroids (class C) into Dres... and instead of generating an impact, it reached 'g-limits' and just 'popped' when it hit. Neither landed bangometers nor the orbiting flashometer registered anything. I was quite disappointed.

I strongly doubt this is Impact!'s fault - mostly putting this here as a 'warning' to others that their hard work to de-orbit an asteroid may not produce any useful data for this mod's science instruments.

[U-ru-Ru]

is it work correctly in 1.5.1?

[elbuglione]

1.6 news?

[theonegalen]

It's updated to 1.8 on GitHub now.

[tomf]

10 hours ago, theonegalen said:

It's updated to 1.8 on GitHub now.

Yup I have finally given up waiting for Kopernicus and recompiled for KSP 1.8.

A few minor code changes but nothing affecting functionality.

[Drew Kerman]

@tomf is this EXC an actual problem?

Spoiler

[EXC 02:24:56.112] MissingMethodException: Default constructor not found for type kerbal_impact.ImpactContract
    System.RuntimeType.CreateInstanceMono (System.Boolean nonPublic) (at <ad04dee02e7e4a85a1299c7ee81c79f6>:0)
    System.RuntimeType.CreateInstanceSlow (System.Boolean publicOnly, System.Boolean skipCheckThis, System.Boolean fillCache, System.Threading.StackCrawlMark& stackMark) (at <ad04dee02e7e4a85a1299c7ee81c79f6>:0)
    System.RuntimeType.CreateInstanceDefaultCtor (System.Boolean publicOnly, System.Boolean skipCheckThis, System.Boolean fillCache, System.Threading.StackCrawlMark& stackMark) (at <ad04dee02e7e4a85a1299c7ee81c79f6>:0)
    System.Activator.CreateInstance (System.Type type, System.Boolean nonPublic) (at <ad04dee02e7e4a85a1299c7ee81c79f6>:0)
    System.Activator.CreateInstance (System.Type type) (at <ad04dee02e7e4a85a1299c7ee81c79f6>:0)
    Contracts.Contract.Generate (System.Type contractType, Contracts.Contract+ContractPrestige difficulty, System.Int32 seed, Contracts.Contract+State state) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    Contracts.ContractSystem.GenerateContract (System.Int32 seed, Contracts.Contract+ContractPrestige difficulty, System.Type contractType) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    Contracts.ContractSystem.GenerateContract (System.Int32& seed, Contracts.Contract+ContractPrestige difficulty) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    Contracts.ContractSystem.GenerateContracts (System.Int32& seed, Contracts.Contract+ContractPrestige difficulty, System.Int32 count) (at <9d71e4043e394d78a6cf9193ad011698>:0)
    Contracts.ContractSystem.RefreshContracts () (at <9d71e4043e394d78a6cf9193ad011698>:0)
    Contracts.ContractSystem+<UpdateDaemon>d__47.MoveNext () (at <9d71e4043e394d78a6cf9193ad011698>:0)
    UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) (at <5aeafee3fea24f37abd1315553f2cfa6>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:CallOverridenDebugHandler(Exception, Object)

KSP Log.

[Stone Blue]

On 2/23/2020 at 2:41 AM, Drew Kerman said:

@tomf is this EXC an actual problem?

It appears so...

 

[1332020]

great i love it
but the parts ugly XD