Jump to content

[1.12.x] GravityTurn continued - Automated Efficient Launches


linuxgurugamer

Recommended Posts

On 11/8/2022 at 7:54 PM, Albedo039 said:

@linuxgurugamer

Returning to KSP after several years, and for the first time playing with the DLC, I have discovered that Engine Plates and GravityTurn do not want to play nice. Specifically, other than the initial stage, any stage below an Engine Plate will fail to Auto Stage. Additionally (and this may be expected behaviour), if such a stage is not triggered manually, subsequent stages also fail to Auto Stage in their turn.

Replacing Engine Plates with decouplers fixes all staging issues on test craft.

Craft file (a stripped-down version of the craft that led to the discovery):
https://pastebin.com/pwGKdLrr

Log file, in two parts:
https://pastebin.com/NingbDVB
https://pastebin.com/nFpVfCUD

Relevant actions performed:
Launch craft w/GravityTurn; observe side boosters fail to separate when empty; wait; observe core booster fail to separate when empty; wait; manually perform one staging; observe both stagings happen at once.

Your staging is wrong, you have three different decouplers in the same stage

Once I fixed that, I see the problem in your rocket.  The issue seems to be that the tanks on the side are also engines, with fuel in them, the fuel in them is what's confusing GT.  Doesn't matter it's solid rather than liquid.  Not sure if this can be fixed, but I'll take a look

Link to comment
Share on other sites

On 12/19/2022 at 1:46 AM, linuxgurugamer said:

The issue seems to be that the tanks on the side are also engines, with fuel in them, the fuel in them is what's confusing GT.

lol... I just spent this morning trying to replicate my craft without seeing this post. 

I got there eventually and can independently confirm that this has something to do with the use of radially-mounted boosters.  My original craft file used liquid boosters with fuel ducts in an asparagus configuration.  My test files did the same with and without asparagus and swapping out liquid boosters with solid fuel alternatives. 

The results are all broadly the same so far: the radial separator fails to stage.  However, the exact staging behaviour depends on where the radial stage is located, relative to the engine plate staging event. 

For example, using the image below (craft file), if the radial stage (3) is immediately before the engine plate staging event (2), then the gturn script will perform two stage events back-to-back when ALL the fuel is expired from the preceding stages (just allow the central core to keep running with expired boosters attached and it will eventually stage).

gturn3.png

If, however, there is a preceding stage that exists between the events, it appears to fail completely.  Using the image below (craft file), if the radial stage (4) is followed by a stage (3) that precedes the engine plate staging event (2), then the gturn script will fail to perform any future staging completely.

gturn5.png

If we amend how that above ship works (craft file) and replace the engine plate with a a normal separator and an inverted fairing with interstage nodes enabled, the (otherwise) same craft will stage appropriately.  Note to other users: The only down side to this approach is that you need to remember to set the fairing air pressure cutoff to zero in the mod GUI (or you'll have an early ejection mid-atmosphere).

gturn6.png

Maybe you already know all that and the reasons why... but those are my findings.

Link to comment
Share on other sites

Not sure whether it's related to the issues @TMS reports, but I used to have problems with the auto-staging of side-mounted boosters in gravity turn continued until I discovered the auto-stage option in mechjeb.  I never quite figured out when the problem did or did not occur, but turning that option on seemed to make my problems go away.

Link to comment
Share on other sites

9 hours ago, rmaine said:

Not sure whether it's related to the issues @TMS reports, but I used to have problems with the auto-staging of side-mounted boosters in gravity turn continued until I discovered the auto-stage option in mechjeb.  I never quite figured out when the problem did or did not occur, but turning that option on seemed to make my problems go away.

That was Mechjeb doing the staging for  you, I think it just hid the problem.

I'll be working on this soon

Link to comment
Share on other sites

gturn-thanks.png

Using the crafts above (3, 5 and 6), the update appears to work.  The radial separators and subsequent stages activate as expected.  I'll leave the updated mod in my game data and run with it in my main game to see if I can find any exceptions (may take a while because I removed engine plates from my repertoire) , but it looks pretty good from where I'm sitting.

Thanks for fixing this.  I know you have taken guardianship of a large amount of code, but this mod makes launcher development and testing so much more precise.  Much appreciated.

Link to comment
Share on other sites

  • 3 weeks later...
On 9/4/2022 at 10:08 PM, Atlas Gaming said:

Hey I think I posted a similar big before and you fixed it... but in GravityTurn the windown position does not seem to be saved... and it used to before you took it over, and I think also after you fixed it half a year ago or so. Now keeps coming back to top left.

Just a friendly reminder that this is still not working. Window postion keeps getting reset each flight. This used to be saved, then it broke when you took over, and you fixed it a year or more ago, then a few months ago it broke again. 

Log link https://www.dropbox.com/t/u4Sa6NhEaROZ8zT7

Link to comment
Share on other sites

  • 2 weeks later...
On 12/18/2022 at 3:46 PM, linuxgurugamer said:

Your staging is wrong, you have three different decouplers in the same stage

Once I fixed that, I see the problem in your rocket.  The issue seems to be that the tanks on the side are also engines, with fuel in them, the fuel in them is what's confusing GT.  Doesn't matter it's solid rather than liquid.  Not sure if this can be fixed, but I'll take a look

Apologies! As mentioned on the SmartStage thread, SS will lump all Engine Plates (plus the next decoupler, if there is one) into one stage. In all the rebuliding, reloading and testing, I must have forgotten to fix the staging before saving the craft file for export.

I see downthread that you have solved the issue; I will test it out the next time I go on a KSP spree. Cheers!

Link to comment
Share on other sites

  • 1 month later...
2 hours ago, antipro said:

some time ago, I remember to have report a problem about autostage worked with boosters but not with radial LF tanks. re-tried few time ago, is the same, LF tanks do not detach.
can I do something?

Should have been fixed in the last version.  Please make sure you are using the latest and try again.  If it still has a problem please provide both the log file and the craft file for analysis

Link to comment
Share on other sites

14 hours ago, antipro said:

craft: https://www.dropbox.com/s/7ac37kni7hj9znc/0 test.craft?dl=0
I know u need 2 logfiles, but can't remember their names and where to find them.

Read this BEFORE asking for supporthttp://forum.kerbalspaceprogram.com/index.php?/topic/83212-how-to-get-support-read-first/

Are you using the latest version?

 

Edited by linuxgurugamer
Link to comment
Share on other sites

1 hour ago, antipro said:

I have 1.8.3 installed from CKAN.
This is player.log
https://www.dropbox.com/s/dnez3u9u00oimhn/Player.log?dl=0

but I could not find the output_log.txt file anywhere.

Output.log was from the early versions of KSP

The Player.log is what I wanted.

It looks ok, I'll see what I get with the craft file

Link to comment
Share on other sites

11 hours ago, antipro said:

ok, with CF disabled it works, but I lose dV. I've never used decouplers with CF disabled.

If crossfeed isn't disabled, then fuel will flow from the main tank into the two side tanks.  GT see this and doesn't trigger the staging event because you really don't want to be doing that

You shouldn't be losing dV, if you are, you aren't flying a good launch profile.  You don't want to be carrying those side tanks once they are empty, just a waste of dV

 

 

Link to comment
Share on other sites

14 hours ago, antipro said:

ok, with CF disabled it works, but I lose dV. I've never used decouplers with CF disabled.

Rather than using crossfeed-enabled-decouplers, you might get the effect you want by using fuel lines to direct the fuel in to the core. The problem with crossfeed-enabled-decouplers is they feed both ways - when the core is emptier than the boosters they feed fuel in, BUT when the boosters are emptier than the core they feed fuel outwards! Fuel lines are single-direction.

Link to comment
Share on other sites

  • 2 weeks later...
On 1/15/2023 at 6:06 PM, Atlas Gaming said:

Just a friendly reminder that this is still not working. Window postion keeps getting reset each flight. This used to be saved, then it broke when you took over, and you fixed it a year or more ago, then a few months ago it broke again. 

Log link https://www.dropbox.com/t/u4Sa6NhEaROZ8zT7

Using latest version from CKAN and latest KSP version, window resets each time I start the game to x63 y63.  Tried editing the gt_window file but it still just defaults to x63 y63.

Link to comment
Share on other sites

  • 2 weeks later...
This thread is quite old. Please consider starting a new thread rather than reviving this one.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...