R-T-B Posted Sunday at 01:46 AM Share Posted Sunday at 01:46 AM (edited) Following a discussion with the man himself, I'll be taking over management of this project and administering PR's (which we encourage!) from the community as appropriate. If you are here, you probably already know what this mod does. We are just fixing some old bugs and modernizing the code a bit. So far, we already have one release with a bugfix for ASL Atmopsheric pressure hardcoding on worlds named "Kerbin" and some other maintenance related changes. Source and a manual can be found here. License: ARR to Sigma88, allowing changes strictly via R-T-B, who will administer the project for the time being until/if Sigma sees fit to takeover again. Download Proof of adoption follows: Edited Sunday at 01:49 AM by R-T-B Quote Link to comment Share on other sites More sharing options...
CashnipLeaf Posted Sunday at 02:00 AM Share Posted Sunday at 02:00 AM 7 minutes ago, R-T-B said: a bugfix for ASL Atmopsheric pressure hardcoding on worlds named "Kerbin" More thorough explanation of the bug: When rescaling, if a celestial body had the internal name "Kerbin" (as a homeworld likely would), the first key of its atmosphere pressure curve (usually corresponding to sea level) got deleted and replaced with one representing stock Kerbin's sea level pressure of 101.325kPa. If you were just rescaling the stock system, this wasn't a problem, but this can create some funny behavior when used with system replacers, ranging from barely noticeable to just plain weird, depending on the normal pressure curve of the rescaled homeworld. I suspect this was a necessary (albeit hacky) fix when it was written due to KSP doing ISP and delta-v calculations based on "Kerbin's" parameters (i.e. the parameters of whatever body was named "Kerbin"), but that has since been corrected by Squad and/or Kopernicus (I am not 100% sure which, I haven't been in the community long enough to know for sure) so this hack fix isn't needed anymore. Quote Link to comment Share on other sites More sharing options...
dave1904 Posted Sunday at 07:44 PM Share Posted Sunday at 07:44 PM Do you all still use Kronometer 1.12.0.2? Quote Link to comment Share on other sites More sharing options...
R-T-B Posted Tuesday at 03:50 PM Author Share Posted Tuesday at 03:50 PM (edited) On 5/26/2024 at 12:44 PM, dave1904 said: Do you all still use Kronometer 1.12.0.2? Kronometer is a separate mod so not sure how it relates to this topic, but last I heard LGG was adopting it. I'd use that. It does appear to be that version. Edited Tuesday at 04:03 PM by R-T-B Quote Link to comment Share on other sites More sharing options...
IAmTheRealBeef Posted 18 hours ago Share Posted 18 hours ago You are incredible and have your hands in so many projects! I've just seen this - I'm sure you've seen the somewhat overlapping functionality from Celestial Rescale, which I believe originated from Sigma being a bit outdated. I was excited to contribute something to Celestial Rescale so I could properly scale-up my world by 2.7x ... but since Sigma was already a bit more fleshed-out perhaps its better use of my time in to this new Sigma repository now? Quote Link to comment Share on other sites More sharing options...
GoldForest Posted 15 hours ago Share Posted 15 hours ago (edited) On 5/28/2024 at 10:50 AM, R-T-B said: Kronometer is a separate mod so not sure how it relates to this topic, but last I heard LGG was adopting it. I'd use that. It does appear to be that version. Kronometer fixes the clock to be accurate for the rescaled solar system. I think they were asking if it's still needed or does Sigma fix the clock itself. I would think that Rescale would need to implement the fix and not sigman, though. Edited 15 hours ago by GoldForest Quote Link to comment Share on other sites More sharing options...
Sigma88 Posted 11 hours ago Share Posted 11 hours ago On 5/26/2024 at 4:00 AM, CashnipLeaf said: More thorough explanation of the bug: When rescaling, if a celestial body had the internal name "Kerbin" (as a homeworld likely would), the first key of its atmosphere pressure curve (usually corresponding to sea level) got deleted and replaced with one representing stock Kerbin's sea level pressure of 101.325kPa. If you were just rescaling the stock system, this wasn't a problem, but this can create some funny behavior when used with system replacers, ranging from barely noticeable to just plain weird, depending on the normal pressure curve of the rescaled homeworld. I suspect this was a necessary (albeit hacky) fix when it was written due to KSP doing ISP and delta-v calculations based on "Kerbin's" parameters (i.e. the parameters of whatever body was named "Kerbin"), but that has since been corrected by Squad and/or Kopernicus (I am not 100% sure which, I haven't been in the community long enough to know for sure) so this hack fix isn't needed anymore. the harcoded name "Kerbin" was because at the time the name of the homeplanet needed to be "Kerbin" (you could change the displayName but the actual name needed to be "Kerbin" for some reason) as for the fix, I'm not sure if it was for ISP or for the atmospheres of other planets being calculated based on the home planet, (so if you change the atmospheric curve of kerbin to be identical to duna, both kerbin and duna would display atmosphere of 1 atm rather than whatever fraction of 1 atm duna's atmosphere is) On 5/26/2024 at 3:46 AM, R-T-B said: Proof of adoption follows: ✔️ Quote Link to comment Share on other sites More sharing options...
Beetlecat Posted 8 hours ago Share Posted 8 hours ago 3 hours ago, Sigma88 said: ✔️ Heh. Quote Link to comment Share on other sites More sharing options...
R-T-B Posted 7 hours ago Author Share Posted 7 hours ago 10 hours ago, IAmTheRealBeef said: You are incredible and have your hands in so many projects! I've just seen this - I'm sure you've seen the somewhat overlapping functionality from Celestial Rescale, which I believe originated from Sigma being a bit outdated. I was excited to contribute something to Celestial Rescale so I could properly scale-up my world by 2.7x ... but since Sigma was already a bit more fleshed-out perhaps its better use of my time in to this new Sigma repository now? I'd think SigmaDimensions might be worth looking at yeah, it's a much more complete project. Only issue is licensing, Sigma wants to keep it ARR and while that technically means you are signing off your rights to him, I talked with him and it's pretty clear he's not out to poach anyones work, he just wants to protect his stewardship as the lead if he ever wants to come back. He's a chill guy, I'd worry little about it. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.