Problems with "attach a part" contracts.

[BenG]

 I'm not sure if this is a bug, or a mod issue, or something I've done, but I've had a problem on my last two "attach a part" contracts. After giving up and cancelling the first contract, on the second time I decided to go digging and see what I could find.

Here is the satellite in question, with the 1x6 panel already attached but the mission not complete, and the mission itself (note, the mission does not display the name of the target spacecraft).

 

I went digging into the persistent.sfs and found the contract:

CONTRACT
			{
				guid = a55a3d20-d824-431d-8ff1-14a3f6c335cb
				type = OrbitalConstructionContract
				prestige = 0
				seed = 1430119283
				state = Active
				viewed = Read
				agent = Dinkelstein Kerman's Construction Emporium
				agentName = Dinkelstein Kerman's Construction Emporium
				deadlineType = Floating
				expiryType = Floating
				values = 129600,18403200,32959.9990844727,108149.992084503,34607.9974670411,0,1.804179,0.9756098,18490730.4161536,18405943.3255453,36809143.3255453,0
				bodyName = Kerbin
				constructionCraftDef = E:/Kerbal Space Program/KSP_x64_Data/../GameData/Squad/Contracts/PreBuiltCraft/OrbitalConstructionContract/Unfinished Contract Sat 8.craft
				constructionVslId = 2055096434
				constructionPartName = solarPanels4
				orbitEccentricity = 0.05000000074505806
				orbitAltitudeFactor = 0.33000001311302185
				orbitInclinationFactor = 0.25
				vesselName = Aging Kerbin CMM Satellite 3-L5
				PARAM
				{
					name = CrewTraitParameter
					state = Complete
					disableOnStateChange = False
					values = 0,0,0,0,0
					targetTrait = Engineer
					targetCount = 1
					vesselDescription = Active Vessel
				}
				PARAM
				{
					name = ConstructionParameter
					state = Incomplete
					values = 0,0,0,0,0
					bodyName = Kerbin
					partName = solarPanels4
					vesselPersistentId = 2055096434
				}
			}

Note the vessel name, "Aging Kerbin CMM Satellite 3-L5",  which matches the satellite I have attached the panel to, and also the second contract parameter, which gives a vessel persistent ID of 2055096434.

This persistent ID does not exist for any vessel within my save file.

 

I also found the vessel "Aging Kerbin CMM Satellite 3-L5" within the save file (only the first 3 lines are relevent):

VESSEL
		{
			pid = b224b097693c4903a4ed22dc5f95e4a7
			persistentId = 197701767
			name = Aging Kerbin CMM Satellite 3-L5

Note the persistent ID is different to the contract.

 

I decided to have a play with the file and changed the persistent ID in the contract to match the actual vessel ID. Following this, the mission now shows the vessel name in the contract parameters, and the mission can now be completed.

 

Here is my list of mods (Version 1.11.1 with Making History 1.11.1 and Breaking Ground 1.6.1):

[416365416c]

I just ran into the same thing, and the only mod I have installed is Kerbal Engineer Redux. That makes me think it's a bug, but I had a successful "attach parts" contract before this one so it might not reproduce consistently.

Thanks for sharing how you fixed it, same approach worked for me to complete my contract . 

[flyfire2002]

Notice that the bugged persistentID matches the constructionVslId. I suspect that the contract failed to rewrite the target vessel pid in its param upon target vessel spawn.

[Bel Slavin]

Hey @BenG, did you manage to complete the contract after you made this change?

I ran into the same issue just yesterday / today and changed the corresponding persistentID, per your excellent sleuthing, and while the name of the target satellite did indeed show up in the contract, I was not awarded a completion when I put the part on it.

I then tried changing both referenced IDs in this thread and that still did not fix it.

How odd!

[BenG]

On 2/27/2021 at 6:51 AM, Bel Slavin said:

Hey @BenG, did you manage to complete the contract after you made this change?

I ran into the same issue just yesterday / today and changed the corresponding persistentID, per your excellent sleuthing, and while the name of the target satellite did indeed show up in the contract, I was not awarded a completion when I put the part on it.

I then tried changing both referenced IDs in this thread and that still did not fix it.

How odd!

Yes, after I changed the contract persistentID to match the vessel, then I was able to complete the contract.