W3C issues with the forum

[katateochi]

A couple of (minor but annoying) things which are broken.  Now, when I say "broken" I'm saying that with my (fairly pernickety) web developer hat on and I mean broken in a W3C sense (basic browser functionality).

1 - On the messager page (http://forum.kerbalspaceprogram.com/index.php?/messenger/)
In the list of messages on the left, when you mouse over any part of the messages in that list the cursor style is "pointer" (which form a W3C point of view implies that it's a link).  But the only clickable part is the message subject. It should have a cursor:default for everything else and switch to cursor:pointer when you mouse over the subject.  
OR which would be much more useful; The whole thing should be clickable (as the current cursor implies), so clicking anywhere on a message in the list should open the message (rather than having to click on just the subject).  

That's real simple to fix with a little bit of jQuery (or you could do it with pure native javascript).  Add this to the javascript that's loaded on the messenger page;

$('.ipsDataItem_main').on("click", function(){ window.location.href = $(this).find('a').attr('href'); return false; })

Binds an onclick event to the whole message container which follows the href of the link on the subject.

 

2 - broken "back" functionality on threads.
If you click on a thread that has multiple pages of replies you are taken to page 1. Then if you click on page 2 you go to page 2.  BUT now if you click back the page will scroll to the top but doesn't take you back to page 1, you remain on page 2.  If you click back again you get taken to where you were before clicking on the thread.
However if you go from page 1 to page 2, then go to page 3 and then click back; you will get taken page to page 2.  If you click back again then you stay on page 2. (and back again will take you back to before you clicked on the thread).

Basically the back functionality doesn't let you return to page 1 which is pretty serious broken functionality.  This is due to how the AJAX manipulates the browser history.  On all pages except page 1 it adds &page=x where x is the current page no. If when loading page 1 it also appended &page=1 then the back functionality would work.  However I've tried messing around with window.history.replaceState and I can't as yet find a working solution (I think there are some other events that are preventing that from working right).

 

3 - Hold ctrl and right click for more options
Technically (W3C speaking) this isn't broken, it's just annoying!
When you mouseover the text-area of the editor you get the tip text (title) saying "Hold ctrl and right click for more options".  Having this as the element's title attribute means that it constantly pops up while you're trying to use the editor.  You can click in the editor to make it go away, but if you then happen to mouse away and then back again it re-appears. There really shouldn't be a title attribute on a text field/area like this. obviously it's trying to hint at some of the more "hidden" functionality, but just having that text in the footer of the editor (where is also has the insert other media link) would be better.

This takes the title from the editor and stuffs it into the "attachmentArea" div under it and then removes the title attr from the editor.  Call that on pages you can post on.

$('*[data-role="attachmentArea"]').prepend($('.cke_wysiwyg_div').attr("title")); $('.cke_wysiwyg_div').attr("title", "");

I say "stuffs it" as it's literally just prepends the text to that area.  It could do with being more carefully placed, probably needs a little CSS to clean it up.

EDIT
also just noticed in posting this; Syntax highlighting on code blocks is only applied to the last code block you interact with.  If I set syntax to javascript on both the above code blocks the syntax highlighting is only shown on which ever one I set last.

Edited December 5, 2015 by katateochi

[LordFerret]

Of course you do realize that Squad has absolutely nothing to do with this, and that you should post this on IPS's forums... right?

[katateochi]

On 05/12/2015, 17:59:01, LordFerret said:

Of course you do realize that Squad has absolutely nothing to do with this, and that you should post this on IPS's forums... right?

I'd assume that it's possible to inject custom CSS and javascript into the current deploy for this site which would be a simpler (and faster) fix than submitting a bug report to IPS and then having to upgrade to an update patch later. But I will pass on the 2nd point to IPS as that's a really badly broken bit of functionality and I can't find a simple JS patch solution to it atm. 

[MGCJerry]

This... So much this. I hate AJAX navigation. It appears the web is going to pretty-ness over standard functionality.