KSPField isPersistant doesn't appear to be working

[JoePatrick1]

I am trying to save 'lowPowerMode' so that if I load the craft it will be whatever it was when I was last flying that vessel but it always seems to reset to false when I re-load it.  

Here is the code

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace ProbeLowPower
{
    public class ProbeLowPower : PartModule
    {
        [KSPField(isPersistant = true)]
        public bool lowPowerMode;
        [KSPField(isPersistant = false)]
        public float lowPowerRatio;
        public double normalRate;
        public double lowPowerRate;
        public ModuleResource moduleResource;

        public override void OnAwake()
        {
            if (HighLogic.LoadedSceneIsFlight)
            {
                foreach (ModuleResource modres in this.part.GetComponent<ModuleCommand>().inputResources)
                {
                    if (modres.name == "ElectricCharge")
                    {
                        moduleResource = modres;
                        normalRate = modres.rate;
                        lowPowerRate = normalRate * lowPowerRatio;
                    }
                }

                print("AWAKE, Low Power Mode: " + lowPowerMode);
                if (lowPowerMode)
                    moduleResource.rate = lowPowerRate;
                else
                    moduleResource.rate = normalRate;

            }         
        }

        [KSPEvent(active = true, guiActive = true, guiActiveEditor = false, guiActiveUnfocused = false, guiName = "Low Power Mode: Disabled")]
        public void activateLPM()
        {
            lowPowerMode = true;
            moduleResource.rate = lowPowerRate;
            Events["activateLPM"].active = false;
            Events["deactivateLPM"].active = true;
        }

        [KSPEvent(active = false, guiActive = true, guiActiveEditor = false, guiActiveUnfocused = false, guiName = "Low Power Mode: Enabled")]
        public void deactivateLPM()
        {
            lowPowerMode = false;
            moduleResource.rate = normalRate;
            Events["activateLPM"].active = true;
            Events["deactivateLPM"].active = false;
        }
    }
}

 

[Diazo]

Can you add a Debug.Log(lowPowerMode); line to the Update method?

I think your issue is that OnAwake only runs once when the module is created and so always runs before OnLoad does (which is when KSPFields load data from the save file). If this is the case, things are working correctly, just your Debug.Log line will always say FALSE as it runs before the KSPField can load its state from the save file.

D.

[JoePatrick1]

14 minutes ago, Diazo said:

Can you add a Debug.Log(lowPowerMode); line to the Update method?

I think your issue is that OnAwake only runs once when the module is created and so always runs before OnLoad does (which is when KSPFields load data from the save file). If this is the case, things are working correctly, just your Debug.Log line will always say FALSE as it runs before the KSPField can load its state from the save file.

D.

I know that it's not just the debug log because it still uses the normal rate, rather than the low power rate but would it work if I put it in OnLoad as this is where it toggles the low power mode based on whether or not the variable is true/false?

Edited March 31, 2016 by JoePatrick1

[Diazo]

The entire point of the KSPField being persistent is that you don't have to use the OnSave/OnLoad methods to save/load data, it's done by the KSPField for you.

My suspicion is that it is still an order of operations issue between the different methods. Can you comment out the OnAwake method and see if LowPowerMode saves?

D.

[JoePatrick1]

1 minute ago, Diazo said:

The entire point of the KSPField being persistent is that you don't have to use the OnSave/OnLoad methods to save/load data, it's done by the KSPField for you.

My suspicion is that it is still an order of operations issue between the different methods. Can you comment out the OnAwake method and see if LowPowerMode saves?

D.

I just tried changing onAwake to onLoad and now it works perfectly. The state is saved with isPersistent but I cannot save the rate of power drain as this is saved in the part files and is loaded reloaded by the stock modules each time. I have to load the state, then set the rate accordingly