[Resolved] Hang with KSPEvent in 1.2

[MOARdV]

I've been keeping the AviationLights mod working for a couple of KSP revisions now.  It has the following code in it to allow the user to toggle light modes:

        [KSPEvent(name = "FlashEvent", active = true, guiActive = true, guiName = "Flash")]
        public void FlashEvent()
        {
            _lastTimeFired = 0;

            if (navLightSwitch == 1)
                navLightSwitch = 0;
            else
                navLightSwitch = 1;
        }

        [KSPEvent(name = "DoubleFlashEvent", active = true, guiActive = true, guiName = "Double Flash")]
        public void DoubleFlashEvent()
        {
            _lastTimeFired = 0;

            if (navLightSwitch == 2)
                navLightSwitch = 0;
            else
                navLightSwitch = 2;
        }

        [KSPEvent(name = "IntervalEvent", active = true, guiActive = true, guiName = "Interval")]
        public void IntervalEvent()
        {
            _lastTimeFired = 0;

            if (navLightSwitch == 3)
                navLightSwitch = 0;
            else
                navLightSwitch = 3;
        }

        [KSPEvent(name = "OnEvent", active = true, guiActive = true, guiName = "Light")]
        public void OnEvent()
        {
            _lastTimeFired = 0;

            if (navLightSwitch == 4)
                navLightSwitch = 0;
            else
                navLightSwitch = 4;
        }

 

Which worked in KSP 1.1.3.  In KSP 1.2, the game hangs.  I tried renaming the methods, and I sprinkled a few more of the fields from KSPEvent, so it looked more like this:

[KSPEvent(name = "LightFlashEvent", advancedTweakable = false, guiActiveUncommand = false, requireFullControl = false, active = true, guiActive = true, guiName = "Flash")]

 

But that didn't fix it.  Can someone tell me what else do I need to update for this to work in KSP 1.2?  The plugin works if I use the KSPAction fields to set it up.  The KSPAction fields are simply wrappers to call these methods, so my suspicion is that something is different about KSPEvent that I need to account for.

EDIT: To clarify "Which worked in KSP 1.1.3.  In KSP 1.2, the game hangs": when the user right-clicks on one of the lights in the Flight scene, it used to bring up the context menu, which allowed the user to select one of those modes.  In KSP 1.2, when the user right-clicks on the light, the game hangs.

EDIT 2: RPM uses KSPEvent, and it's not crashing, so there must be something else going on with either the model or the config - I also notice that the part highlighter doesn't highlight the aviation light when I hover the mouse over it in flight.

EDIT 3: No, it's something in the Module that's causing the problem.  If I remove ModuleNavLight, I can fly the mouse over the part without a problem.  With ModuleNavLight, as soon as I fly the mouse over it, the game hangs.  Urk.

Edited October 12, 2016 by MOARdV

[MOARdV]

I think it was because the module was using the old part.RequestResource code.  Why that would cause a hang on mouseover, I'm not sure.