Jump to content

Github help: How to make a second pull request on top of a pending one?


Dunbaratu

Recommended Posts

This is a question about Github, but it relates to KSP mods because it's for a KSP mod project I'm trying to contribute some changes to. I asked this question on some github forums but I'm not getting answers and I'm still lost.

The situation:

For the first issue: I am not the project owner but am trying to contribute small changes to the project. I made my own github fork of the project, then fetched that to a local copy on my own computer, made my changes there, committed them, and pushe them back to my own github fork, and made the pull request for it. This worked fine. The author said it may be a few days before that pull request gets merged in with the main project.

So I also tried to fix a second issue. I made the code changes in my local copy to perform those changes and tested them locally and it all looks good. But now when I try to commit and push those changes back to my github fork, they keep getting assigned to my previous pull request. How do I stop my future commits from being applied to that previous pull request (that's still pending) and instead apply them to a second pull request meant to be applied after my previous pull request?

Link to comment
Share on other sites

Thanks - I got the advice to make it work now.

It's not just that it has to be a second branch, but that it can't be a branch off of my previous change. It has to be a branch from the original fork point prior to my previous change, otherwise the two changes can't be treated as different independently pull-able changes.

Link to comment
Share on other sites

This thread is quite old. Please consider starting a new thread rather than reviving this one.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...