[Solution]gameobject.transform.parent breaks scenariomodule

[Cyrik]

Hey,

I just wanted to post this so the next guy running into it wont spend forever trying to figure it out.

Here's the offending plugin:

    [KSPScenario(ScenarioCreationOptions.AddToAllGames,GameScenes.FLIGHT)]    
    public class Class1 : ScenarioModule
    {
        private Transform _origTransform;
        public void Start()
        {
            Debug.Log("[MRO] init");
            _origTransform = gameObject.transform.parent;
            gameObject.transform.parent = null;
        }

        public void OnDestroy()
        {
            Debug.Log("[MRO] destroy");
        }
    }

This plugin will load once on the flight scene, then it will get destroyed when you switch crafts and wont be reinitialized. Actually when you set gameobject.transform.parent to nearly anything it gets broken. The only way around it i found is to set it back to gameObject.transform.parent = _origTransform; in OnDestroy or somewhere else.

Edited August 30, 2014 by Cyrik
changed constructor to Start call

[DMagic]

I'm not sure you should be using a constructor for a scenario module. KSP will create a list of all the protoscenariomodules in Game. If you need an instance of your scenario module you can just pull it out of that.

Edit: Actually you shouldn't use constructors with any monobehaviour: http://docs.unity3d.com/ScriptReference/MonoBehaviour.Awake.html. They should only started with KSP attributes or by manually adding with gameObject.AddComponent.

Edited August 30, 2014 by DMagic

[Cyrik]

I'm not sure you should be using a constructor for a scenario module. KSP will create a list of all the protoscenariomodules in Game. If you need an instance of your scenario module you can just pull it out of that.

Edit: Actually you shouldn't use constructors with any monobehaviour: http://docs.unity3d.com/ScriptReference/MonoBehaviour.Awake.html. They should only started with KSP attributes or by manually adding with gameObject.AddComponent.

Thank you, I´ll fix that part. Sadly the problem still stands. Even if you change the gameobject.transform.parent anywhere else it breaks the whole thing. I just wanted to illustrate it in as little code as possible.