[0.90] [DEV] Plane Mode - Swap Yaw/Roll in Flight

[zengei]

Plane Mode

Development

Release Thread

This is the development thread for Plane Mode. For more information please see the release thread.

Download:

• v0.4.1 Released Beta
  

Requires:

• Module Manager
  

Source: GitHub

License: MIT/CC BY 3.0

Edited April 29, 2015 by zengei

[Camacha]

Very useful, this has been one of my annoyances while using a controller

[lextacy]

soooo, if im using the keyboard....I can use this mod to turn planes with just using the A & D key ?

[zengei]

soooo, if im using the keyboard....I can use this mod to turn planes with just using the A & D key ?

Yes, indeed.

[lextacy]

Yes, indeed.

That is going to make turning more easy , and fun. Was tired of the jerky hurkey way you had to turn the planes

[Reblet]

Hello Zengei,

Your mod is a lifesaver as my stick does not allow swapping axes in the profiler (despite having three shift modes :/).

Unfortunately, I found a bug: if no control input is given either on roll or yaw in plane mode, the trims are not applied, either. The pitch indicator doesn't move either, although pitch input is in fact applied to the craft.

I think the offending piece of code is in turning the autopilot on and off explicitly. If fly with the SAS off, but by setting FlightGlobals.ActiveVessel.Autopilot.Enabled = true I guess it's forced on anyway?

I wonder if it is necessary to turn the autopilot on and off (and mess with SAS) in the first place? As the swapping occurs in OnPreAutopilotUpdate, it appears to me that the yaw and roll can simply be swapped and then it's up to the SAS code to figure out what to do with that (if anything)?

Hope it will be possible to squash this bug.

Regards,

Reblet

[zengei]

Your mod is a lifesaver as my stick does not allow swapping axes in the profiler (despite having three shift modes :/).

Glad you find it useful.

Unfortunately, I found a bug: if no control input is given either on roll or yaw in plane mode, the trims are not applied, either. The pitch indicator doesn't move either, although pitch input is in fact applied to the craft.

Drats, this has been out there suspiciously long without a bug report.

I think the offending piece of code is in turning the autopilot on and off explicitly. If fly with the SAS off, but by setting FlightGlobals.ActiveVessel.Autopilot.Enabled = true I guess it's forced on anyway?

I wonder if it is necessary to turn the autopilot on and off (and mess with SAS) in the first place? As the swapping occurs in OnPreAutopilotUpdate, it appears to me that the yaw and roll can simply be swapped and then it's up to the SAS code to figure out what to do with that (if anything)?

This was in the original Aeroplane Mode code and I was suspicious of it too, but not turning them off explicitly causes the autopilot/SAS to flip out. You would think doing it in OnPreAutopilotUpdate would be rather transparent, but unfortunately it's not. I'll look into it and see if there's a better way. Thanks.

[zengei]

Rablet,

I've pushed some changes that should fix your issues. I've completely revamped how the switching is done now. It's simultaneously both more robust and fragile. More robust because it's effectively doing what a player what do if they changed their controls manually so it should be completely transparent to the SAS, autopilot, and other mods. More fragile because in order to do that I had to perform shenanigans that may break between KSP versions. The tradeoff is well worth it though.

You can download a dev version here (dev version is still marked v0.3.0, but it's the updated code, I swear). If it's not completely broken, I'll push this as v0.4.0.

[zengei]

v0.4.0 published in the release thread.

[Reblet]

Cheers mate!

Didn't get to play KSP yesterday, but from a quick tour with 0.4.0 it seems to do exactly as promised on the tin! Trims work without a hitch now. Excellent work.

Reblet