pjf
-
Posts
272 -
Joined
-
Last visited
Content Type
Profiles
Forums
Developer Articles
KSP2 Release Notes
Bug Reports
Status Replies posted by pjf
-
Hi pjf,
I'm not sure what the right method to get in touch with the CKAN maintainer cabal is. I'd like to join and help get the backlog of Pull Requests for metadata sorted out. I gather there's an agreement that people don't merge their own pull requests and I've just now gotten my hands on a copy of netkan.exe that seems to work properly. I'm completely willing to follow any guidelines about what to merge and what not to merge, though I can't see myself doing anything about any code. I'm happy to just help out with metadata.
We've got Pull Requests over a week old waiting for merging. Something needs to be done.
Myk
-
@politas: And I'm working through your PRs and it's very clear you know how everything works! You *totally* rock. Thank you again for all this.
-
-
Hi pjf,
I'm not sure what the right method to get in touch with the CKAN maintainer cabal is. I'd like to join and help get the backlog of Pull Requests for metadata sorted out. I gather there's an agreement that people don't merge their own pull requests and I've just now gotten my hands on a copy of netkan.exe that seems to work properly. I'm completely willing to follow any guidelines about what to merge and what not to merge, though I can't see myself doing anything about any code. I'm happy to just help out with metadata.
We've got Pull Requests over a week old waiting for merging. Something needs to be done.
Myk
-
Politas, you wonderful person, for some reason I had thought that I'd given you a contributor's bit on github long ago, because goodness knows you more than anyone deserves it. I don't know how it was that I had missed doing so, but that's now fixed.
The main requirement we have for contributors is following and enforcing the Code of Conduct. Otherwise the general procedure for merging is making sure that the testing bots are happy (you'll see a "tests: passed/failed" next to the merge button), and having a set of human eyes look over the changes to make sure they look sensible. Bonus points if you human-test as well; I don't usually fire up KSP, but I do check to see the expected files are installed.
One of the gotchas with PRs is the automatic ones from KerbalStuff usually aren't suitable for merging as-is. If we're very lucky they will be, but the code which submits them is very simple, and obviously can't handle all the complexity which is needed. It's totally acceptable to open a PR that adds the mod correctly, with a note like "supersedes #1337" (which can then be closed).
If you use IRC, then the #ckan channel on irc.esper.net tends to be the hub of development activity. I may not see activity unless my name is mentioned, so make sure to include 'pjf' when saying hi.
You totally rock, and thank you so much again for all your help. You are a true hero.
-
