[1.1.2] Kerbal Inventory System (KIS) 1.2.12

[IgorZ]

1 hour ago, sardia said:

Putting a part into your inventory when it is part of a rescue contract causes you to fail the contract because it was destroyed and recreated. Is there a way to fix that? I failed a contract or two because I was trying to shuffle parts around.

Consider creating a bug report on GitHub. This way it's easier to track and, eventually, fix the problem. Can you give an example of a failed contract? What was the objective, and what was the quest item? Was it a "stock" contract (carrier mode) or from an addon (name)?

From the implementation point of view when an item is placed into inventory it's actually get destroyed, and then re-created when pulled out. I'd say it's not surpising the contarct has failed.

[IgorZ]

 

On 12/17/2015 at 4:14 AM, katateochi said:

I think I've found a possible issue with KIS;

So, I think I found a solution for the problem. You may try uploading a fixed DLL from https://github.com/ihsoft/KIS/releases/tag/v1.2.3-alpha2-experimental. Though, keep in mind that this is a development binary which is not officailly merged into the main branch. It's basically my development branch which is very far from the original trunk on GitHub. If it does fix the problem I'll make a pull request to KospY.

Btw, you also may spend some time testing moving/attaching groups (hierarchies) of parts - that's another feature that is pending in this binary. I'll be very appreciated to hear the feedback.

Edited December 23, 2015 by IgorZ

[sardia]

8 hours ago, IgorZ said:

Consider creating a bug report on GitHub. This way it's easier to track and, eventually, fix the problem. Can you give an example of a failed contract? What was the objective, and what was the quest item? Was it a "stock" contract (carrier mode) or from an addon (name)?

From the implementation point of view when an item is placed into inventory it's actually get destroyed, and then re-created when pulled out. I'd say it's not surpising the contarct has failed.

Ie. Rescue Herman and his cockpit. If you grab his cockpit and put it into your inventory, you fail the contract. I'll try to get on github later. It also happens to kerbals too. Like if you put the kerbals who's in the cockpit into the inventory. It registered as failing the contract. 

[goldenpsp]

19 minutes ago, sardia said:

Ie. Rescue Herman and his cockpit. If you grab his cockpit and put it into your inventory, you fail the contract. I'll try to get on github later. It also happens to kerbals too. Like if you put the kerbals who's in the cockpit into the inventory. It registered as failing the contract. 

Maybe I'm not understanding, but I don't see the issue.  If the contract is to rescue the kerbal and cockpit, then being able to put it in inventory, or KIS connect it a different way seems an easy way to exploit the contract challenge.

[sardia]

Fair point, I was just surprised that it registered as failing the contract. Some times when you are handling a part with kis and KAS, it'll fly away at high speed due to collisions. The quickest way to resolve it is to shove it into your inventory. 

It's a fun way to do rescue contacts that include bringing back the wreck. You just fly up to it, remove the nose cone, and attach the rescued part. Way less buggy than the klaw. 

PS there no way to get a kerbals out of a mk1crew pod without KIS.  It has no doors!

Edited December 23, 2015 by sardia

[goldenpsp]

1 hour ago, sardia said:

Fair point, I was just surprised that it registered as failing the contract. Some times when you are handling a part with kis and KAS, it'll fly away at high speed due to collisions. The quickest way to resolve it is to shove it into your inventory. 

It's a fun way to do rescue contacts that include bringing back the wreck. You just fly up to it, remove the nose cone, and attach the rescued part. Way less buggy than the klaw. 

PS there no way to get a kerbals out of a mk1crew pod without KIS.  It has no doors!

Capture with Claw and use transfer crew?  I know it works normally.  I would think it would work for a rescue contract as well.  I've certainly used it for rescue missions.

Edited December 23, 2015 by goldenpsp

[pellinor]

2 hours ago, goldenpsp said:

being able to put it in inventory, or KIS connect it a different way seems an easy way to exploit the contract challenge.

The whole idea of KIS is breaking a central challenge of the game (not being able to rebuild vessels in flight). Making rescue contracts a bit easier is just one small consequence of those mechanics.

[goldenpsp]

1 hour ago, pellinor said:

The whole idea of KIS is breaking a central challenge of the game (not being able to rebuild vessels in flight). Making rescue contracts a bit easier is just one small consequence of those mechanics.

Sorry I disagree.  It is one thing to have a rescue mission where the challenges and limitations, if any are self imposed.  It is entirely different to accept a rescue CONTRACT, where you now have to follow the rules of that contract.

 

[IgorZ]

9 hours ago, sardia said:

Ie. Rescue Herman and his cockpit. If you grab his cockpit and put it into your inventory, you fail the contract.

I don't remember this kind of contracts in the stock game. Rescuing a kerbal is a common contract but saving the cockpit is something new. Are you 100% sure this contract is not from an addon? How the cockpit is supposed to be "rescued" (I'm leaving aside question "why")? What is the criteria of accomplishing the task?

9 hours ago, sardia said:

If you grab his cockpit and put it into your inventory, you fail the contract.

This is perfectly understandable since when a part is moved into the inventory it's get destroyed. For the contract script destruction of the quest part appears as a failing condition. To be honest, I don't see a way to fix this behavior since the object must be removed from the scene somehow, and destroying it is an easy and reliable way. Hiding the object by other means (disabling renderer, removing meshes, moving to a distant location, etc.) is too hacky and will likely have a lot of side effects. A possible workaround could be completing contract right away once the part is moved into the inventory but feasibility of the solution depends on the contract script.

9 hours ago, sardia said:

It also happens to kerbals too. Like if you put the kerbals who's in the cockpit into the inventory. It registered as failing the contract. 

The contract fails for the same reason as for the cockpit. Though, the whole behavior of putting kerbal into inventory is totally wrong. A kerbal being is not an object, and moving them into inventory must be restricted. In my development branch it is restricted - you cannot move/attach/detach/etc kerbals. If your mission is to save a kerbal then you need to bring a vessel with facilities to support a kerbonaut: a cockpit or an external command seat.

[IgorZ]

8 hours ago, sardia said:

PS there no way to get a kerbals out of a mk1crew pod without KIS.  It has no doors!

This is not true. When your rescuing vessel approaches the wreckage the crew onboard become "yours", i.e. you now can control them. Just switch to the wreckage using "[" / "]" keys, and use "EVA" button on the kerbal's icon: as long as exits are not blocked by the other parts it's possible to EVA (mk1crew cabin has two exits). After that you may use jetpack to approach the rescuing vessel. That's actually a normal way of doing these contracts but if you don't like easy ways you may, of course, try docking/attaching/etc

[DarthJeb]

On 12/22/2015 at 9:17 PM, ExplorerKlatt said:

What do you mean by linear attachment?

Essential attaching non-radially such as most engines in the game

[sardia]

This is what I mean by rescue the cockpit, it occurs in standalone missions or combined with rescue a kerbal. You just need to return it to Kerbin and recover the spacecraft. As for why I would put something into inventory for nonstorage purposes, it arrests any movement the part has. Sometimes when you "drop" an item near the rocket, it collides very violently and flies off into space. So I try to frog hop the part via attachment points or storage containers. Much safer and less likely for my engine or something precious to fly off into the darkness. I can show you a picture of this happening if needed.

[IgorZ]

4 hours ago, sardia said:

This is what I mean by rescue the cockpit, it occurs in standalone missions or combined with rescue a kerbal. You just need to return it to Kerbin and recover the spacecraft.

This is helpful, thanks. I'll try to lookup which script is producing it, and figure out if its behavior can be intercepted. Out of curiosity, why do you prefer using KIS to finish the mission instead of a regular way - using Advanced Grabbing Unit? The part's size of 3.8x2.5x1.5 gives 14.25 cubic meters of volume or 14250 liters. I.e. to fit the part you need inventory container ILC-18k which is not cheap or lightweight.

4 hours ago, sardia said:

As for why I would put something into inventory for nonstorage purposes, it arrests any movement the part has. Sometimes when you "drop" an item near the rocket, it collides very violently and flies off into space. So I try to frog hop the part via attachment points or storage containers. Much safer and less likely for my engine or something precious to fly off into the darkness. I can show you a picture of this happening if needed.

Yeah, I had this problem with the original KIS as well. Though, when I fixed false triggering of click events in the add-on the problem has gone for me. Could you please try the alpha3 version (only replace the .DLL in the KIS/Plugins folder) and let me know if bouncing problem still happens? If it does I'll be appreciated for a repro steps. And if you can make a short video to demonstrate the bouncing - it would be the best!

[sardia]

The AGU Klaw can only grab 1 unit. A single Kerbal + screwdriver can rescue as many parts/cockpits as needed so long as I have enough parachutes/engines. nEED TO eat, so I'll check back later.

[IgorZ]

15 hours ago, sardia said:

The AGU Klaw can only grab 1 unit. A single Kerbal + screwdriver can rescue as many parts/cockpits as needed so long as I have enough parachutes/engines. nEED TO eat, so I'll check back later.

The largest container, ILC-18k, is 18,000 liters of volume which can only hold one quest module in your case (14.3l). How is it better than one AGU per mission?

[sardia]

You arrest movement with a container. If you remove the parachute from the nose cone. Example.

This leaves an open node. Attached rescued part(usually the command module of the kerbal you rescue). Replace nose cone. Fly to next rescue mission. Attached rescued part by repeating previous steps as needed. If you're good with RCS, you don't need the container, but you may need to juggle the attachment points around to make sure your ship is still stable enough for reentry.

 

[IgorZ]

On 12/25/2015 at 5:10 PM, sardia said:

This is what I mean by rescue the cockpit, it occurs in standalone missions or combined with rescue a kerbal. You just need to return it to Kerbin and recover the spacecraft.

Hey! Could you please attach any savefile with this mission active? I've found the code that handles such contracts but according to what I see there mission completion is triggered on Docking with the part. It's not exactly what is stated in your contract, and I'd like to examine the save file to figure out how they do configure condition "recover it to Kerbin".

[sardia]

KAS/KIS attaching via screwdriver is considered docking under the system logs F3. I don't think docking is a requirement. You could also just nudge it into a cargo bay and safely return it to Kerbin. Then you can hit Recover vessel button in the tracking station, to recover the pieces individually. I'll try to get you a save file if you really need it. Are you developing your own version of KIS/KAS or are you one of the guys maintaining the mod?

[IgorZ]

4 hours ago, sardia said:

KAS/KIS attaching via screwdriver is considered docking under the system logs F3. I don't think docking is a requirement.

When KIS is attaching something it's considered docking ("coupling", to be more specific) from the game's perspective. In the game code I've found a script which controls "recover asset" missions, it may or may not require docking depending on the mission. Anyways, this script is explicitly checking for the part destruction, and if it's get destructed the mission fails. Since there is no way to change built-in scripts the only option is somehow workaround a situation when part is destroyed by the KIS script.

You could also just nudge it into a cargo bay and safely return it to Kerbin. Then you can hit Recover vessel button in the tracking station, to recover the pieces individually. I'll try to get you a save file if you really need it.

Cargo bay works differently from KIS. In cargo (and service) bay parts are physically present, i.e. they don't get destroyed/recreated when you move move them in and out. In KIS what you see in the inventory is just a list of names, no physical parts are present unless you move one out. It's a principle solution in the add-on so, it cannot be changed without redoing the whole concept. The save file will be helpful to find a way of detecting quest parts.

Are you developing your own version of KIS/KAS or are you one of the guys maintaining the mod?

For now it's my own version (a GitHub fork, to be more exact). I tried to reach the original author to get my changes incorporated into the main branch but in the last 3 weeks there was no response (may be due to the holidays).

[sedman]

Could I get some advice please?

How do I put a spanner, hammer or drill back into my inventory or pick up anything thats floating?
I can grab things, but I cant work out how to put them back into my inventory.

Before I try and pick up that spanner and drill I left in orbit, I'd like to know the best way to pick them up?

 

TIA.

 

[V8jester]

1 hour ago, sedman said:

Could I get some advice please?

How do I put a spanner, hammer or drill back into my inventory or pick up anything thats floating?
I can grab things, but I cant work out how to put them back into my inventory.

Before I try and pick up that spanner and drill I left in orbit, I'd like to know the best way to pick them up?

 

TIA.

 

Grab the item and hold the left mouse button, drag the item into the open inventory window (Tab key) and let go of the mouse button. The item will now be in your inventory.

[Fair_Player[PL]]

Thank you for this addon/update. It would be nice to have posibility to use EAS-4 Strut Connector in KIS. I would like to tie up two space craft on orbit with EAS-4 Strut Connector.

[goldenpsp]

1 hour ago, Fair_Player[PL] said:

Thank you for this addon/update. It would be nice to have posibility to use EAS-4 Strut Connector in KIS. I would like to tie up two space craft on orbit with EAS-4 Strut Connector.

They don't work.  Use the Strut connectors from the associated KAS mod.

[Snarfster]

On 12/26/2015 at 10:49 PM, sardia said:

You arrest movement with a container. If you remove the parachute from the nose cone. Example.

This leaves an open node. Attached rescued part(usually the command module of the kerbal you rescue). Replace nose cone. Fly to next rescue mission. Attached rescued part by repeating previous steps as needed. If you're good with RCS, you don't need the container, but you may need to juggle the attachment points around to make sure your ship is still stable enough for reentry.

 

Why not use KIS to attach a dockingport junior to the part you need to return? Then dock with it and fly it back. With the node attach option it'll be perfectly balanced too.

[sardia]

Can you explain how that is better than just attaching the parts directly? You'd be carrying 2 docking ports per rescue, and have to go through docking. It's easier to just attach the rescued part to your rocket and be done