visual bug : parts proportions off when reverting to launch

[z26]

KSP Version: windows 1.0

What Happens: parts proportions off when reverting to launch

Mods / Add-Ons: All Stock

Steps to Replicate:

1) Make a small rocket like in the first image below (battery, probe core, nosecone, small srb all 1.25m)

(important : the srb must be the root part for it to work!)

2) Launch

3) Revert to Launch

Result: The ship will look like the one in the second picture

Fix: Revert to vab instead of reverting to launch

before:

after:

[sal_vager]

Can't reproduce it here, have you had tweakscale installed in the past?

Also please post your game logs

[pellinor]

I can reproduce it.

* Virgin 1.0 install, unpack ksp-linux-1.0.0.zip, start new sandbox.

* Build craft: Flea booster as root(important), mk1 pod on top.

* Launch (so the flight scene starts and it sits on the pad)

* Revert to launch. Now the booster is too small, just like in the above picture.

The same thing happens if I quicksave and quickload instead of reverting to launch.

When tinkering with tweakScale I made the observation that the value/object

part.transform.GetChild(0).localScale;

for the root part seems to behave differently on launch compared to revert-to-launch/quickload.

When I write it on vessel load,

part.transform.GetChild(0).localScale = (someValue);
part.transform.GetChild(0).hasChanged = true;
part.transform.hasChanged = true;

everything is fine on launch and for non-root parts. But on revert-to-launch or quickload the value for the root part gets reverted to 1.0, which reverts the size of the visual model, and the camera bug is triggered.

My theory is that the common factor is localScale!=1.0, which is first set to the right value and then overwritten by some default. The additional bad things in TweakScale's case are probably connected to setting the hasChanged flags.

Edited April 27, 2015 by pellinor

[sal_vager]

Got it, KSP is getting the scale wrong on revert, it's a bug and should be reported to the public tracker

Also, so cute!

[z26]

Well, thanks pellinor for explaining it better than I could

[pellinor]

There should be a related bug report by biotronic on the tracker, I just can't find it now.

[Claw]

This bug has been around a while. You can find a fix for it here: http://forum.kerbalspaceprogram.com/threads/96339

I don't know if it's compatible with 1.0.

Cheers,

~Claw

[pellinor]

I just hope they fix the underlying code issue this time, and not just tweak the cfg to avoid the use of rescaleFactor.