can someone please look over the code for my first ever plugin. I dont want to break the game.

[MrMcMuffin]

_____________________________________________________________________

1. using UnityEngine;
   
2. using System;
   
3. using System.Timers;
   
4. 
   
5. namespace MachGuage
   
6. {
   
7. public class MachGuage : Plugin
   
8. {
   
9. private static Timer aTimer;
   
10. 
    
11. aTimer.Tick //this hopefully will do all the calculations for converting m/s to mach
    
12. {
    
13. MachNumber = (this.Velocity * 0.0029411764705882);
    
14. {
    
15. Round(MachNumber);
    
16. }
    
17. }
    
18. private Rect _windowposition = new Rect();
    
19. private GUIStyle _windowStyle, _labelStyle;
    
20. private bool _hasInitStyles = false;
    
21. 
    
22. 
    
23. public override void OnStart(StartState state)
    
24. {
    
25. aTimer = new System.Timers.Timer(20)
    
26. aTimer.Enabled = true;
    
27. if (state != StartState.Editor),
    
28. {
    
29. if (!_hasInitStyles) InitStyles();
    
30. RenderingManager.AddToPostDrawQueue(0, OnDraw);
    
31. }
    
32. }
    
33. 
    
34. private void OnDraw()
    
35. {
    
36. if (this.vessel == FlightGlobals.ActiveVessels)
    
37. _WindowPosition = GUILayout.Window(10, _windowPosition, OnWindow, "Mach Guage")
    
38. }
    
39. 
    
40. Private void OnWindow(int windowId)
    
41. {
    
42. GUILayout.BeginHorizontal(GuiLayout.Width(100f));
    
43. GUILayout.label(aTimer.Tick = MachNumber);
    
44. if (MachNumber == 0)
    
45. {
    
46. GUILayout.Label("You are not moving. and now the guage is bored");
    
47. }
    
48. GUILayout.EndHorizontal();
    
49. 
    
50. GUI.DragWindow();
    
51. }
    
52. 
    
53. prvate void InitStyles()
    
54. {
    
55. _windowStyle = new GUIStyle(HighLogic.Skin.Window);
    
56. _windowStyle.fixedWidth = 100f
    
57. 
    
58. _labelStyle = new GUIStyle(HighLogic.Skin.label);
    
59. _labelStyle.stretchWidth = true;
    
60. 
    
61. _hasInitStyles = true;
    
62. }
    
63. }
    
64. }
    
65. the copy from pastebin messed up the brackets and stuff sorry about that
    
66. _______________________________________________________________________________________________
    This is supposed to be a mach gauge, and my first time doing anything with C#. If you revise it will you please send me the code via private message. You will be given credit for your help when i eventually release the plugin. by the way, I would like integration with the default toolbar so i dont have to make a part.
    Thanks,
    Ryan:D:D
    

[MrHappyFace]

All of it seems fine except this:

1. private static Timer aTimer;
   
2. aTimer.Tick //this hopefully will do all the calculations for converting m/s to mach
   
3. {
   
4. MachNumber = (this.Velocity * 0.0029411764705882);
   
5. {
   
6. Round(MachNumber);
   
7. }
   
8. }
   

You should just use the OnUpdate() method like this:

1. public override void OnUpdate ()
   
2. {
   
3. MachNumber = (this.Velocity * 0.0029411764705882);
   
4. Round(MachNumber);
   
5. }
   

Also, you should extend PartModule, not Plugin. Plugin isn't even a class.

Also, are you using an IDE like MonoDevelop/Xamarin Studio or Visual Studio, or are you just using Notepad, because you should be using an IDE.

Edited May 29, 2015 by MrHappyFace

[MrMcMuffin]

Thanks so much MrHappyFace, I'm about to transfer it to an IDE. should this work without a part, and how do i get it on the toolbar

[MrHappyFace]

If you want it without a part, then do something like this:

[KSPAddon(KSPAddon.Startup.Flight, false)]  //this spawns your addon seperate from any part. Can run in any game scene including the loading screen, the main menu, the editor, and in flight
public class MachGauge : MonoBehaviour   //Read up on the unity documentation for MonoBehaviour [URL="http://docs.unity3d.com/ScriptReference/MonoBehaviour.html"]here[/URL]
{
    //replace OnStart(StartState state) with Start()
    //replace OnUpdate() with Update()
    //use FlightGlobals.ActiveVessel instead of vessel or part
}

And for the toolbar, use the official documentation: http://forum.kerbalspaceprogram.com/threads/86682-Appilcation-Launcher-and-Mods

[NathanKell]

Also, parts and vessels already have mach numbers (vessel.mach and part.machNumber) you don't have to (and shouldn't*) calculate it yourself.

*I mean, you could. But if you do, you'll need to calculate the speed of sound, first.

[MrMcMuffin]

You are right nathan. I wont be calculating a single damn thing. Thanks. Here the revised label code

Private void OnWindow(int windowId)

{

GUILayout.BeginHorizontal(GuiLayout.Width(100f));

GUILayout.label(vessel.mach);

}

[MrMcMuffin]

Also, parts and vessels already have mach numbers (vessel.mach and part.machNumber) you don't have to (and shouldn't*) calculate it yourself.

*I mean, you could. But if you do, you'll need to calculate the speed of sound, first.

By the way you gonna update real solar system any time soon

[Crzyrndm]

That code won't actually work, you need to close any layout groups (ie. you're missing a GUILayout.EndHorizontal()). There's a simpler way to do it aswell:

private void OnWindow(int windowId)
{
      GUILayout.label(vessel.mach.ToString(), GUILayout.Width(100f));
}

EDIT

Formatting would probably be useful as well

private void OnWindow(int windowId)
{
      GUILayout.label(vessel.mach.ToString("0.000"), GUILayout.Width(100f)); // prints a number rounded to 3dp in a label 100 units wide
}

Edited May 31, 2015 by Crzyrndm

[MrMcMuffin]

Good news guys, the mod is finished. thanks for all the help and support.