PartModuleList.Contains and Game mode

[Crzyrndm]

1) PartModuleList.Contains

I recently ran into an issue with Filter Extensions whereby a part module calling Destroy() on itself during it's awake sequence resulted in exceptions when part.Modules was queried with a string or int parameter.

// breaks
part.Modules.Contains("PartModule");
part.Modules.Contains("PartModule".getHashCode());
// works
part.Modules.Contains<PartModule>();

Which is all well and good, except querying by string/int is rather necessary for non-stock modules

My solution currently is to check against PartModule.GetType().Name, but I was wondering if there was any other ways that I should be looking at (particularly since the module type check is probably the most frequently used for FE by a good stretch). I'd be particularly interested in a solution that allows for derived classes like the typed check above (ie. how Contains<ModuleEngines>() also catches ModuleEnginesFX) because it'd be nice to have consistency with the stock modules (and my current method for going from a string to typed check for stock is a PITA to maintain...)

2) Game mode

How do we tell when the game is a scenario/training module?

Edited May 7, 2016 by Crzyrndm

[anxcon]

Type type = AssemblyLoader.GetClassByName(typeof(PartModule), name)

can convert name to the type used for makin the partmodule, then check if type in list

[stupid_chris]

19 hours ago, Crzyrndm said:

1) PartModuleList.Contains

I recently ran into an issue with Filter Extensions whereby a part module calling Destroy() on itself during it's awake sequence resulted in exceptions when part.Modules was queried with a string or int parameter.

// breaks
part.Modules.Contains("PartModule");
part.Modules.Contains("PartModule".getHashCode());

Which is all well and good, except querying by string/int is rather necessary for non-stock modules

I've never had any problem at all with these methods, whatsoever. What exactly is breaking?

[Crzyrndm]

tl;dr A PartModule calling Destroy inside its awake function

[stupid_chris]

2 minutes ago, Crzyrndm said:

tl;dr A PartModule calling Destroy inside its awake function

uh, are you using OnAwake? Because putting an Awake function in a custom partmodule breaks it.

[Crzyrndm]

Not mine, RPM is the one causing the issues (or rather mods that haven't updated to match RPM yet)

Edited May 8, 2016 by Crzyrndm

[stupid_chris]

11 minutes ago, Crzyrndm said:

Not mine, RPM is the one causing the issues (or rather mods that haven't updated to match RPM yet)

That is... odd. At this point I guess you could nearly work with a very specific exception for this case, else I believe this walks into the realm of reflection