Stockalike RF Engine Configs v3.2.6 [01/20/19][RF v12]

[Raptor831]

Ok all, the configs are updated to a new version. OP is updated, and there's a pull request submitted on CKAN's side to update the name within that app. If you've been using the updates from the repo, the only big difference is that I updated ModuleRCSFX to v3.5. If you haven't updated since v2.0.6, there's a lot of file changes, which are mostly organizational. The new generator causes a few calculations to be slightly different, but nothing that's way out of whack. Generally, nothing about your current flights should change (since most of the engine data is persistent). Can't guarantee it, as always, so make backups if Jeb needs to come home.

Let me know if you find any other issues/bugs/oddities.

[saabstory88]

Now that we have grid-fins on the LazTek spacex stuff, should not the Merlin 1-D get the correct number of restarts so we can perform landing maneuvers? I am having trouble figuring out exactly how many it is rated for, but it would need to have at least four for proper boostback, deceleration, and landing. I know it's an easy config to fix, but maybe just something to keep in mind during the next release?

[Raptor831]

Now that we have grid-fins on the LazTek spacex stuff, should not the Merlin 1-D get the correct number of restarts so we can perform landing maneuvers? I am having trouble figuring out exactly how many it is rated for, but it would need to have at least four for proper boostback, deceleration, and landing. I know it's an easy config to fix, but maybe just something to keep in mind during the next release?

Ah, yes, that probably should be looked at. I don't play with the Engine Ignitor mod (yet) so the restarts tend to slip past... Thanks for the reminder.

[Canis Dirus Leidy]

Let me know if you find any other issues/bugs/oddities.

Looks like something wrong with "convert all monopropellant to hydrazyne" configs. As a result command pods (with cockpits and landers) lost all internal electric charge and EngineerRedux thinks that pod lost almost all it's mass:

(Screenshot was made on Linux 64bit version without any mods except RealFuels, ModuleRCSFX (from engine configs archive bundle), Kerbal Engineer Redux and ModuleManager).

[Tellion]

Can confirm the issue with seemingly massless pods, same version of KSP and same OS, interestingly enough.

[Raptor831]

Ok, I've made a change to the Fuel_Conversion.cfg file. It should prevent any pods from being change to near-zero mass. I had TACLS installed, which had placed MFTs in the pods already which kept this from happening. Let me know if it fixes the error. You can download the single file here: https://raw.githubusercontent.com/Raptor831/RFStockalike/master/GameData/RealFuels/Fuel_Conversions.cfg Or just download the whole repo if you'd rather.

Once I confirm that this goes away for you all, I'll make a proper release.

[Tellion]

It goes away for me, so thanks for that!

Edit: though it also does seem to remove all fuel tanks from command pods, not sure if intended.

Edited January 25, 2015 by Tellion

[Raptor831]

It goes away for me, so thanks for that!

Edit: though it also does seem to remove all fuel tanks from command pods, not sure if intended.

It removes the fuel tanks on purpose, because that's what changes the mass. If the pod has MonoPropellant it should turn it into a Service Module tank with the appropriate volume, but it'll leave it alone otherwise.

EDIT: Release is up with these fixes (plus some extras thanks to Tellion). Also, do note that if you still have Mono_to_Hydrazine.cfg in your /GameData/RealFuels/ folder, you should delete it. I don't believe it'll mess anything up, but it's been replaced with a different file. Merging folders will not overwrite it.

Edited January 25, 2015 by Raptor831

[Tellion]

Well, pods like the MK1 or MK1-2 which did previously have monopropellant (then servicemodule tanks with rf) dont have any now ._.

Maybe I still have something old lying around somewhere, I will see if it also happens on a clean install.

Edit: Alright, so with 2.1.1 I get correct weights but no fuel whatsoever in the pods, with 2.1.0 I get real fuels servicemodule tanks but no weights, and with 2.0.6 I get correct weights and Hydrazine as a replacement for Monoprop, but no servicemodule tanks.

Edited January 25, 2015 by Tellion

[Raptor831]

Well, pods like the MK1 or MK1-2 which did previously have monopropellant (then servicemodule tanks with rf) dont have any now ._.

Maybe I still have something old lying around somewhere, I will see if it also happens on a clean install.

Edit: Alright, so with 2.1.1 I get correct weights but no fuel whatsoever in the pods, with 2.1.0 I get real fuels servicemodule tanks but no weights, and with 2.0.6 I get correct weights and Hydrazine as a replacement for Monoprop, but no servicemodule tanks.

Ugh. Well, it helps if the syntax is right. Or at least close. And maybe the right Module. Sheesh, that was a boneheaded bug added by myself. You can see the changes on GitHub, but I was nowhere close to the right syntax!

It should create the fuel tanks now instead of nuking any MonoProp it finds. Let me know if that works!

[Tellion]

We all have those days :3

No more autogenerated TAC tanks in the right proportions, but the servicemodule tanks are functioning - and leaving space for life support as well. Thanks Raptor!

[Raptor831]

We all have those days :3

No more autogenerated TAC tanks in the right proportions, but the servicemodule tanks are functioning - and leaving space for life support as well. Thanks Raptor!

Good to hear. I'm going to see if I can have two sets of tanks (or at least merge them), though. Overwriting the LS tanks bugs me, since it's all so precise.

EDIT: Updated the repo with a new release, also should now keep the old MFTs if they exist.

Edited January 28, 2015 by Raptor831

[Tellion]

I'm going to see if I can have two sets of tanks (or at least merge them), though. Overwriting the LS tanks bugs me, since it's all so precise.

That would indeed be awesome

On another note, can anyone try to see if RPM works with the latest version of RF and those configs? It broke for me, and I have nailed it down to the stockalike configs - though I have no idea how they could be hurting RPM :/

I can reproduce it on a clean install with RealFuels, stockalike configs and ModuleRCSFX, OS is linux ubuntu, KSP is 64bit.

[Raptor831]

That would indeed be awesome

On another note, can anyone try to see if RPM works with the latest version of RF and those configs? It broke for me, and I have nailed it down to the stockalike configs - though I have no idea how they could be hurting RPM :/

I can reproduce it on a clean install with RealFuels, stockalike configs and ModuleRCSFX, OS is linux ubuntu, KSP is 64bit.

The master branch on the repo has the tank "fixes" if you want to test them. I think they'll work, but we'll see.

As for RPM, I don't know why it would have a problem with Stockalike. If you remove Stockalike, RPM works properly?

[Nerezza]

It's very late for me (is that the sun coming up?!), so I have to apologize that I can't check into those other fixes that are on the github to make sure I'm not redoing someone else's work here, but I immersed myself into MM and learned a bunch of neat tricks so I could get TACLS to work alongside the stockalike configs, while also letting me have my serviceModule tank types in capsules AND pre-distributed life support (including a couple hours of electricity!)

First off, delete (or rename to .cfgbkp) two files in the TACLS folders:

TacLifeSupport\MM_StockPartChanges.cfg (this only adds more electricity to command modules for life support, enough to sustain roughly 2 hours without solars.)

TacLifeSupportMFT\MM_AddResources.cfg (this makes command modules use the TACLS defined LifeSupportAll tank type, but we really need the serviceModule type added for most pods)

Next up, go to Fuel_Conversions.cfg and replace this:

@PART
[*]:HAS[@MODULE[ModuleCommand],@RESOURCE[MonoPropellant]]:NEEDS[RealFuels]:Final{
    MODULE
    {
        name = ModuleFuelTanks
        volume = 0        // creates a blank volume for utilization
        @volume = #$/RESOURCE[MonoPropellant]/amount$        // searches for previous amount of MonoPropellant to use as volume
        @volume *= 5        // multiplies by 5
        type = ServiceModule        // this is best type to use for RCS tanks, holds more specialized stuff like Hydrazine
        basemass = -1
    }
    !RESOURCE[MonoPropellant]        // removes old MonoPropellant resources
    {
    }
}

With this:

@PART
[*]:HAS[@MODULE[ModuleCommand],@RESOURCE[MonoPropellant]]:NEEDS[RealFuels],![TacLifeSupport]:Final{
    MODULE
    {
        name = ModuleFuelTanks
        volume = 0        // creates a blank volume for utilization
        @volume = #$/RESOURCE[MonoPropellant]/amount$        // searches for previous amount of MonoPropellant to use as volume
        @volume *= 5        // multiplies by 5
        type = ServiceModule        // this is best type to use for RCS tanks, holds more specialized stuff like Hydrazine
        basemass = -1
    }
    !RESOURCE[MonoPropellant]        // removes old MonoPropellant resources
    {
    }
}
@PART
[*]:HAS[#CrewCapacity
[*],~CrewCapacity[0],@MODULE[ModuleCommand],!MODULE[ModuleFuelTanks],!RESOURCE[MonoPropellant]]:FOR:[TacLifeSupport],[RealFuels]:Final
{
    @RESOURCE[ElectricCharge]
    {
        @maxAmount = 100
        @maxAmount *= #$/CrewCapacity$
        @maxAmount += 150
        @amount = #$maxAmount$
    }
    MODULE
    {
        name = ModuleFuelTanks
        volume = 3.549
        @volume *= #$../#CrewCapacity$
        type = LifeSupportAll
        basemass = -1
    }
}
@PART
[*]:HAS[#CrewCapacity
[*],~CrewCapacity[0],@MODULE[ModuleCommand],@RESOURCE[MonoPropellant]]:FOR:[TacLifeSupport],[RealFuels]:Final
{
    MODULE
    {
        name = ModuleFuelTanks
        volume = 0        // creates a blank volume for utilization
        @volume = #$/RESOURCE[MonoPropellant]/amount$        // searches for previous amount of MonoPropellant to use as volume
        @volume *= 5        // multiplies by 5
        type = ServiceModule        // this is best type to use for RCS tanks, holds more specialized stuff like Hydrazine
        basemass = -1
        TANK
        {
            name = Food
            amount = full
            maxAmount = 3.549
            @maxAmount *= .309118
            @maxAmount *= #$../../#CrewCapacity$
            @maxAmount *= 100
            @maxAmount /= #$../volume$
            @maxAmount ^= :$:%:
        }
        TANK
        {
            name = Water
            amount = full
            maxAmount = 3.549
            @maxAmount *= .204314
            @maxAmount *= #$../../#CrewCapacity$
            @maxAmount *= 100
            @maxAmount /= #$../volume$
            @maxAmount ^= :$:%:
        }
        TANK
        {
            name = Oxygen
            amount = full
            maxAmount = 3.549
            @maxAmount *= .141507
            @maxAmount *= #$../../#CrewCapacity$
            @maxAmount *= 100
            @maxAmount /= #$../volume$
            @maxAmount ^= :$:%:
        }
        TANK
        {
            name = Waste
            amount = 0.0
            maxAmount = 3.549
            @maxAmount *= .028111
            @maxAmount *= #$../../#CrewCapacity$
            @maxAmount *= 100
            @maxAmount /= #$../volume$
            @maxAmount ^= :$:%:
        }
        TANK
        {
            name = WasteWater
            amount = 0.0
            maxAmount = 3.549
            @maxAmount *= .260188
            @maxAmount *= #$../../#CrewCapacity$
            @maxAmount *= 100
            @maxAmount /= #$../volume$
            @maxAmount ^= :$:%:
        }
        TANK
        {
            name = CarbonDioxide
            amount = 0.0
            maxAmount = 3.549
            @maxAmount *= .56759
            @maxAmount *= #$../../#CrewCapacity$
            @maxAmount *= 100
            @maxAmount /= #$../volume$
            @maxAmount ^= :$:%:
        }
        TANK
        {
            name = ElectricCharge
            amount = full
            maxAmount = 100
            @maxAmount *= #$../../#CrewCapacity$
            @maxAmount += 150
            @maxAmount *= 100
            @maxAmount /= #$../volume$
        }
    }
    !RESOURCE[MonoPropellant]        // removes old MonoPropellant resources
    {
    }
    !RESOURCE[ElectricCharge]        We don't need this thing lying around anymore, right?
    {
    {
}
@PART
[*]:HAS[#CrewCapacity[0],@MODULE[ModuleCommand],@RESOURCE[MonoPropellant]]:NEEDS[RealFuels]:Final
{
    MODULE
    {
        name = ModuleFuelTanks
        volume = 0        // creates a blank volume for utilization
        @volume = #$/RESOURCE[MonoPropellant]/amount$        // searches for previous amount of MonoPropellant to use as volume
        @volume *= 5        // multiplies by 5
        type = ServiceModule        // this is best type to use for RCS tanks, holds more specialized stuff like Hydrazine
        basemass = -1
    }
    !RESOURCE[MonoPropellant]        // removes old MonoPropellant resources
    {
    }
    !RESOURCE[ElectricCharge]        We don't need this thing lying around anymore, right?
    {
    {
}

Quick breakdown of what this changes:

-The old changes now only apply if the command module is an unmanned probe with Monoprop.

-Unmanned probes without monoprop don't get anything.

-Manned pods with no monoprop get tank type LifeSupportAll (at stock TACLS per kerbal distribution) and a boost in resource electric charge (not MFT/RF type EC so you can't modularly expand it into the life support container. Not like you have much room in that tank for it in the first place..)

-Manned pods with monoprop get the old changes AND the same initial resource quantities TACLS gives out per kerbal (once it vanquishes the maze of arithmetic and regex), along with the boosted Electric Charge stored inside the MFT/RF tank because you could always put that there anyway so why not? Furthermore, stocked graham treats are now automatically dumped into the honey reserves, as per Jebediah's request. No, this doesn't just mean the logistics team drop a package of graham treats into every honey bottle, where did you get that idea?

Edit:

Also, those two files I specify to delete are the cause of the incompatibility problems. If someone wants to just have entirely empty servicemodule type tanks in their pods, they can just delete the one trying to put lifesuportall in every pod!

Edited February 1, 2015 by Nerezza
Lost all carriage returns.

[Tellion]

As for RPM, I don't know why it would have a problem with Stockalike. If you remove Stockalike, RPM works properly?

Yes that was the case. After getting a new computer and trying to reproduce it with the same setup (and new downloads), everything worked just fine though, so I guess that is that.

EDIT:

Sigh, aand it is back. I had used the github version from RealFuels, which was lacking the .dll before. Tested again, RPM is working with RealFuels alone, but breaks as soon as the stockalike configs are installed :/

Edited February 1, 2015 by Tellion

[Nerezza]

Could you describe the way it's not working? Are the screens staying black, turning gray, or looking like the altimeter's normal map? Also, which pod are you using?

[Tellion]

Screens are staying black, no buttons shown and the ingame debug log gives "target is null" whenever a button is clicked. And it seems to affect all of the pods I'm afraid. Here is the player.log if that helps.

[Nerezza]

I spent a good long time reviewing your log and I'm pretty certain that the Stockalike configs aren't causing the problem. I've actually had this problem about a year ago myself, too!

I don't remember exactly what was wrong, but I'd somehow installed RPM wrong. I know if I were you, I'd hate to have someone tell me to do this but humor me at least: Delete your RPM stuff, everything including any 'aftermarket MFDs' and then download and reinstall MOARdV's bugfix'd version.

Edit: Also, if you're still having an issue after doing that, link me your ModuleManager.ConfigCache next time. It's in {KSP}\GameData for Windows and will let me be 100% certain that Stockalike isn't the cause of the problem.

Edited February 1, 2015 by Nerezza

[Tellion]

I would have told anyone having those issues the same things that you just told me, yet, unfortunately, I have reinstalled RPM more than one time. It is also working flawlessly up to the point of installing the stockalike configs, at which it breaks, until I remove them. I do not understand why it is doing that, but there definitively is a correlation there.

In the very same game that the logfile I posted is from, the only thing I had to do to get RPM working was delete the RealFuels folder and reinstall it (without engine configs). I could even use the same vessel ._.

As soon as I readd the stockalike configs in the very same game, it is dead once more. Here is the MM config cache, oh, and thank you very much for your help and patience, I know it can require quite the patience sometimes.

Edited February 1, 2015 by Tellion

[Nerezza]

Sorry about the long reply time, went out of the house for a bit. I've reviewed and double checked both of those. Your config cache comes out exactly as mine does (minus my extra mods) so there's little chance it's related to MM or MM .cfgs.

However, my next suggestion is to delete the stockalike configs 4 at a time (or however many you wish!) until the monitors work again, then figure out which of the latest causes them not to work.

Edit: Also, completely unrelated, that's a pretty neat avatar icon

[Tellion]

Aw, nothing to be sorry about at all!

Weird, so RPM is working for you without issues? Those are the worst kind of bugs.

Will do that tomorrow, I need a break from troubleshooting my hopelessly overmodded install ._.

And thank you very much

[Raptor831]

@Nerezza: I'm working on that exact problem, and came to the same conclusion. I'm just exploring any way I can get around not having to rename any files... B9 Aerospace also has a conflict with TACLS out of the box. Hopefully, I can figure something out. Might have to pull the Fuel_Conversion.cfg file out of the /RealFuels/ folder and stick it in the /GameData/ and rename it zzzFuel_Conversion.cfg or something to make sure it runs at the very end, and rebuild everything you need.

Also, thanks for the troubleshooting help.

Tellion: I haven't had any RPM issues (Mac OS X Yosemite, 32-bit KSP), so I'm a little stumped. Stockalike shouldn't even be touching anything to do with RPM, so I'm not sure what could be conflicting. The only difference I see is you're running 64-bit, but the Linux version is stable. I haven't studied your logs yet, so once I get a chance I'll look over those. I'm not great at reading them, honestly, but maybe something will jump out!

[Nerezza]

At first I was trying to overwrite the Fuel_Conversion.cfg's changes with TACLS stuff from a TACLS script. I thought I'd be able to remake the TACLS script, but the stockalike RF monoprop script always ran after the TACLS ones no matter what.

I think it you put !MODULE[ModuleFuelTanks] {} in front of the patches you're doing, then we won't need to bother with deleting or renaming the TACLS files.

I haven't noticed the B9 problem yet, but I've not been looking for one so that might be why!

[Tellion]

Alright, I got the culprit:

This section from the Fuel_Conversions.cfg

@PART
[*]:HAS[@MODULE[ModuleCommand],@RESOURCE[MonoPropellant]]:NEEDS[RealFuels]:Final
{
  MODULE
  {
    name = ModuleFuelTanks
    volume = 0                                      // creates a blank volume for utilization
    @volume = #$/RESOURCE[MonoPropellant]/amount$   // searches for previous amount of MonoPropellant to use as volume
    @volume *= 5                                    // multiplies by 5
    type = ServiceModule                            // this is best type to use for RCS tanks, also can hold LS resources
    basemass = -1
  }
  !RESOURCE[MonoPropellant]    // removes old MonoPropellant resources
  {
  }
}

Causes the RPM screens to go black. I have not the slightest idea why - maybe someone in the RPM thread does though, so I will ask there too.

Edit: Lol, got it, I should have followed the RPM thread while dealing with this. Its the batteries, apparently rpm refuses to work at all when there are none in the pod itself. Thanks for all the help everyone!

Edited February 2, 2015 by Tellion