[SOLVED] onCrewKilled and onKerbalStatusUpdate Help

[DJK]

Hi. I'm basically working on a simple plugin and i ran into this :

calling onCrewKilled or onKerbalStatusChange

void onCrewKilled(EventReport e)
        {
            Debug.Log("KSN onCrewKilled!");
        }

onKerbalStatusChange looks the same. Just a debug.log line to check when its called.

And i get this:

"[00:02:50]: Bill Kerman was killed.

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!"

Same applies for onKerbalStatusChange.. can someone explain why its running more than one time? and how do i get around this to call/run it only once? The test rocket is just a mk1 cmd pod + srb used to kill the kerbal.

onCrewKilled / onKerbalStatusChange is being called on Awake - and yes, i have no clue what i'm really doing since this is my 1st plugin and i've never tried C# before.

The plugin i'm trying to make should take funds when a kerbal dies (even by TACLS & when vessel is not focused, thats why i've hoped to use onKerbalStatusChange).. so i was gonna use so any ideas or tips are welcome!

Thank you!

Edited September 8, 2014 by DJK
Problem Solved

[xEvilReeperx]

It looks like it works as expected to me, called once for each Kerbal killed. Can you show more code? The phrase "onCrewKilled / onKerbalStatusChange is being called on Awake" makes me think you haven't registered the event in GameEvents or there's something else going wrong in your code

[DJK]

Thanks for the reply xEvilReeperx.

Here is the simple version of the code:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
//using System.Threading.Tasks;
using UnityEngine;
using KSP;

namespace DJK_KS
{
    [KSPAddon(KSPAddon.Startup.EveryScene, false)]
    public class KSN : MonoBehaviour
    {
        public void Awake()
        {
            GameEvents.onCrewKilled.Add(onCrewKilled);
        }

        private void onCrewKilled(EventReport e)
        {
            Debug.Log("KSN onCrewKilled!");
        }
    }
}

Which does this:

"[00:01:42]: Jebediah Kerman was killed.

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!

KSN onCrewKilled!"

Thats on a clean KSP install (no mods).. new game (sandbox this time) with no kerbal killed so far. Jeb was the first and only crew member on a mk1 pod + srb that died.. shouldn't "KSN onCrewKilled!" be called just once in debug? Like:

"[00:01:42]: Jebediah Kerman was killed.

KSN onCrewKilled!"

and not 14 times?

[FlynCow]

The Problem is that Awake() Gets executed Everytime the Scene changes, So your onCrewKilled(EventReport) Function gets registered Multiple times to the onCrewKilled Event.

The KSPAddon Constructor has a once Argument, true means it only gets executed once and false means it gets executed everytime your Startup argument happens.

[DMagic]

Is this what your log actually looks like (the line repeated 10 or so times), or does it continually print this?

If it repeats a certain number of times that's probably because you are registering the callback every time the scene changes, but never removing it.

Put this in your OnDestroy() method.

GameEvents.onCrewKilled.Remove(onCrewKilled);

[DJK]

The Problem is that Awake() Gets executed Everytime the Scene changes, So your onCrewKilled(EventReport) Function gets registered Multiple times to the onCrewKilled Event.

The KSPAddon Constructor has a once Argument, true means it only gets executed once and false means it gets executed everytime your Startup argument happens.

Changing the argument to true worked as a charm

Putting this:

GameEvents.onCrewKilled.Remove(onCrewKilled);

in OnDestroy() method had no effect.

Thank you for the help guys, i really appreciate it!