Sargon

Yeah, it was confusing, especially since I was coming at it from the wrong direction for 95% of the time. Now that I know how it works, I'll try to keep an eye out to make sure there aren't any subtle failure states. Also, a question. Why is the mass of the K&K Science Container 0.24 t, when the regular Science Jr. is 0.2 t? Since most of the other modular storage boxes are 0.2 t, having just this one part be 20% heavier gives me fits when trying to balance the COM of my bases. Finally, I noticed someone brought this up back in May, but the base ISRU still doesn't generate any heat. In its part config file, it's missing the ModuleCoreHeat that the stock ISRU has, and the resource-converter modules are all missing the relevant heat-efficiency information. I would submit a PR to fix this, but I don't know how it should be set. Maybe scale down the coolant requirements by 20%, since the other inputs/outputs are all scaled down by 20%?

OK, I think I've figured this out. The changes ModuleManager makes to the contracts only affect the code to generate new contracts, yes? If so, then the reason my contracts aren't working is simply that they were created before I installed ModuleManager correctly, so they're just missing the relevant lines that would get them to work. This explains why the "base has a science lab" requirement works for me with the KPBS lab, but the "base has a cupola" requirement doesn't. The science lab contract looks for the relevant module ("Module = ModuleScienceLab") as well as the relevant part name(s). So my pre-existing contracts already have a condition that I can satisfy with the KPBS science lab. But they don't have anything to point me to the KPBS cupola. My problem now is, why can't I seem to hack my save file to fix this? I've tried adding a line in the contract entries in my savefile: PARAM { name = PartRequestParameter state = Incomplete disableOnStateChange = False values = 0,0,0,0,0 article = a partDescription = viewing cupola vesselDescription = outpost partNames = cupola partNames = KKAOSS_Cupola_g // NEW LINE (w/o comment) } But as soon as I load the save file I've modified, it seems like the line gets stripped out. I can hack it by replacing the "partNames = cupola" line with "partNames = KKAOSS_Cupola_g", but obviously that disqualifies the regular cupola. If I change the line to "partNames = cupola,KKAOSS_Cupola_g", neither cupolas work, probably because it's looking for a part named "cupola,KKAOSS_Cupola_g". Basically, what's the syntax I should be using here for multiple possible partNames? EDIT: OK, I figured it out, by generating new missions that gave me the syntax I needed. The correct syntax is "partNames = cupola|KKAOSS_Cupola_g", with an OR operator separating the strings. I probably should have been able to guess this. Alas. Thanks for being patient with my noobish flailing!

Hmm. I'll give that a try. I'll also try the "CREW_REQUEST" style of things, if that doesn't work...Of course, I don't really expect either to work, given what my save file says about the contract. What else can I do to help...I could send you my save file if it'd be at all useful. Also, here's the relevant part of ModuleManager.ConfigCache: UrlConfig { name = Contracts type = Contracts parentUrl = Squad/Contracts/Contracts url = Squad/Contracts/Contracts/Contracts Contracts { ... Base { ... PART_REQUEST { Article = a PartDescription = viewing cupola VesselDescription = outpost Keyword = Commercial Part = cupola Part = KKAOSS_Cupola_g ... } ... } ... } ... } So, it looks like ModuleManager is doing its job, I guess. This (ModuleManager.ConfigCache) is where its handiwork should show up, right (i.e., it's correct that such part-name additions aren't in the save file)? One last thing I noticed. The relevant part name in the ModuleManager stuff is "KKAOSS_Cupola_g", but in my save file, the part name of the part that's actually on the ship is "KKAOSS.Cupola.g". Could this discrepancy between periods and underscores be the culprit here? As proof, the relevant bits of my save file are thus: VESSEL { pid = 528d31a35b1449b4b56b76744a150739 name = Mun Base IV type = Base sit = LANDED landed = True landedAt = KSC splashed = False ... PART { name = KKAOSS.Cupola.g cid = 4294630568 uid = 1345647911 mid = 1404075681 launchID = 199 parent = 28 position = 0,-7.09027481079102,8.45226509227359E-07 rotation = 0,0,-1,0 mirror = 1,1,1 symMethod = Radial ...blah blah blah... connected = True attached = True flag = Squad/Flags/kerbal2 rTrf = KKAOSS.Cupola.g modCost = 0 crew = Jebediah Kerman ...modules and such... } ... }

Any progress on this? I tried making a modification to the config file along these lines, but it didn't seem to work: //Add the planetary cupola to satisfy the base contracts @Contracts { @Base { @PART_REQUEST:HAS[#Part[cupola]] { Part = KKAOSS_Cupola_g } } @BaseContract { @PART_REQUEST:HAS[#Part[cupola]] { Part = KKAOSS_Cupola_g } } }

Yeah, I have that file (/PlanetaryBaseInc/ModSupport/Configs/Contracts/KPBS_MM_Contracts.cfg), and I have ModuleManager installed. For the record, the relevant part of the config file is: //Add the planetary cupola to satisfy the base contracts @Contracts { @Base { @PART_REQUEST:HAS[#Part[cupola]] { Part = KKAOSS_Cupola_g } } } So, it shouuuuuld work...theoretically

Hey, I've been having a persistent problem with contracts and KPBS. The game doesn't seem to recognize the planetary cupola as a valid viewing cupola for build-a-base contracts. Any idea what's going on here? Log file Craft that should satisfy the mission Contract details from my safe file: CONTRACT { guid = 87df304b-7ae6-43a6-8e4f-0722ebeac328 type = BaseContract prestige = 0 seed = -1495600375 state = Active agent = WinterOwl Aircraft Emporium deadlineType = Floating expiryType = Floating values = 63219.5137023926,125680393.240356,84507.0397853851,224295.757911085,94499.9957084656,0,26.24341,17.47573,22413416.3910526,22406722.989627,148087116.229983,0 targetBody = 2 capacity = 5 contextual = False PARAM { name = LocationAndSituationParameter state = Incomplete disableOnStateChange = False values = 0,0,0,0,0 targetBody = 2 targetSituation = LANDED noun = outpost finalObjective = False } PARAM { name = VesselSystemsParameter state = Incomplete disableOnStateChange = False values = 0,0,0,0,0 typeString = outpost mannedStatus = 2 requireNew = True checkModuleTypes = Antenna|Power|Dock checkModuleDescriptions = has an antenna|has a docking port|can generate power launchID = 198 } PARAM { name = CrewCapacityParameter state = Incomplete disableOnStateChange = False values = 0,0,0,0,0 targetCapacity = 5 } PARAM { name = PartRequestParameter state = Incomplete disableOnStateChange = False values = 0,0,0,0,0 article = a partDescription = viewing cupola vesselDescription = outpost partNames = cupola } PARAM { name = StabilityParameter state = Incomplete disableOnStateChange = False values = 0,0,0,0,0 holdSeconds = 10 } }