jhxmt
Members-
Posts
4 -
Joined
-
Last visited
Reputation
2 Neutral-
[1.12.x] - Modular Kolonization System (MKS)
jhxmt replied to RoverDude's topic in KSP1 Mod Releases
Haha, that was my backup plan, but turns out the (old) construction ports do indeed connect to the (new) docking ports, as long as they're the right size - I was just messing up my docking approach. A bit more care and some fiddling with the force settings on the ports got them to match up eventually. Noted, thanks - indeed, by the time I'd worked out how to do a PR the issue in question had already been addressed in another one, but it was a learning experience for me! If I come up with any other suggested fixes etc I'll make sure to do any future PRs from the develop branch, thanks! -
[1.12.x] - Modular Kolonization System (MKS)
jhxmt replied to RoverDude's topic in KSP1 Mod Releases
Quick question: noted that construction ports are being made obsolete (being replaced by docking ports being given the same functionality, which is great). If I've already got (now obsolete) construction ports on a craft, will they be compatible with the new docking ports that replace their functionality? I assume from brief testing that the answer is no (which is a pain as it means I can't extend my existing LKO station any further now, but understandable). -
[1.12.x] - Modular Kolonization System (MKS)
jhxmt replied to RoverDude's topic in KSP1 Mod Releases
Thanks - done! (First pull request I've ever done on a non-solo-developer repo, so apologies if I've done it in a less-than-efficient manner, the git workflow still trips me up sometimes). -
[1.12.x] - Modular Kolonization System (MKS)
jhxmt replied to RoverDude's topic in KSP1 Mod Releases
Loving the new shipyard look. I've identified a (minor) bee in the current latest release with one of the WOLF parts - the 3.75m WOLF Crew Cargo Kontainer appears to have accidentally have been defined as a WOLF Cargo Kontainer instead (which means it appears as a kontainer with a Payload of 1, as opposed to what it should have which is Economy Berths of 14 and Luxury Berths of 7). From looking through Github, I think this is just due to a mistyped line 59 in CrewCargoKontainer_375.cfg (which should read "name = WOLF_CrewCargoModule" instead of "name = WOLF_CargoModule") I'm not particularly au fait with Github, but I do have an account (which I've not used for years). What's the easiest way for me to propose the change on there? Fork and then pull request? I don't want to create unnecessary admin work for anyone if there's an easier/better way.