SabertoothMosquito

It's named "fix for Airbags" under FluffyLogic, has an ID e483027. I'm new to this. I understand the basics but "pull request" vs "issue" vs... confuses me. I tried to look for a guide from creating account to posting a fix in someone else's repository but had no luck. All info is chopped up in little pieces and i didn't figure out how they fit as a whole. I had hoped desktop client would do it for me. It listed in the client, but i too can't see it in web version with browser.

Fix for airbags has been sent to github repository, i just installed github desktop - it worked right out of the box !

That was quick ! Thanks !

Bug re-report. Back in KSP 1.2.2 airbags added to any horizontally moving craft caused loss of speed at roughly 50 m/s. That meant any aircraft or SSTO that needs over 50 m/s to take off couldn't launch. There was a issue placed at github page for Exploration pack that addressed this bug with a solution to check for deploy boolean value inside airbag module and that solved the problem. The airbag module simply removed speed from craft without checking if airbag was deployed or not. Now this bug has re-appeared and i haven't found a github page for this pack containing actual visual studio project with sources so can't even recompile/fix this myself, let alone re-post the bugfix. Paging @RoverDude about location of sources for Exploration Pack at github, PLEASE reply !

I want to add support for sounds to play along with animations. My plugin is nearly done (although it is completed if considering it's basic purpose). The usual method of adding audio effects to part cfg isn't going to satisfy the complexity of animations my plugin can perform. Problem is that my plugin reads larger chunks of cfg data and using EFFECTS node is incompatible with my part config format for my plugin and is too bulky. My plugin uses multiple named arguments in line, and multiple lines in sequence to perform tasks. I'd need to accompany each of those lines with a sound effect. As there can be any number of lines inside any number of sequences, the space used by EFFECTS node would be huge and too bulky to handle efficiently. There are many plugins for specific purpose that perform animations and have no sounds, and i haven't seen any complaints about that. Note that i may reply later today, but due to work mostly likely tomorrow.

My animation plugin development has reached another phase : adding sound effect support to animations. More precisely, is sound fx really needed in KSP plugin ? Is absence of it a minor annoyance or game-immersion-breaking bug ? Note that my plugin is intended for animating various parts that are (at least for now) used as structural or aerodynamics parts (resource capacity/usage support may be added later, its on a backburner for now). Also note that due to nature of my plugin, i can't use normal EFFECTS node setup for audio.

I need sound files for my part / plugin - and i couldn't find links in this forum i had found before. Any help ? Specifically, i'm looking for sounds of hydraulics (i had some luck finding a few promising sources) and a heavy door slamming sounds (as clean as possible from any echoes, this is a tough one for me). Some sci-fi versions are also welcome. I need them for sound of hydraulics driving a large metallic gate or door (that has a single rumbling thump). Also, if anyone has info on sound creation - used software, education and similar - i'd be thankful.

Another update. Hope this closes the issue. My previous source example may look functional but it is essentialy flawed. Although craft's ConfigNode contains info on action groups (either auto pre-assigned or user-defined), they should be maintained by game itself, no tinkering should be done in OnSave() / OnLoad() phase (unless some more magic need be done ). I've found way to make action groups in runtime and maintain their persistence between various scenes. Note if runtime action groups are not found by game they won't be listed and available to user. Use of OnStart () to create action groups is wrong for flight scene. It is too late and interestingly, only works for custom-assigned action groups. However, using OnAwake() also solves this for persisting pre-built action groups (abort,sas,rcs, stage etc) as this event fires early enough to create runtime action groups before game starts trying to match them to vessel config inside persistence.sfs. Example code public override void OnAwake () { string guiName = "Name Displayed To Player"; string validIdentifierName = "runtimeAction"; //make your choice from below. //note the "custom" is assigned to None by default so user can later decide string choice = ""; KSPActionGroup group = KSPActionGroup.None; switch (choice) { case "abort": group = KSPActionGroup.Abort; break; case "gear": group = KSPActionGroup.Gear; break; case "light": group = KSPActionGroup.Light; break; case "sas": group = KSPActionGroup.SAS; break; case "rcs": group = KSPActionGroup.RCS; break; case "stage": group = KSPActionGroup.Stage; break; case "custom": group = KSPActionGroup.None; break; default : group = KSPActionGroup.None; break; } //note in next line that last parameter is "isPersistent" bool set to "true" ! KSPAction ksp_action = new KSPAction(guiName,group,false,true); BaseAction base_action = new BaseAction(Actions,validIdentifierName, (a) => { ScreenMessages.PostScreenMessage("Your runtime action has fired !"); },ksp_action); Actions.Add(base_action); }

Thanks for this, i did more tests and Time.time appears to be affected by physics warp only. Planetarium.GetUniversalTime() does respect both warp modes. Hmmm... I just tested stock cargo bay. Animation playback speeds are affected by physics warp only. A compromise or a bug, i can't tell. Another thing about gameplay : when high-speed (on-rails) warp is active, part menu buttons (defined with [KSPEvent] attribute in plugin) are not available, preventing players from activating animations that make parts move in this warp mode. Can you imagine a 15 second animation accelerated by 10000x warp ? To me it looks more and more like a compromise. Interestingly, action groups are not affected, so player could still execute them.

Sigh... I've come up with this, i just don't know if Time.time is the correct source (or the ONLY source of timing info, besides MET) public float scaledTime { get { return Time.time * Mathf.Max(Time.timeScale,TimeWarp.CurrentRate); } } After testing i've concluded that Time.timeScale is for physics warp and TimeWarp.CurrentRate is for high-speed physics-less warp. Also note that rate changes between two steps are gradual.

I need to know how to properly manage timing during physics warp and high-speed warp (the non-physics variety). Timing is required for my animations. I can use Time.time under normal scale and it works ok, but i need a timing variable / method that reads game time and is affected by both warp types. Note that MET is not acceptable since it does not run while vessel is landed.

More problems and ... more questions. I've discovered that i've made a mistake in above example code. The line with "new BaseAction(Actions,"name of action"" ... etc should have "name of action" string as valid identifier for C# and ConfigNode ie no whitespace whatsoever, no preceding numbers etc. This can be tested by writing a simple function with [KSPAction] attribute and then checking for it's name property as Debug.Log(Actions["YourActionFunction"].name) . "name" property will match the name used in array operator to reference this specific action. Not also that i have another roadblock. Again my example shows how to add runtime actions to config but that is also "static" as it ALWAYS adds those actions. While developing my plugin, i have managed to: -load and parse config with PartModule.OnStart() during editor scene -save config with my additional ConfigNode in PartModule.OnSave() in editor into craft file If i understand this correctly, when launching a craft from editor, PartModule.OnSave() is called three times : 1st for saving to craft file, 2nd to save with craft file with added "autosaved ship" string and 3rd time into persistence.sfs file. However, i did not managed to retain my custom ConfigNode while changing scenes from editor to flight (aka when launching a craft), it gets lost on scene change. How do i keep data i saved in craft file to transfer to persistence file (the above mentioned 3rd step) ?

WOOHOO ! I found a way for a runtime added action group to persist from editor to vessel launch !!! And AGX recognizes it, no NREs !!! Here is what i've done. public override void OnSave (ConfigNode node) { node.AddNode("ACTIONS").AddNode("base action name 1").AddValue("actionGroup","None"); } public override void OnStart (StartState state) { if (HighLogic.LoadedSceneIsEditor) SingleRuntimeAction(); } public override void OnLoad (ConfigNode node) { if (!HighLogic.LoadedSceneIsEditor) SingleRuntimeAction(); } public void SingleRuntimeAction() { KSPAction ksp_action = new KSPAction("AG test 1", KSPActionGroup.None, false, false); BaseAction base_action = new BaseAction(Actions,"base action name 1", (a) => { ScreenMessages.PostScreenMessage("test 1"); }, ksp_action); Actions.Add(base_action); } After inserting this in your PartModule, add this group (it's name is displayed in action group editor as "AG test 1") to custom group 1, launch vessel and then activate action group. Watch screen message appear. Note how "base action name 1" is defined in BaseAction class and later added in config node. BEFORE the above test, i had also written two functions with KSPAction[] attributes BuiltInAction() and BuiltInAction2(). This is what config node contained during OnSave() : {MODULE { stagingEnabled = True isEnabled = True name = TestPartModule EVENTS { } ACTIONS { BuiltInAction { actionGroup = None } BuiltInAction2 { actionGroup = None } } } } During OnLoad() vessel's config node has simiar (if not exactly the same) content. Above config node sample shows also EVENTS{}, but currently i'm not interested in these. If the above test proves stable (though everything seems straightforward), this should add one more configuration option in my part module i'm developing. For me, this would be next to impossible to discover without excellent guide about debugging with VS/MonoDevelop by @sarbian . Note that the above works with Xamarin Studio Community Edition (i've got it by trying to download MonoDevelop, links there are replaced with Xamarin Studio CE). Also a great help is Action Group Extended by @Diazo which i used to visualize and test action groups (if i didn't do something right, AGX would start throwing NREs, even before i tinkered with action groups).

Have a look at RoverDude's Konstruction. It has a weldable docking port, which should provide a code basis. You should name them "weldable struts" (now when i think about it more, there is a whole slew of parts that can be permanently welded, though KAS already solved most of it).

Well, yes that is what what i'm going to do, i just wondered about shorter, more direct approach. I guess we could call this one "solved".

One last ditch effort. I can add and remove actions groups in runtime in my PartModule plugin, but they can't persist from editor to flight (probably also on vessel load/spawn), so i gave up on that front. To elaborate : i've tried with Action Groups Extended by @Diazo to have a look into mechanics of action groups in flight scene, and while i can add actions on the fly and use them, KSP "forgets" them from SPH/VAB to vessel launch. Next, i've discovered by "type - compile - run - duck and cover" testing i can add multiple [KSPAction("somename"]) above a single function and have fully working multiple actions that persist from editor to flight scenes ! What bugs me is that i can't find out WHICH KSPAction attribute fired the function, there is no apparent link to trace back to corresponding action. Sigh... Example: [KSPAction("action one")] [KSPAction("action two")] [KSPAction("action three")] public void DoSomething(KSPAction param) { // ...stuff.. note that received "param" has only [float] Cooldown, [KSPActionGroup] group and [KSPActiontype] type, no backtracking from this } If there is a way to determine a calling action, this could save some space and simplify code. As one can guess from the above, i really would like to save up on repeating the same blocks of code (i need a lot of them for my plugin). This is me more sharing this discovery rather than me following up on this, i'll take the usual one-attribute-one-function route until this is resolved either as a failure or a success.

Why not try Xamarin Studio Community ? It supports C# 6.0. I got it from this DL link for Monodevelop. Straightforward click and download. After some tweaks its has 90% of VS functionality. My concern was VS-like code navigation, though i didn't quite nailed it with indentation (but i do very much like what they've done with visual feedback in editor preferences).

Wow i found a fully working example that enables my plugin to load config from any folder, it is a direct copy/paste into test project in VS. I can now load required config data into plugin inside editor from relevant part config.

@wasml Thanks for the info, will look into it. If i ever intend to continue writing plugins, debugging will be unavoidable. One other thing : Does this in-game-debug enable me to explore data structures ? Like for example how does API "see" my config nodes in part cfg, when i traverse all ConfigNode items in VS ? @ALL thanks for the insights, because of your effort i have realized that PartModules are designed to have static data structures, some flexibility is possible in flight scenes. So, the module that i write is not purely a PartModule, or more accurately, it needs more than PartModule can offer on it's own. So, i further researched the subject and came up with my working solution for loading part config in editor. My module needs to configure itself from part config in flight and editor scenes. Below is example code, a promising start. ConfigNode rootNode = ConfigNode.Load(KSPUtil.ApplicationRootPath + "GameData/0000_MyMods/mypart.cfg"); ConfigNode moduleNode = GetNode("PART").GetNodes("MODULE").Where(m => m.name == "YourModuleClassName").Single().GetNodes(); I can put this in OnStart() and have my config available in editor. Drawback is that i don't know how to obtain my module DLL path from part config is was called from and then use that to build a full path. As it is now, path is hard-coded into plugin, if i can just somehow obtain assembly path it could make my plugin more portable...

Here is the project file with compiled DLL in debug mode. Please review at your leisure. Thanks in advance ! NOTE: I'm on win 7 x64, KSP 1.2.2, VS 2015 CE update 3. Performed one VS installation repair.

I did a similar test in Unity3D (attached a script to camera, filled a text mesh with output) and let it run. It worked from start.

In the meantime i've changed struct to class and same thing happened. I know c# has garbage collector that frees unused stuff from memory as soon as all references are gone (included leaving method's scope). But keeping a reference inside a List should keep GC from freeing it. I'm just reusing the same variable to point to newly created item to be added into List, this shouldn't be the problem ?

Firstly, thanks to all for replies ! Secondly, i forgot to mention that example plugin was tested in SPH editor scene and OnLoad() does get called properly, every time. What i don't understand, is that my list simply does not "carry over" to OnStartFinished(), as if it was never called. Simply all references inside List were lost, wiped clean. Any attempt to use complex type (class, struct, list, dictionary) fails to retain reference outside calling method. Calling GC.KeepAlive() on my list and its newly added item at end of OnLoad() also failed. I tried searching on net but no such problems were mentioned (i find most solutions over at stackexchange). The above example source is what i have compiled into DLL, copied into subfolder in GameData and referenced it in part cfg via MODULE{} node. I did look at plugin sources at github and pretty much everywhere List is normally used from OnLoad(), nothing unusual. I'm starting to believe something is wrong with my VS 2015 CE install.

I've got serious problem with using a List / Dictionary collection classes where adding data in one event does not propagate to other event. Code example: using System; using System.Collections.Generic; using System.Linq; using System.Text; using UnityEngine; namespace TestPartPlugin { public class TestPartPlugin : PartModule { public struct teststruct { public string s; public int i; } public class testclass { public string s; public int i; } // this is shared among events, it will be passed as argument, for purposes of this example its not a problem ? public List<teststruct> l = new List<teststruct>(); public string ss; public override void OnLoad(ConfigNode node) { base.OnLoad(node); ss = new string('x', 10); // just allocate in runtime and fill it with dummy data, for reference to the problem at hand teststruct t; //now the interesting part for (int i = 0; i < 10; i++) { t = new teststruct(); //also did same with testclass, same problem t.s = "a"; //dummy fill t.i = i; l.Add(t); //add new item. if i looped in collection inside here, it would work } } public override void OnStartFinished(StartState state) // now the troublesome part { base.OnStartFinished(state); Debug.Log("LIST DUMP START"); foreach (teststruct t in l) Debug.Log("string: " + t.s + " int: " + t.i.ToString()); // BANG ! List/struct is empty ! Debug.Log("LIST DUMP END"); Debug.Log("simple string test: " + ss); //this worked, meh ... } } } I need a mutable collection that will be filled in OnLoad() and then later being used in OnStartFinished() . Right now, when i fill data in OnLoad(), inside OnStartFinished() my collection will be empty, no data is present. What now ? would using "out" keyword in method argument work ? I tried "ref" also with no result.

@Diazo Yes that was my idea as well, move grouped actions among keybindings, keybinds are left in fixed order. But do keep in mind that swapping may be useful, if not the only reason for coding such functionality, in my humble opinion.