[KSP 1.3.1] Simple Logistics (2.0.2) - Who needs pipes? 2017-10-17

[RealGecko]

1 hour ago, RoverDude said:

You know I take pull requests

No offence, man, but I wrote everything from scratch

If I provide PR USI Tools will turn to mess

[RoverDude]

I don't think you wrote USI Tools from scratch

 

[RealGecko]

Just now, RoverDude said:

I don't think you wrote USI Tools from scratch

 

I wrote Simple Logistics from scratch

[Kobymaru]

9 minutes ago, RealGecko said:

I wrote Simple Logistics from scratch

Your MM patches are nice, but most of the Magic still happens in USI Tools, which you have as a dependency

That said, personally, I wouldn't want this to be included in MKS, because MKS parts are somewhat "balanced" towards ressource sharing, whereas this looks pretty much like free magic resource transport.

[RealGecko]

1 minute ago, Kobymaru said:

Your MM patches are nice, but most of the Magic still happens in USI Tools, which you have as a dependency

Oh, man! I said it twice and I'll repeat it once more: I'm rewriting the mod, version 2.0 won't have any dependencies except MM. New code. From scratch. Separate DLL. From scratch. For those who are interested here's the code of PartModule:

using System;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

namespace SimpleLogistics
{
	public class LogisticsModule: PartModule
	{
		[KSPField(isPersistant = true, guiName = "Resource Sharing", guiActive = true)]
		private bool isActive = false;

		public bool IsActive { get { return isActive; } }

		[KSPEvent(guiActive = true, guiName = "Toggle Resource Sharing")]
		private void Toggle() {
			isActive = !isActive;
		}

		public void Set(bool status) {
			isActive = status;
		}

		public override string GetInfo()
		{
			return "Logistics Module for easy resource sharing.";
		}

		public override void OnStart(PartModule.StartState state) {
		}
	}
}

And that's the ONLY PartModule in new version, that will be applied to every command module.

6 minutes ago, Kobymaru said:

whereas this looks pretty much like free magic resource transport.

You don't like it? You don't use it! No one will blame you.

Any other questions?

[Kobymaru]

2 minutes ago, RealGecko said:

Oh, man! I said it twice and I'll repeat it once more: I'm rewriting the mod, version 2.0 won't have any dependencies except MM. New code. From scratch. Separate DLL.

Sorry, I did not understand that from your posts. Because version 1.0 which is on GitHub now has only patches and a USI Tools dependency. My mistake.

2 minutes ago, RealGecko said:

You don't like it? You don't use it! No one will blame you.

I know, thanks. I was more referring to RoverDudes comment on accepting pull requests.

[RealGecko]

Just now, Kobymaru said:

I know, thanks. I was more referring to RoverDudes comment on accepting pull requests.

Reread the OP. Keywords: MKS, USI Tools and link to @RoverDude's GitHub repo.

I do respect other people's work.

[RealGecko]

Version 2.0 is here. Delete version 1.0 before installing and reread the OP to understand new mechanics.

[Elkram]

2 hours ago, RealGecko said:

Version 2.0 is here. Delete version 1.0 before installing and reread the OP to understand new mechanics.

Congrats on release!

Going to give it a try now.

Edited November 24, 2016 by Elkram

[MatterBeam]

This is incredible!

Would you mind if I put it down as suggested mod for use with SimpleConstruction?

Also, does this transfer any resources, or does it need an MM patch to be able to use non-stock resources?

[RealGecko]

Just now, MatterBeam said:

Would you mind if I put it down as suggested mod for use with SimpleConstruction?

Man, I use your Simple Construction in my career, do it, rock on!

2 minutes ago, MatterBeam said:

Also, does this transfer any resources, or does it need an MM patch to be able to use non-stock resources?

It uses MM to add LogisticsModule to command modules (capsules, drone cores) and that's the way to detect if vessel shares resources or not. And when it goes to resources it simply scans every vessel for available resources and spreads them all around the network. So if resource is created as PartResource (doubt if there are other ways ) then it will be shareable. I tested it with Simple Construction and Snacks and everything looked cool. It plays nicely with CRP, for example Depleted Uranium has:

flowMode = NO_FLOW
transfer = NONE

So it cannot be transferred, even by Simple Logistics

[MatterBeam]

1 hour ago, RealGecko said:

Man, I use your Simple Construction in my career, do it, rock on!

It uses MM to add LogisticsModule to command modules (capsules, drone cores) and that's the way to detect if vessel shares resources or not. And when it goes to resources it simply scans every vessel for available resources and spreads them all around the network. So if resource is created as PartResource (doubt if there are other ways ) then it will be shareable. I tested it with Simple Construction and Snacks and everything looked cool. It plays nicely with CRP, for example Depleted Uranium has:

flowMode = NO_FLOW
transfer = NONE

So it cannot be transferred, even by Simple Logistics

Sounds great. I'm encountering a problem when this mod is in use though: I cannot transfer resources manually between different parts. Is this intended?

[RealGecko]

3 minutes ago, MatterBeam said:

Sounds great. I'm encountering a problem when this mod is in use though: I cannot transfer resources manually between different parts. Is this intended?

Ah yes, that's the issue, I transfer resources on per part basis instead of per vessel basis. So it is not possible to transfer resources between parts in one vessel until it is connected to network. By the way, I completely forgot to test this, but I think it must work: you can try and lock some resource on some part and it will be preserved.

[MatterBeam]

2 minutes ago, RealGecko said:

Ah yes, that's the issue, I transfer resources on per part basis instead of per vessel basis. So it is not possible to transfer resources between parts in one vessel until it is connected to network. By the way, I completely forgot to test this, but I think it must work: you can try and lock some resource on some part and it will be preserved.

I'll be more precise: if I have Vessel 1 with tanks A and B, sitting next to Vessel 2, I cannot move resources between tanks A and B.

[RealGecko]

4 minutes ago, MatterBeam said:

I'll be more precise: if I have Vessel 1 with tanks A and B, sitting next to Vessel 2, I cannot move resources between tanks A and B.

Ah, yes. That's right too. I thought about adding this feature, but looks like it's a bit tricky to implement, because even though vessels share resources with each other, they're technically separate vessels for the game. And game by itself does not allow to see resources of another vessel in right-click menu and of course does not allow to transfer them

That's why I added that "Request Resources" feature. The vessel that's not the part of network may just request desired amount from resource pool.

[ExplorerKlatt]

I think he is saying he can't transfer resources between tanks on the same vessel. 

[Elkram]

It could be cool if it had some kind of connection with dangit! continued so the logistics module could get broken and needed a repair.

[sebi.zzr]

For some reason this is not working for me.At first i thought there is a conflict with another mod,but i tried with fresh install (stock,veselemover,MM and simple logistic),with no avail.i get the UI,but not the option for "plug into network".

KSP.log:http://pastebin.com/SNt5VNxM

 

Edited November 24, 2016 by sebi.zzr

[Elkram]

There is no plug option, it just works, as far as i know

 

[sebi.zzr]

6 minutes ago, Elkram said:

There is no plug option, it just works, as far as i know

 

Well,OP says different!

[Elkram]

Just now, sebi.zzr said:

Well,OP says different!

Yep I saw it in the op too, but just tried 2 rovers and one was chargin electricity coming solar panels installed in the other, I touched nothing.

[riocrokite]

very nice work man, one additional useful thing is that I can now launch rockets without fuel loss using big engines that need to spool up. I just need place a big tank of fuel nearby

[sebi.zzr]

The batteries in stack,get filed with only so much EC that the command module with generator has it.

[RealGecko]

45 minutes ago, sebi.zzr said:

For some reason this is not working for me.At first i thought there is a conflict with another mod,but i tried with fresh install (stock,veselemover,MM and simple logistic),with no avail.i get the UI,but not the option for "plug into network".

That's pretty odd. I see no errors about SL mod loading in the log, but there's a bunch of errors like this one:

[LOG 18:52:10.315] PartLoader: Compiling Part 'Squad/Parts/Misc/AsteroidDay/HECS2/HECS2_ProbeCore'
[ERR 18:52:10.319] Cannot find a PartModule of typename 'ModuleLogistics'

Sometime KSP installation goes crazy, I don't know what causes it. My advice to you: if you're using Steam, then go to Game Properties - Local Files - Verify Integrity of Game Cache. It helped me few times when KSP became really unresponsive

24 minutes ago, riocrokite said:

very nice work man, one additional useful thing is that I can now launch rockets without fuel loss using big engines that need to spool up. I just need place a big tank of fuel nearby

Yeah, I personally want to use the biggest of this tanks to create on surface fuel depot

[sebi.zzr]

11 minutes ago, RealGecko said:

That's pretty odd. I see no errors about SL mod loading in the log, but there's a bunch of errors like this one:

[LOG 18:52:10.315] PartLoader: Compiling Part 'Squad/Parts/Misc/AsteroidDay/HECS2/HECS2_ProbeCore'
[ERR 18:52:10.319] Cannot find a PartModule of typename 'ModuleLogistics'

Sometime KSP installation goes crazy, I don't know what causes it. My advice to you: if you're using Steam, then go to Game Properties - Local Files - Verify Integrity of Game Cache. It helped me few times when KSP became really unresponsive

I'm not steam user,i downloaded game from store.
EDIT:I heard that Windows don't like .dlls to be installed in Program Files or in Documents,so i tried again and put everything in C:\Games\KSP_win64 with no avail.

Edited November 24, 2016 by sebi.zzr