SnackTank: Snacks! resources in stock ore tanks

[SingABrightSong]

Also supports ReStock+ and Air!

I've always been fond of @Angel-125's Snacks! mod, in particular as it could be used with only stock parts. At least,  aside from the cloned RCS tanks used for dedicated storage. Being somewhat prone to stock parts purism, I noticed that the flavour text for the Ore tanks explicitly mentions snacks, and  thus, this mod was conceived.

More or less very simple Module Manager patching to add Snacks resource switching to the ore tanks. Additionally, the tech tree nodes are adjusted to mirror the Snacks-added tank progression, so players aren't forced to research IRSU before they're able to pack enough snacks to get to Minmus

Config files licensed under MIT. Depends on Snacks, obviously, and on Module Manager

SnackTank on SpaceDock

[DasSkelett]

Hey @SingABrightSong, congrats on your (first?) mod!

While looking at the mod for indexing it in CKAN after receiving the automated SpaceDock PR, I noticed that your patches use ":FOR[Snacks]".
If I understand the ModuleManager documentation correctly, only the mod itself should add a ":FOR" clause with its own name, because it signals ModuleManager that this mod is installed.

Module Manager generate list of case-insensitive modname values that will work in NEEDS, BEFORE, AFTER by doing the following:

  * Scans all the loaded DLLs and adds modname.dll to the list of loaded mods (just the modname portion)
  * Scans all the configs for properly configured FOR[modname] and add modname to the list of loaded mods <=======
  * Scans the GameData directory and adds modname to the list of loaded mods, with white space characters removed from the name of the folder (space, tab, and several others defined by Unicode/.NET).

https://github.com/sarbian/ModuleManager/wiki/Patch-Ordering#valid-modname-values

It is not recommended to use the :FOR directive to refer to other mods than the one you are writing.

https://github.com/sarbian/ModuleManager/wiki/Patch-Ordering#the-beforemodname-formodname-and-aftermodname-directives

For signalling a dependency on another mod, you are supposed to use ":NEEDS" (like you did for ReStockPlus), to my understanding.

While this is not a problem for CKAN users, because they will always have Snacks installed due to the dependency, it can create issues for manual installers that are missing Snacks, because it would mean that not only your patches, but also all conditional patches of other mods that support Snacks are applied, even though Snacks is missing.

Edited July 3, 2021 by DasSkelett

[SingABrightSong]

Ah, thank you. Technically not my first, but my first isn't indexed on CKAN because at the time its dependency wasn't listed. And thank you for the heads up, I'm rather rusty with MM syntax, will push a fix for that presently.

[theleg]

1 hour ago, SingABrightSong said:

Also supports ReStock+ and Air!

I've always been fond of @Angel-125's Snacks! mod, in particular as it could be used with only stock parts. At least,  aside from the cloned RCS tanks used for dedicated storage. Being somewhat prone to stock parts purism, I noticed that the flavour text for the Ore tanks explicitly mentions snacks, and  thus, this mod was conceived.

More or less very simple Module Manager patching to add Snacks resource switching to the ore tanks. Additionally, the tech tree nodes are adjusted to mirror the Snacks-added tank progression, so players aren't forced to research IRSU before they're able to pack enough snacks to get to Minmus

Config files licensed under MIT. Depends on Snacks, obviously, and on Module Manager

SnackTank on SpaceDock

Congrats on the release! Will this work with ore tanks from other mods?

[SingABrightSong]

3 hours ago, theleg said:

Congrats on the release! Will this work with ore tanks from other mods?

Thank you. Not as implemented, as each ore tank is targeted by name rather than by being an ore tank.