@Papa_Joe, I'm still having the issue mentioned, but only when "Resources in Pre-Flight" is enabled (the default). Glancing at the code, it looks like "pre-flight" is defined as Vessel.IsRecoverable, which is evidently returning true in unexpected situations, perhaps Vessel.situation could be evaluated vs Situations.PRELAUNCH?
Scenario: fresh install of 1.2.2, ShipManifest 5.1.3.1 from github, default settings (Realism enabled), Sandbox, Command Pod, FL-T800, LV-T45, >70km suborbital
Steps: open ShipManifest window, click LiquidFuel (opens transfer window)
Result: Fill button present in Transfer window. Clicking causes fuel to appear from nowhere.
Also, a new bug:
Scenario: fresh install of 1.2.2, ShipManifest 5.1.3.1 with default settings, Sandbox, Command Pod, FL-T800, LV-T45
Steps: Launch (need not leave launchpad), open the ShipManifest window, click LiquidFuel (opens transfer window), click MonoPropellant.
Result: LiquidFuel set to 0/0, tanks disappear from transfer window, dump button gone. Nothing in the SM Debug Console. Closing and re-opening the window does not fix, remains 0/0. However, unselecting both, then clicking LiquidFuel, then Oxidizer causes LiquidFuel to come back.
Note: This also occurs if MonoPropellant is clicked first, then LiquidFuel or Oxidizer, in which case I haven't found a way to cause it to come back, or if Ore is used for the second click instead of MonoPropellant.
Thanks again for all your effort.