Opening light menu causes huge lag spikes

[Majorjim!]

Hi all,

Another day, another bug.

Opening the RGB menu for lights causes huge lag spikes. It's 100% reproducible, put a light on a craft, open menu, boom.

[Jon144]

Yeah I keep getting the same bug. It is amazingly frustrating when trying to tweak the color values. Especially with higher part count designs.

[Majorjim!]

Yeah I keep getting the same bug. It is amazingly frustrating when trying to tweak the color values. Especially with higher part count designs.

Yes that's right.. It's stil there with just a light and nothing else it's just very subtle. When it's on a craft it's crippling.

[JacobT11]

Yep, noticed this on stock and mod installs. It seems any time a right click menu causes visual changes in the VAB/SPH, it induces lag spikes. Such as changing light colors in stock, or adjusting fairings and landing gear via mods.

[Padishar]

This appears to be exactly the same problem that occurs with the parachute altitude slider when you set it to some values. There is a bug in the slider code which makes it spam events saying that the vessel has changed. The engineers report runs each time this event is fired which would cause significant slowdown by itself because it creates quite a lot of garbage but there is also a memory leak in the code that updates the UI for the engineers report which causes the memory usage of KSP to rise rapidly (it will eventually crash).

Basically, the RGB sliders show this problem when you set them at a value of 0.45, 0.65 or 0.9.

The reason it hits harder with a complex craft is simply because the engineers report has more work to do for a larger craft.

[katateochi]

I've found it to be much worse with the spotlight (Mk1) than with the worklight (Mk2) (possibly not even had it at all with the Mk2, but with the Mk1 it's really bad)

Sometimes you don't notice it too much... and then you try to pan the camera with the light menu open and suddenly find everything is in molasses!

That's interesting about the slow down cause being the engineers report Padishar. The slider code spamming vessel-changed events thing, that sounds like something that really should have been caught with good unit testing, not even acceptance/bug testing.

[tutike2000]

Is there anything being generated in your logs ?