[1.9-1.10] Configurable Containers

[allista]

17 minutes ago, Bit Fiddler said:

hmm but these do not look to be what we need.   as on a "per liter" basis food needs many more liters than oxygen.  but this seems to be backwards to me according to those values...

That's because oxygen tanks are high-pressure, not 1atm.

[Bit Fiddler]

ya, having to do the math now...  I will get it soon eneugh

[Bit Fiddler]

well In the limits of the existing UI this is as close as I can get it for TAC  the food and water are near exact, but oxygen is a wee bit high   in the range "who cares"  as in over 404 days there is an extra 2H 19 seconds... food and water are off by mere 2 seconds

 

TANKCONF
{
	name = TAC-LS
	Volume = 5.70900011
	TANK
	{
		TankType = Food
		CurrentResource = Food
		InitialAmount = 0
		Volume = 3
	}
	TANK
	{
		TankType = Water
		CurrentResource = Water
		InitialAmount = 0
		Volume = 1.50699997
	}
	TANK
	{
		TankType = Gases
		CurrentResource = Oxygen
		InitialAmount = 0
		Volume = 1.20200002
	}
}

 

Edited October 18, 2016 by Bit Fiddler

[allista]

23 minutes ago, Bit Fiddler said:

well In the limits of the existing UI this is as close as I can get it for TAC  the food and water are near exact, but oxygen is a wee bit high   in the range "who cares"  as in over 404 days there is an extra 2H 19 seconds... food and water are off by mere 2 seconds

TANKCONF
{
	name = TAC-LS
	Volume = 5.70900011
	TANK
	{
		TankType = Food
		CurrentResource = Food
		InitialAmount = 0
		Volume = 3
	}
	TANK
	{
		TankType = Water
		CurrentResource = Water
		InitialAmount = 0
		Volume = 1.50699997
	}
	TANK
	{
		TankType = Gases
		CurrentResource = Oxygen
		InitialAmount = 0
		Volume = 1.20200002
	}
}

 

Perfect! Thanks a lot!

If you don't mind, I'll include it into the mod configs with a proper attribution.

[Bit Fiddler]

sure but use this one..  I realized if I used a bigger tank I would get more accurate results.

 

TANKCONF
{
	name = TAC-LS
	Volume = 38.0569992
	TANK
	{
		TankType = Water
		CurrentResource = Water
		InitialAmount = 0
		Volume = 10.0469999
	}
	TANK
	{
		TankType = Food
		CurrentResource = Food
		InitialAmount = 0
		Volume = 20.0009995
	}
	TANK
	{
		TankType = Gases
		CurrentResource = Oxygen
		InitialAmount = 0
		Volume = 8.00899982
	}
}

 

with this one over a span of 10 years 109 days.  It is off by less than 10 seconds on all 3 resources.

unfortunately I just did it by trial and error.   but if we could figure the math from the TAC mod it could be exact I guess.

 

Oh and I guess the reason I am not seeing the "Edit Tank" button is because you only add that to the vanilla game tanks?  It does not add it to any tanks from mods?

 

 

[Bit Fiddler]

could do this with MM  looking for a list of resources and say if the part has one of these resources in it, then consider it a "tank" and add the edit tank feature.

 

could just use the basics, or grab the community resource list and do them all...

there is probably a way to automate this with MM even. tell it to read each entry in the community resource list, and look for it in every other module...  not sure how powerful MM is but this sounds like it may work...

[allista]

10 minutes ago, Bit Fiddler said:

could do this with MM  looking for a list of resources and say if the part has one of these resources in it, then consider it a "tank" and add the edit tank feature.

 

could just use the basics, or grab the community resource list and do them all...

there is probably a way to automate this with MM even. tell it to read each entry in the community resource list, and look for it in every other module...  not sure how powerful MM is but this sounds like it may work...

Alas, MM is not THAT powerful; this would require a full-blown programming language.

I do have some utils of my own to automate patching, though. So, using your TANKCONF I'll make the patch for TAC-LS parts.

Edited October 18, 2016 by allista

[Bit Fiddler]

digging into the actual help documents, and mod setting now. to see if I can figure the real math.   the trial and error setup is ok for now but if I can get the exact numbers I will post them here.

 

I just do not see anywhere how much the Oxygen is compressed when stored in liquid form.

[allista]

 

[Bit Fiddler]

nice

is the .4 a scalar of the volume or did you pick .4 as the value?

 

ah I just realized... if I edit a tank and put each of the 3 to 1 liter I can see the  units per liter by looking at the TAC planner.   I can then use this with the "units per day" in the config option to get exact ratios...

will need to do some testing but I think I will be able to get exact ratios soon

 

[allista]

6 minutes ago, Bit Fiddler said:

nice

is the .4 a scalar of the volume or did you pick .4 as the value?

It's just 1% of the total volume. I'm not sure what will be better here. May be 5% or 10%?

[Bit Fiddler]

ya not sure...  just have to pick a number and go with it and see what people say.  I guess 1% is as good as any for a start.

maybe 2 arrows...  a 1% and a 10% ?  maybe this is just over thinking it...

[LeLeon]

41 minutes ago, Bit Fiddler said:

ya not sure...  just have to pick a number and go with it and see what people say.  I guess 1% is as good as any for a start.

maybe 2 arrows...  a 1% and a 10% ?  maybe this is just over thinking it...

1% and 10% sounds good.

[allista]

10 minutes ago, LeLeon said:

1% and 10% sounds good.

Sorry, not doing 4 buttons here. My UIs are already tend to be cluttered and confusing 

[Bit Fiddler]

so is this new version up for DL yet?

 

[Bit Fiddler]

ok so the final word on this tank config...

 

after much researching, math, and trial and error to fudge it out to 7 decimal points this is what we get. 

 

at 227 years, 403 days.  food and oxygen are exact.  however Water is out of kilter by 1 second.  I am calling this good enough at this point.

 

TANKCONF
{
	name = TAC-LS
	Volume = 1
	TANK
	{
		TankType = Food
		CurrentResource = Food
		InitialAmount = 0
		Volume = 0.5255531
	}
	TANK
	{
		TankType = Water
		CurrentResource = Water
		InitialAmount = 0
		Volume = 0.2639998
	}
	TANK
	{
		TankType = Gases
		CurrentResource = Oxygen
		InitialAmount = 0
		Volume = 0.2104471
	}
}

 

 

so now the last question about this tank config...  there is a spot for an initial amount.  if I put an overly-large number in here when I create a tank it will fill it up automatically as this number is bigger than any conceivable tank I might make.   will this cause a problem in any of the math in your mod?  or is it safe to set the "InitialAmmount" to something like "9999999999"?

Edited October 18, 2016 by Bit Fiddler

[Wahgineer]

@allista, this looks AMAZING! Congrats on the Modding Monday feature! Might I suggest adding mesh and texture switching as well?

[allista]

1 hour ago, Bit Fiddler said:

so is this new version up for DL yet?

Nope, sorry, this will have to wait a little. For one thing, there are some things still to test (with TS and others); but besides this I had to make some changes on the AT_Utils side, so other mods are affected as well. The downside of code sharing...

41 minutes ago, Bit Fiddler said:

ok so the final word on this tank config...

after much researching, math, and trial and error to fudge it out to 7 decimal points this is what we get. 

at 227 years, 403 days.  food and oxygen are exact.  however Water is out of kilter by 1 second.  I am calling this good enough at this point.

so now the last question about this tank config...  there is a spot for an initial amount.  if I put an overly-large number in here when I create a tank it will fill it up automatically as this number is bigger than any conceivable tank I might make.   will this cause a problem in any of the math in your mod?  or is it safe to set the "InitialAmmount" to something like "9999999999"?

Amazing!

As for InitialAmount it's just the ratio. From 0 to 1 

[Bit Fiddler]

I would skip the mesh and texture switching unless those mods that do it already disappear.  I think adding in to much to one mod detracts from making it do the 1 thing very well.  and we have several mesh/texture switch options out there already.

 

 

ah well I guess I can remove these long strings of 9's then...  a simple 1 will do

 

Edited October 18, 2016 by Bit Fiddler

[allista]

17 minutes ago, awsumindyman said:

@allista, this looks AMAZING! Congrats on the Modding Monday feature! Might I suggest adding mesh and texture switching as well?

Thanks!

Simple texture switching is already there:

Spoiler

	public class SimpleTextureSwitcher : PartModule
	{
		/// <summary>
		/// The folder in which textures are located. 
		/// Relative to GameData folder.
		/// </summary>
		[KSPField] public string RootFolder = string.Empty;

		/// <summary>
		/// The names of the game objects which main texture should be replaced.
		/// Divided by commas. May be regular expressions.
		/// </summary>
		[KSPField] public string AffectedObjects = string.Empty;
		
		/// <summary>
		/// Names of the textures to choose from. 
		/// </summary>
		[KSPField] public string Textures = string.Empty;
		
		/// <summary>
		/// The texture currently in use.
		/// </summary>
		[KSPField(isPersistant = true, guiActiveEditor = true, guiName = "Texture")]
		public string CurrentTexture = string.Empty;

 

As for the mesh switching and more complicated things, I don't see why not use FS or Interstellar modules for this. They're pretty advanced and mature, so why reimplement?

Edited October 18, 2016 by allista

[Wahgineer]

2 minutes ago, allista said:

Thanks!

Simple texture switching is already there:

  Reveal hidden contents

	public class SimpleTextureSwitcher : PartModule
	{
		/// <summary>
		/// The folder in which textures are located. 
		/// Relative to GameData folder.
		/// </summary>
		[KSPField] public string RootFolder = string.Empty;

		/// <summary>
		/// The name of the game objects which main texture should be replaced.
		/// </summary>
		[KSPField] public string AffectedObjects = string.Empty;
		
		/// <summary>
		/// Names of the textures to choose from. 
		/// </summary>
		[KSPField] public string Textures = string.Empty;
		
		/// <summary>
		/// The texture currently in use.
		/// </summary>
		[KSPField(isPersistant = true, guiActiveEditor = true, guiName = "Texture")]
		public string CurrentTexture = string.Empty;

 

As for the mesh switching and more complicated things, I don't see why not use FS or Interstellar modules for this. They're pretty advanced and mature, so why reimplement?

Some might enjoy the advanced flexibility this mod provides, as well as the fact that it is new (less likley to die due to old age/interest in development). I can already see this being used to replace modular fuel tanks for RF.

Edited October 18, 2016 by awsumindyman
Posted on mobile. 'nuff said

[allista]

1 minute ago, awsumindyman said:

Some might enjoy the advanced flexibility this mod provides, as well as the fact that it us new (less likley to die due to old age/interest in development).

I'll consider this 

[Wahgineer]

@allista cool!

[Bit Fiddler]

ok so I understand that KSP will not allow us to have 2 tanks defined in a single part that hold the same resource.  but I think your mod is allowing this to happen and then the tank is FUBAR and must be removed from the ship and replaced with a new one.

 

I am not sure this is the cause of this strange behavior.  I will examine it in more detail if it happens again.

[allista]

2 minutes ago, Bit Fiddler said:

ok so I understand that KSP will not allow us to have 2 tanks defined in a single part that hold the same resource.  but I think your mod is allowing this to happen and then the tank is FUBAR and must be removed from the ship and replaced with a new one.

I am not sure this is the cause of this strange behavior.  I will examine it in more detail if it happens again.

What strange behaviour?

If you switch to an already occupied resource, the tank will remain empty (just using the space) and will wait until you switch to a non-occupied one. It should display a message about that too.