ModuleSelectableDataTransmitter

[linuxgurugamer]

Hi all,

I'm going to be writing a small part module, called ModuleSelectableDataTransmitter. It's going to inherit from ModuleDataTransmitter, the change will be that in the editor, you will be able to select the antennaType, so that a single antenna can be used either for a DIRECT or a RELAY antenna.

I was thinking about making it possible to flip it in flight.  Before I get started, I'd like any input or comments as to the viability and usability of this.

Thanks

[DMagic]

Maybe it would be better to make a separate part module that looks for a ModuleDataTransmitter and switches the type. That way you don't mess up any mods that look for ModuleDataTransmitter (even if most of the time they should probably be using IDataTransmitter). 

I imagine that if you want to flip the type in flight you might need to re-initialize the CommNet aspects of the transmitter. That seems like something that would only be set once.

[linuxgurugamer]

So what I did was to make a new module, which will replace ModuleDataTransmitter, but it has to be done via a cfg file change.  The new mod inherits from ModuleDataTransmitter.

https://github.com/linuxgurugamer/SelectableDataTransmitter

 

[sarbian]

Do you plan to notify the network graph that it needs to be rebuilt ?

[Yamori Yuki]

There is a stock module ModuleRelayEnabler in CommNet namespace that would be a much better candidate for inheriting. You just need to add the code for manually turning it on/off. Much cleaner way to achieve your goal.

[linuxgurugamer]

On 1/1/2017 at 5:04 PM, sarbian said:

Do you plan to notify the network graph that it needs to be rebuilt ?

How?

[linuxgurugamer]

1 hour ago, linuxgurugamer said:

How?

maybe like this:

 if (HighLogic.CurrentGame.Parameters.Difficulty.EnableCommNet)
                        CommNetNetwork.Instance.CommNet.Rebuild();

 

Edited January 12, 2017 by linuxgurugamer