RandomKerbal Posted July 20, 2020 Share Posted July 20, 2020 nice! Is this compatible with all of the part mods? Quote Link to comment Share on other sites More sharing options...
eberkain Posted December 24, 2020 Share Posted December 24, 2020 the alt-click on a hatch to eva a kerb from any pod to that hatch doens't seem to work anymore. Quote Link to comment Share on other sites More sharing options...
ZinkBot Posted May 12, 2021 Share Posted May 12, 2021 Cool! Are you going to update this? Quote Link to comment Share on other sites More sharing options...
Dominiquini Posted June 13, 2021 Share Posted June 13, 2021 On 5/12/2021 at 1:52 PM, ZinkBot said: Cool! Are you going to update this? Quote Link to comment Share on other sites More sharing options...
angelix Posted September 7, 2021 Share Posted September 7, 2021 On 12/24/2020 at 6:42 AM, eberkain said: the alt-click on a hatch to eva a kerb from any pod to that hatch doens't seem to work anymore. Its working but because framewait is too short it usually all aborted before window appear. Increasing this private static int framewait = 5; will help. I set it to 50 and its always work(little overkill but i dont mind) . p.s. i know this is old post, but issue still here. and this is a great mod(i really tired of transfering 20 kerbals on disembark/embark so they plant flag and back). Quote Link to comment Share on other sites More sharing options...
shelshok Posted September 26, 2021 Share Posted September 26, 2021 Installing from CKAN says incompatible with later versions of Harmony. https://imgur.com/a/5ZMYh1i Quote Link to comment Share on other sites More sharing options...
eberkain Posted January 12, 2022 Share Posted January 12, 2022 On 9/25/2021 at 11:11 PM, shelshok said: Installing from CKAN says incompatible with later versions of Harmony. https://imgur.com/a/5ZMYh1i indeed, running into this myself. Quote Link to comment Share on other sites More sharing options...
wreckreation Posted November 25, 2022 Share Posted November 25, 2022 On 9/25/2021 at 9:11 PM, shelshok said: Installing from CKAN says incompatible with later versions of Harmony. https://imgur.com/a/5ZMYh1i Indeed it is. If you have Airlocks Plus (with Harmony v1 removed), Konstruction (and its dependencies) and something that uses Harmony v2 installed, the Konstruction toolbar button will get duplicated each time you revert to the VAB or SPH. After a few reverts the toolbar is filled with multiple Konstruction buttons. Remove Airlocks Plus and the duplication issue goes away. I don't know if it causes any other issues with other mods, but this issue is certainly evidence that Airlocks Plus does not get along with Harmony v2. It's too bad, this is a really useful mod. Quote Link to comment Share on other sites More sharing options...
dr.phees Posted March 2, 2023 Share Posted March 2, 2023 This is a brilliant mod. I hope for a final update to support 1.12, though Quote Link to comment Share on other sites More sharing options...
Tahvohck Posted June 13, 2023 Share Posted June 13, 2023 @cakepie hasn't posted on the forum in four years (almost to the date, actually), though they did interact about a year ago. HOPEFULLY this ping gets their attention. The license for this mod is, unfortunately, a pain in the ass for modification. Even if I was willing to maintain it that would put me off. With that said, you can get this to compile pretty easily against 1.12/ModuleManager 4.2.2 with the following setup: .NET version: 4.8 References: Assembly-CSharp.dll UnityEngine.CoreModule.dll UnityEngine.InputLegacyModule.dll UnityEngine.PhysicsModule.dll UnityEngine.Te3xtRenderingModule.dll UnityEngine.UI.dll 0Harmony.dll ModuleManager.4.2.2.dll CLSInterfaces.dll ConnectedLivingSpace.dll You'll need to make the following change to the source files to use the MM-distributed Harmony: diff --git a/Source/HarmonyPatches.cs b/Source/HarmonyPatches.cs index 163ecb3..d54befc 100644 --- a/Source/HarmonyPatches.cs +++ b/Source/HarmonyPatches.cs @@ -4,7 +4,7 @@ using System.Reflection; using UnityEngine; using KSP.UI.Screens.Flight.Dialogs; -using Harmony; +using HarmonyLib; namespace AirlockPlus.Harmony { @@ -18,9 +18,9 @@ public sealed class Patcher : MonoBehaviour // If Harmony dependency is missing, AddonLoader will barf in logs when instantiating addon // ADDON BINDER: Cannot resolve assembly ... // and none of this will execute - Assembly harmonyAssy = typeof(HarmonyInstance).Assembly; + Assembly harmonyAssy = typeof(HarmonyLib.Harmony).Assembly; Debug.Log($"[AirlockPlus|Patcher] Using Harmony {harmonyAssy.GetName().Version.ToString()} located at {harmonyAssy.Location}"); - HarmonyInstance harmony = HarmonyInstance.Create("com.github.cake-pie.AirlockPlus"); + HarmonyLib.Harmony harmony = new HarmonyLib.Harmony("com.github.cake-pie.AirlockPlus"); harmony.PatchAll(Assembly.GetExecutingAssembly()); harmonyAvailable = true; Destroy(gameObject); I've only tested it briefly since recompiling it, but at first glance it works fine. Given that the harmony code is all I changed I'd be surprised if there's any actual "new" bugs that didn't exist already. Quote Link to comment Share on other sites More sharing options...
TEMPEST_114 Posted November 30, 2024 Share Posted November 30, 2024 On 6/13/2023 at 4:36 AM, Tahvohck said: @cakepie hasn't posted on the forum in four years (almost to the date, actually), though they did interact about a year ago. HOPEFULLY this ping gets their attention. The license for this mod is, unfortunately, a pain in the ass for modification. Even if I was willing to maintain it that would put me off. With that said, you can get this to compile pretty easily against 1.12/ModuleManager 4.2.2 with the following setup: .NET version: 4.8 References: Assembly-CSharp.dll UnityEngine.CoreModule.dll UnityEngine.InputLegacyModule.dll UnityEngine.PhysicsModule.dll UnityEngine.Te3xtRenderingModule.dll UnityEngine.UI.dll 0Harmony.dll ModuleManager.4.2.2.dll CLSInterfaces.dll ConnectedLivingSpace.dll You'll need to make the following change to the source files to use the MM-distributed Harmony: diff --git a/Source/HarmonyPatches.cs b/Source/HarmonyPatches.cs index 163ecb3..d54befc 100644 --- a/Source/HarmonyPatches.cs +++ b/Source/HarmonyPatches.cs @@ -4,7 +4,7 @@ using System.Reflection; using UnityEngine; using KSP.UI.Screens.Flight.Dialogs; -using Harmony; +using HarmonyLib; namespace AirlockPlus.Harmony { @@ -18,9 +18,9 @@ public sealed class Patcher : MonoBehaviour // If Harmony dependency is missing, AddonLoader will barf in logs when instantiating addon // ADDON BINDER: Cannot resolve assembly ... // and none of this will execute - Assembly harmonyAssy = typeof(HarmonyInstance).Assembly; + Assembly harmonyAssy = typeof(HarmonyLib.Harmony).Assembly; Debug.Log($"[AirlockPlus|Patcher] Using Harmony {harmonyAssy.GetName().Version.ToString()} located at {harmonyAssy.Location}"); - HarmonyInstance harmony = HarmonyInstance.Create("com.github.cake-pie.AirlockPlus"); + HarmonyLib.Harmony harmony = new HarmonyLib.Harmony("com.github.cake-pie.AirlockPlus"); harmony.PatchAll(Assembly.GetExecutingAssembly()); harmonyAvailable = true; Destroy(gameObject); I've only tested it briefly since recompiling it, but at first glance it works fine. Given that the harmony code is all I changed I'd be surprised if there's any actual "new" bugs that didn't exist already. For someone who has never modded a Unity project or KSP mod before, would you be willing to clarify which files I need to make these changes to (and clarify what I need to remove / replace with these lines of 'code') so that I can get this to work please? Thanks. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.