Jump to content

[1.8.x] In game notes / notepad / checklist v0.16 2019/10/23


agises

Recommended Posts

Anybody else here who has this issue?

Toolbar plugin by Blizzy allows to change button order. That works, for me, with every mod button using the toolbar. Every button, but for the one from Ingame notes and the one from Kalculator (both mods by agises).

If I use the toolbar menu to unlock the button order, I can then drag buttons around within the toolbar and have them snap to another position. When a button is dragged, an orange line appears to show where it will be inserted if released in that moment. With the buttons from the mods by agises, I try to drag them but only the "orange line" appears (before actually moving any button) and moves with the mouse pointer within the toolbar, however these buttons stay put and don't change position (are not draggable). And, while the orange line associated to these buttons is shown, the whole "button-ordering" feature ceases to work (I have to either drag the line outside of the toolbar, or to lock the button order from the toolbar menu, to make that work again.

After moving one of the normal buttons, the KSP log gives:

[Log]: saving toolbar settings (SPACECENTER)

Instead, doing the same with Ingamenotes button, I have this:

[Exception]: ArgumentOutOfRangeException: Argument is out of range.

Parameter name: index

Here how any of the normal buttons are dragged within the toolbar.

Here after clicking the Ingamenotes button with the button-ordering feature active. Note the orange line shown even before actually dragging it.

Here the orange line is dragged around within the toolbar. Note that the button stays put, does not move with the pointer.

Here the orange line remains active (and the button-ordering feature is locked) even without the pointer in the toolbar

(can't show that, but mouse button was released also).

Toolbar version 1.4.2, Ingame notes version 0.7, Kalculator version 0.1

Link to comment
Share on other sites

[Exception]: ArgumentOutOfRangeException: Argument is out of range.

Parameter name: index

In your output_log.txt, there should be more information regarding this exception, most notably a stack trace outlining which methods were called when the error occurred. Please post that here, too.

Link to comment
Share on other sites

Looks like this is the one. I'll see what it is about.

ArgumentOutOfRangeException: Argument is out of range.
Parameter name: index
at System.Collections.Generic.List`1[Toolbar.Button].RemoveAt (Int32 index) [0x00000] in <filename unknown>:0
at Toolbar.Toolbar.buttonDrag (Toolbar.DragEvent e) [0x00000] in <filename unknown>:0
at Toolbar.Draggable.fireDrag () [0x00000] in <filename unknown>:0
at Toolbar.Draggable.handleDrag () [0x00000] in <filename unknown>:0
at Toolbar.Draggable.update () [0x00000] in <filename unknown>:0
at Toolbar.Toolbar.update () [0x00000] in <filename unknown>:0
at Toolbar.ToolbarManager.Update () [0x00000] in <filename unknown>:0

Edit: Found it. The problem is triggered by a bug in the Notes plugin. In OnGUI(), the toolbar button is created every frame, replacing the old button with the same namespace and ID. This is not how it is supposed to work. You just create the button once (in Start(), for example), then just hold on to it.

Edited by blizzy78
Link to comment
Share on other sites

Found it. The problem is triggered by a bug in the Notes plugin. In OnGUI(), the toolbar button is created every frame, replacing the old button with the same namespace and ID. This is not how it is supposed to work. You just create the button once (in Start(), for example), then just hold on to it.

You're the best :D

Link to comment
Share on other sites

Anybody else here who has this issue?

Toolbar plugin by Blizzy allows to change button order. That works, for me, with every mod button using the toolbar. Every button, but for the one from Ingame notes and the one from Kalculator (both mods by agises).

I have that issue too.

Edit: Found it. The problem is triggered by a bug in the Notes plugin. In OnGUI(), the toolbar button is created every frame, replacing the old button with the same namespace and ID. This is not how it is supposed to work. You just create the button once (in Start(), for example), then just hold on to it.

Waiting for fix :)

Link to comment
Share on other sites

My guess is the same bug is in the Kalculator Plugin, too. I haven't actually checked the source code, though.

Yup it's also affected fixed in Kalculator 0.1.1

Bug fix released. Thanks diomedea and blizzy78.

Salud.

Edited by agises
Link to comment
Share on other sites

Thanks for this mod, its simple and sweet. If you're open to expanding on it I think it would make a great knee board tool. In aviation knee boards common practice and I'm sure NASA pilots are still using them. It usually has your emergency checklist, your flight plan, a chart maybe, a place for notes, maybe common calculations of tables with fuels and weight. Its really just whatever the pilots wants on hand for quick reference. You've already got a notepad and calculator and I think these could be just one of many tabs to a knee board. If you could find a way to import an image as another page to this knee board you could put whatever you want in KSP, as little or as much as the player wants use by adding tabs.

I would love to be able to import an image, like a delta V map, close imagery of my landing zone, a landing checklist or whatever. People could build their own charts or tables and import them as pages as easy as making a custom flag. I think it could add to immersion and it would be a great tool for building a mission profile for another player. You could put together and entire mission profile and the materials as pages in this knee board and another player could download it along with the spacecraft and just fly it according to your plan.

Link to comment
Share on other sites

Thanks for this mod, its simple and sweet. If you're open to expanding on it I think it would make a great knee board tool. In aviation knee boards common practice and I'm sure NASA pilots are still using them. It usually has your emergency checklist, your flight plan, a chart maybe, a place for notes, maybe common calculations of tables with fuels and weight. Its really just whatever the pilots wants on hand for quick reference. You've already got a notepad and calculator and I think these could be just one of many tabs to a knee board. If you could find a way to import an image as another page to this knee board you could put whatever you want in KSP, as little or as much as the player wants use by adding tabs.

I would love to be able to import an image, like a delta V map, close imagery of my landing zone, a landing checklist or whatever. People could build their own charts or tables and import them as pages as easy as making a custom flag. I think it could add to immersion and it would be a great tool for building a mission profile for another player. You could put together and entire mission profile and the materials as pages in this knee board and another player could download it along with the spacecraft and just fly it according to your plan.

Hi Godit, I don't want to expand further this plugin, as I want to keep it simple as possible. But a image loader/viewer it's something I can look for a separate plugin and perhaps tabs for the notes. I'll try to work on that two this weekend.

Anyway the knee board it's a very good idea and I'll add it to my todo list :)

Salud.

Link to comment
Share on other sites

Hi Godit, I don't want to expand further this plugin, as I want to keep it simple as possible. But a image loader/viewer it's something I can look for a separate plugin and perhaps tabs for the notes. I'll try to work on that two this weekend.

Anyway the knee board it's a very good idea and I'll add it to my todo list :)

Salud.

Fantastic! If its all compatible with Blizzy's toolbar I guess it really doesn't matter ifs its a standalone mod since the toolbar buttons function like tabs anyway. Looking forward to it!

Link to comment
Share on other sites

  • 2 weeks later...
Fantastic plug in! Any plans to create a KSP UI for it?

I'm working on tabs and the image-viewer plugin, but I don't have much spare time right now. If I'm not wrong, on plugins we can change the ui just selecting the ksp style, so seems easy, expect news soon(â„¢).

Salud.

Link to comment
Share on other sites

I'm working on tabs and the image-viewer plugin, but I don't have much spare time right now. If I'm not wrong, on plugins we can change the ui just selecting the ksp style, so seems easy, expect news soon(â„¢).

Salud.

Yes to Image Viewer! My ALT and TAB buttons are taking a beating because of those Delta V plots.

Link to comment
Share on other sites

  • 1 month later...

Updated 1st post with 0.8 release, recompiled against 0.23.5 assemblies, updated toolbarwrapper and new feature: ship's log.

To see the new ship's log buttons you need to be in flight scene.

Salud.

Link to comment
Share on other sites

Updated 1st post with 0.8 release, recompiled against 0.23.5 assemblies, updated toolbarwrapper and new feature: ship's log.

To see the new ship's log buttons you need to be in flight scene.

Salud.

Bug(ish) report: The log always prints the time in Earth days, even when the game is set to use Kerbin days. Would it be possible to have it use the same format as the in-game displays, much like KAC does?

2wrDnAg.jpg

Link to comment
Share on other sites

Bug(ish) report: The log always prints the time in Earth days, even when the game is set to use Kerbin days. Would it be possible to have it use the same format as the in-game displays, much like KAC does?

http://i.imgur.com/2wrDnAg.jpg

Woops, forgot to take this in account as I changed to earth time just after update ksp :blush: and also I write this part of the code some time ago. Anyway the timestamp is very buggy, as the code/math is a awful workaround until I figure how to make it properly. It will be fixed soon in 0.8.1.

Salud.

Link to comment
Share on other sites

LOVE the ship log. Timestamp seems to be reliable for me. Only thing is though is I would rather it be in a separate window. My notes include equations and stuff I'd like to have handy, and currently it's a pain to switch back and forth between the notepad and the ship log, which I like on hand to quickly create a new entry when needed

Link to comment
Share on other sites

Ship's log.
KSE Curiosity Log date :Y23,M3,D2

Commander Dongel Kerman.

It has been 5 years since we left Kerbin on an exploration mission to the Jool system. Crew is getting anxious about whether there are space mice eating the snacks in the cargo hold. I don't know if I can take this any longer. Jebcas, my navigator, sometimes zones out for no reasons. Kirrim sometimes wakes up screaming. Probably remembering the time the kraken took hold of her and launched her away from the ship during the Tuesday EVA maintenance.

In other words, Ships Log totally wins and it was an insta download.

Link to comment
Share on other sites

If it's not too difficult could you look into adding an option to change the size of the font used in the notepad? I'm using this for videos now and the font can only be read with the video in full screen at 720 or 1080. I don't need it to be available in game so a setting in the config.xml would be fine, I don't need it to be a rich text format or anything like that. I imagine this would also be helpful to anybody who's maybe a little blurry eyed, a larger font would just be a bit more comfortable.

Thank you for your time!

PS, I did a quick search and didn't see any similar discussion, I hope this hasn't been addressed previously.

Link to comment
Share on other sites

If it's not too difficult could you look into adding an option to change the size of the font used in the notepad? I'm using this for videos now and the font can only be read with the video in full screen at 720 or 1080. I don't need it to be available in game so a setting in the config.xml would be fine, I don't need it to be a rich text format or anything like that. I imagine this would also be helpful to anybody who's maybe a little blurry eyed, a larger font would just be a bit more comfortable.

Thank you for your time!

PS, I did a quick search and didn't see any similar discussion, I hope this hasn't been addressed previously.

I plan to work in the plugin this weekend, but as this is pretty simple change, here's the dll with the fontsize configurable:

https://github.com/hashashin/ksp_notes/releases/download/0.8.1pre/notes.zip

Just overwrite current notes.dll, default fontsize is 13. You'll need to launch and quit ksp before you can see the new variable in the config.xml file.

Salud.

Link to comment
Share on other sites

This thread is quite old. Please consider starting a new thread rather than reviving this one.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...