[1.8-1.9] Modular Fuel Tanks v5.13.1

[Hupherius]

I am having a problem and am not totally sure but, it seems that anything with MFT and TweakScale does not scale the volume of the tank. Parts with only TweakScale properly scale, say EC and Mono.

[NathanKell]

Do you have the latest MFT, and TweakScale 1.44?

[Hupherius]

MFT 5.2.1 and TS 1.44 ...I will try again with a totally Fresh KSP 0.25 (x86 btw).

[Hupherius]

With a fresh install and only FS.dll, MFT 5.2.1, MM2.5.1, TS1.44 and Tals Spherical Tanks.... still no volume change when MFT and TS are on the same tank. out_put.log

[WarrenSchultz]

I'm having the same issue as Hupherius with MFT 5.2.1, MM 2.5.1, TS 1.44.

[NathanKell]

Ah, the MFT archive seems to be lacking the TweakScale interaction plugin. That would explain it...

[WarrenSchultz]

It might. Thanks for looking into it!

Edited October 14, 2014 by WarrenSchultz

[Hupherius]

NathanKell: +rep for you for finding it so easily

[taniwha]

Ah, I wasn't aware of the plugin's existence. Sorry.

[Hupherius]

I am pretty sure it is HERE, of course I could be wrong.

Hmmm... putting that in the TS plugin folder did not seam to work

Edited October 14, 2014 by Hupherius

[NathanKell]

No, the integration plugin is source in the MFT/RF repo and needs to be built for each MFT or RF version, that's why we supply it now rather than TweakScale.

[Hupherius]

Oh, ok...that makes alot of sense actually. I will just patiently wait then. Thank you very much NathanKell!

[gendalf]

is it relevant? since tweakables allow to configure how much fuel tanks have

[taniwha]

Tweakables do not allow you to change what fuel the tanks have, nor do they they allow you to completely remove fuel from the "tanks", making them structural members.

[WarrenSchultz]

Which is why the combination of these two mods is great for making low-part-count craft.

[bmyers831]

Taniwha do you think the kspapi extension fix would solve this? http://forum.kerbalspaceprogram.com/threads/96677-Planes-fall-apart-upon-loading-the-runway-scene

(if you don't want to read the whole thing just look for the youtube link and watch it. It's quick).

Update: It seems to be fixed in 5.2.2. Thanks!

Edited October 20, 2014 by bmyers831

[taniwha]

bmyers831: it should. I had similar issues (how I noticed the problem) and others have reported 5.2.1 fixing their similar issues.

[taniwha]

5.2.2 is out with a few small fixes, most important is probably tweakscale interaction.

[Hupherius]

Thank you very much!

[NoPersona]

5.2.2 is out with a few small fixes, most important is probably tweakscale interaction.

There still isn't any tweakscale interaction. The tweakscale library that is supposed to come with it still doesn't exist, and as such, changing the size of the tanks with tweakscale doesn't work.

In fact, looking at the makefile it doesn't build the tweakscale module, and the Visual Studio project for MFT actually has it named modularFuelTanks.dll too. This would overwrite the proper MFT.dll on build because it would get built second. After fixing what is needed and building it myself, there is proper tweakscale interaction.

Edited October 19, 2014 by NoPersona

[taniwha]

Darn it, I forgot about that again.

[tom8914]

I think there may be a problem with the creation of new tank definitions, This is effecting B9, TAC life support, and Modular Kolonization System.

here is one example from the log file

[LOG 12:06:22.430] PartLoader: Compiling Part 'B9_Aerospace/Parts/Cockpit_S2/part/B9_Cockpit_S2'

[LOG 12:06:22.451] Tac.LifeSupportModule[FFFE8F12][85.32]: OnAwake

[ERR 12:06:22.499] Unable to find tank definition for type "LifeSupportAll" reverting.

[ERR 12:06:22.500] Unable to find tank definition for type "ServiceModule" reverting.

Rewriting the B9 pack tank types to use existing tank definition worked for everything except those using ServiceModule type

Adding the new tankDefinitions directly to tanktypes.cfg in modularfueltanks did not fix the issue.

Thanks

[tom8914]

Finally traced problem, I think.

If a .cfg attempts to add a resource tank node that is already in a tank definition, then the tank definition is removed/lost/gone

example

in first config file (or TANK[Minerals] already exists in original tank definition)

@TANK_DEFINITION[balloon]{

TANK

{

name = Minerals

amount = 0.0

maxAmount = 0.0

fillable = true

}

}

If a second config file tries to add a second node for resource Minerals, then the Balloon tank definition is lost/voided

[Hupherius]

Is there still no TS support for MFT, I haven't seen a version change since the above listed it?

Edited October 26, 2014 by Hupherius
clarity

[AccidentalDisassembly]

There still isn't any tweakscale interaction. The tweakscale library that is supposed to come with it still doesn't exist, and as such, changing the size of the tanks with tweakscale doesn't work.

In fact, looking at the makefile it doesn't build the tweakscale module, and the Visual Studio project for MFT actually has it named modularFuelTanks.dll too. This would overwrite the proper MFT.dll on build because it would get built second. After fixing what is needed and building it myself, there is proper tweakscale interaction.

Is it possible to share that rebuild so we can once again use TS and MFT together?