[1.0.x] Protractor Continued - Rendezvous Plugin v2.5.1 (May 15th, 2015)

[Gyse]

I believe I have a fix for the duplicating toolbar issue.  The issue seems to be around two problems:

1. Registering for the onGUIApplicationLauncherReady event multiple times, causing OnGUIAppLauncherReady to be called multiple times creating multiple toolbars.

2. Not using the Unreadifying event (which may be what caused the event leak).

 

I tried to reduce down the changes to something smaller, but I wasn't able to get it to work without doing all of this and I didn't have the time to run a full matrix to figure out what all was required.  I didn't 100% test this either past loading up multiple ships and noticing the toolbar was no longer duplicating, so use at your own risk.

 

1. Add support for the onGUIApplicationLauncherUnreadifying event.  I did this by overriding the "Awake" function.  I also registered for the OnGUIApplicationLauncherReady event here as well.

protected virtual void Awake()
{
   if (!ToolbarManager.ToolbarAvailable)
   {
      // subscribe event listeners
      GameEvents.onGUIApplicationLauncherReady.Add(OnGUIAppLauncherReady);
      GameEvents.onGUIApplicationLauncherUnreadifying.Add(OnGUIAppLauncherUnreadifying);
   }
}

 

void OnGUIAppLauncherUnreadifying(GameScenes scene)
{
   // remove button
   if ((ApplicationLauncher.Instance != null) && (appButton != null))
   {
      ApplicationLauncher.Instance.RemoveModApplication(appButton);
   }
}

2. In OnDestroyed, make sure and deregister for the events no matter what.  It was previously only doing it if appButton != null.

public void OnDestroy()
{
   savesettings();
   if (button != null)
   {
      button.Destroy();
      button = null;
   }

   if (!ToolbarManager.ToolbarAvailable)
   {
      GameEvents.onGUIApplicationLauncherReady.Remove(OnGUIAppLauncherReady);
      GameEvents.onGUIApplicationLauncherUnreadifying.Remove(OnGUIAppLauncherUnreadifying);

      if (appButton != null)
      {
         ApplicationLauncher.Instance.RemoveModApplication(appButton);
      }
   }
}

3. Remove all calls to onGUIApplicationLauncherReady.Remove and onGUIApplicationLauncherReady.Add anywhere else not in the code copied above.  For code that looked like this:

if (appButton == null)
{
   if (ApplicationLauncher.Ready)
   {
      OnGUIAppLauncherReady();
   } else {
      GameEvents.onGUIApplicationLauncherReady.Add(OnGUIAppLauncherReady);
   }
}

Simply removing the else block seemed sufficient.

Edited November 1, 2016 by Gyse
typo

[Sheppard]

Any news regarding an official release?

[Dirtyowlnumber5]

Hey there, mod isn't working for me for some reason maybe I am doing something wrong?

 

I am trying to get to Moho, which I am not so sure about, but the angles didn't seem to be right.. Then I looked at Dunas angle when the calculator said it should be 90degrees and it wasn't..

[Sheppard]

The mod hasn't received an update in months now. Please, please, don't let it die!

I haven't found a replacement. I need a mod that shows me what planets will come in range next for a transfer. Transfer Window planner and MechJeb only allow you to select a planet and play around for a transfer, but they do not show you what the next planet will be best for a transfer and when it will happen.

This kind of sucks and I always planned my ships depending on the planet that would come next for a transfer. I don't really like time-warping years at a time without having multiple missions going on in between. With Protractor I could send other ships out to multiple planets while waiting for the first to arrive.

I'm really hoping that this mod gets an update and is made compatible with the latest version of KSP.

 

[Gotcha]

On 13/1/2017 at 10:04 PM, Sheppard said:

The mod hasn't received an update in months now. Please, please, don't let it die!

I haven't found a replacement. I need a mod that shows me what planets will come in range next for a transfer. Transfer Window planner and MechJeb only allow you to select a planet and play around for a transfer, but they do not show you what the next planet will be best for a transfer and when it will happen.

This kind of sucks and I always planned my ships depending on the planet that would come next for a transfer. I don't really like time-warping years at a time without having multiple missions going on in between. With Protractor I could send other ships out to multiple planets while waiting for the first to arrive.

I'm really hoping that this mod gets an update and is made compatible with the latest version of KSP.

Yes pls !!

[Kotagi]

This is one of my favorite mods. This tool really helped me transfer planets with any success for the first time. I hope this gets updated soon. Its like missing a hammer from your toolbox. 

[HebaruSan]

On 1/13/2017 at 7:04 PM, Sheppard said:

I haven't found a replacement. I need a mod that shows me what planets will come in range next for a transfer. Transfer Window planner and MechJeb only allow you to select a planet and play around for a transfer, but they do not show you what the next planet will be best for a transfer and when it will happen.

This kind of sucks and I always planned my ships depending on the planet that would come next for a transfer. I don't really like time-warping years at a time without having multiple missions going on in between. With Protractor I could send other ships out to multiple planets while waiting for the first to arrive.

To anyone missing this mod, Astrogator may be a suitable replacement. It shows the next transfer window for each planet from the active vessel, and you can sort them by time. It can also create the maneuver nodes for you.

(Don't fret if you don't like miles per hour; the default is m/s. This screenshot was just the only one I had on hand that showed a sort by time.)

[Sheppard]

On 14.03.2017 at 11:06 PM, HebaruSan said:

To anyone missing this mod, Astrogator may be a suitable replacement. It shows the next transfer window for each planet from the active vessel, and you can sort them by time. It can also create the maneuver nodes for you.

(Don't fret if you don't like miles per hour; the default is m/s. This screenshot was just the only one I had on hand that showed a sort by time.)

Sounds like the thing I need. At least until Protractor rises again from the dead. Many thanks!

[Z-Key Aerospace]

I have recompiled for KSP1.3.0

Just adding stock toolbar fixes by Gyse.  I'll test those changes and get it published soon.

Edit:

http://themoose.co.uk/ksp/Protractor2.11.zip

Source is on GitHub https://github.com/thewebbooth/protractor

License is GNU GPL license 3

Edited May 28, 2017 by Z-Key Aerospace

[gilflo]

Is the version for KSP 1.3 ok for 1.2.2?

[TheRagingIrishman]

9 hours ago, gilflo said:

Is the version for KSP 1.3 ok for 1.2.2?

Probably not, why don't you try it out and see.

[Z-Key Aerospace]

I am trying to get this thing modernised.  I hope to have a whole new version.

I've started  a thread here