Jump to content

[1.2] PlanetShine - v0.2.5.2 stable - v0.5 experimental [4 October 2016]

Valerian

By Valerian
in KSP1 Mod Releases

 Share

Recommended Posts

Svm420

Svm420

Posted
Posted (edited)
Got a picture? I've not seen this

He means if you time warp with lights, if you are in a low orbit the whole planet your by lights up.

I think I may have been wrong and proot may be talking about something else :blush:

Edited by Svm420
Link to comment
Share on other sites
  • 2 weeks later...
Drew Kerman

Drew Kerman

Posted
Posted

seems like a stock game bug. Craft definitely self-shadow so there should be a shadow behind that shield. Maybe when you get too close to the sun the luminosity grows too great. Or perhaps the shield isn't modeled properly to cast shadows if it's an add on part. Either way self-shadowing craft wouldn't be in scope for this mod (shadows cast by planets might tho)

Link to comment
Share on other sites
  • 2 weeks later...
ev0

ev0

Posted
Posted
PS has an error since a lot of time: changes in the amount of light over the planets and moons. This changes are specially noticeable at warp time in map mode. Am the only one suffering this?
He means if you time warp with lights, if you are in a low orbit the whole planet your by lights up.

I think I may have been wrong and proot may be talking about something else :blush:

If that is what Proot means, then I experienced the same problem. The cause for me had something to do with having BOTH PlanetShine and Probe Control Room installed at the same time, but removing either fixed the problem.

Link to comment
Share on other sites
Proot

Proot

Posted
Posted

I'm not talking about that.

With "vacuumLightLevel = 0" (-or near- as in KSPRC) you can see what I'm saying. Go to orbit or map view and warp the time: you should see how the darkness in the planets and the moons goes from absolute ("0", like in the setting) to stock values, constantly (in a loop). This ruins the consistency of the scene and happens to me since a lot of time... I'm the only one?

Link to comment
Share on other sites
SpaceNomad

SpaceNomad

Posted
Posted (edited)
its Been a while since the lat update Valerian, 1.0.5 is out and Planet shine falling behind in 1.0.2 D: Can you update it please

The first question is: Does it need updating (other than updating the CKAN metadata) or does it "just work"?

Edit: In a very short test, it seemed to work for me on 1.0.5.

Edited by SpaceNomad
Link to comment
Share on other sites
LaytheDragon

LaytheDragon

Posted
Posted
I have found a bug due to PlanetShine in KSP 1.0.5! Minor, but still an issue, nevertheless. Here's the bug:

[LIST]
[*]Certain parts are completely transparent in some spots and look glitched graphically when below -599 meters in Kerbin's oceans
[*]It occurs every time a vessel goes below -599 meters in Kerbin's oceans
[*]When PlanetShine is globally turned off in the in-game PlanetShine settings or when it is uninstalled, the bug disappears
[/LIST]
[Spoiler=Pictures][IMG]http://i.imgur.com/hngrSkL.jpg[/IMG][IMG]http://imgur.com/oKBsV61.jpg[/IMG][IMG]http://imgur.com/wKQvCKP.jpg[/IMG]PlanetShine debug info during an occurrence of this bug.
[IMG]http://imgur.com/b1xaFEO.jpg[/IMG]When PlanetShine is disabled, this issue vanishes [/Spoiler]
Link to comment
Share on other sites
Galenmacil

Galenmacil

Posted
Posted
[quote name='LaytheDragon']I have found a bug due to PlanetShine in KSP 1.0.5! Minor, but still an issue, nevertheless. Here's the bug:

[LIST]
[*]Certain parts are completely transparent in some spots and look glitched graphically when below -599 meters in Kerbin's oceans
[*]It occurs every time a vessel goes below -599 meters in Kerbin's oceans
[*]When PlanetShine is globally turned off in the in-game PlanetShine settings or when it is uninstalled, the bug disappears
[/LIST]
[/QUOTE]

That is what I call in-depth testing... :sticktongue:
Link to comment
Share on other sites
renejant

renejant

Posted
Posted
[quote name='politas']It could do with having KSP_VERSION_MAX in PlanetShine.version bumped up so that KSPAVC stops complaining every time you load the game, though. CKAN can't help with that.[/QUOTE]

I've changed that to 1.0.5. but still keeps popping up the warning where it tells you to update to version x.x.x
Seems harmless so far...
Link to comment
Share on other sites
Speadge

Speadge

Posted
Posted (edited)
[quote name='renejant']I've changed that to 1.0.5. but still keeps popping up the warning where it tells you to update to version x.x.x
Seems harmless so far...[/QUOTE]

hi,

you have to delete the url to the online .version file in the local .version file file planetshine folder Edited by Speadge
Link to comment
Share on other sites
Alshain

Alshain

Posted
Posted (edited)
Valerian, I sent you a small bug fix pull request. Your Gui.OnDestroy() isn't guarding against users that haven't installed Blizzy's toolbar. (The bug had no symptoms other than the NullRef error itself, it's pretty benign but now it's fixed)

[code]NullReferenceException: Object reference not set to an instance of an object
at PlanetShine.Gui.OnDestroy () [0x00000] in <filename unknown>:0 [/code] Edited by Alshain
Link to comment
Share on other sites
Valerian

Valerian

Posted
  • Author
Posted (edited)
[quote name='Proot']I'm not talking about that.

With "vacuumLightLevel = 0" (-or near- as in KSPRC) you can see what I'm saying. Go to orbit or map view and warp the time: you should see how the darkness in the planets and the moons goes from absolute ("0", like in the setting) to stock values, constantly (in a loop). This ruins the consistency of the scene and happens to me since a lot of time... I'm the only one?[/QUOTE]

I think I know what you mean, and I discovered this bug recently. It should only occurs when your vessel is located within the atmosphere. I will fix it right now.
However due to the way lights are implemented, this bug still occurs when you go in normal camera, and dezoom to maximum: the dark side of planets/moons will also get the atmospheric ambient light that Planetshine adds.

I think I was working on completely preventing that in my refactored new version of PlanetShine (the one with multiple planetshines between planets/moon).

[COLOR=silver][SIZE=1]- - - Updated - - -[/SIZE][/COLOR]

[quote name='little square dot']I love this mod.

I'd even call it essential, if only I could hide from the sun.

[URL]http://i.imgur.com/BaMpx3Ol.png[/URL]

[URL]http://i.imgur.com/JI1GUAXl.png[/URL]


(In case it's unclear, the command pod should be well hidden from the sun, but nary a shadow to be seen.) =([/QUOTE]

From what I understand you want bloom? Like, having the sunlight so strong that when it passes through the sun you get blinded by the light and barely see the shadow?
If that's bloom that you want, it's not really in the scope of PlanetShine right now, but why not.

[COLOR=silver][SIZE=1]- - - Updated - - -[/SIZE][/COLOR]

[quote name='lextacy']does this support RSS?[/QUOTE]

Yes it does, see the "Alternate Colors" folder, alos mentioned in the README.txt file

[COLOR=silver][SIZE=1]- - - Updated - - -[/SIZE][/COLOR]

[quote name='SpaceNomad']Yes, indeed. It seems to reset to the stock toolbar everytime (and did so already in 1.0.4).[/QUOTE]
Sorry about that, it should be fixed in the new version that I will release today.

[COLOR=silver][SIZE=1]- - - Updated - - -[/SIZE][/COLOR]

[quote name='LaytheDragon']I have found a bug due to PlanetShine in KSP 1.0.5! Minor, but still an issue, nevertheless. Here's the bug:

[LIST]
[*]Certain parts are completely transparent in some spots and look glitched graphically when below -599 meters in Kerbin's oceans
[*]It occurs every time a vessel goes below -599 meters in Kerbin's oceans
[*]When PlanetShine is globally turned off in the in-game PlanetShine settings or when it is uninstalled, the bug disappears
[/LIST]
[Spoiler=Pictures][URL]http://i.imgur.com/hngrSkL.jpg[/URL][URL]http://imgur.com/oKBsV61.jpg[/URL][URL]http://imgur.com/wKQvCKP.jpg[/URL]PlanetShine debug info during an occurrence of this bug.
[URL]http://imgur.com/b1xaFEO.jpg[/URL]When PlanetShine is disabled, this issue vanishes [/Spoiler][/QUOTE]

Strange, can you send me a saved game where I can easily test that?
Did you try changing the rendering mode of PlanetShine between "Vertex mode" and "Pixel mode"?

[COLOR=silver][SIZE=1]- - - Updated - - -[/SIZE][/COLOR]

[quote name='Alshain']Valerian, I sent you a small bug fix pull request. Your Gui.OnDestroy() isn't guarding against users that haven't installed Blizzy's toolbar. (The bug had no symptoms other than the NullRef error itself, it's pretty benign but now it's fixed)

[code]NullReferenceException: Object reference not set to an instance of an object
at PlanetShine.Gui.OnDestroy () [0x00000] in <filename unknown>:0 [/code][/QUOTE]

Thank you, I will fix that right now. Edited by Valerian
Link to comment
Share on other sites
W1ntermute

W1ntermute

Posted
Posted
[COLOR=#333333][FONT=Roboto]This little mod of mine,
I'm gonna planetshine!

[/FONT][/COLOR][COLOR=#333333][FONT=Roboto]This little mod of mine, [/FONT][/COLOR]
[COLOR=#333333][FONT=Roboto]I'm gonna planetshine!

[/FONT][/COLOR][COLOR=#333333][FONT=Roboto]This little mod of mine, [/FONT][/COLOR]
[COLOR=#333333][FONT=Roboto]I'm gonna pil-anetshine!

Planetshine, planetshine, planet-shi-hi-yi-yine....ah!

[/FONT][/COLOR][IMG]http://60secondsguitar.com/wp-content/uploads/2014/09/old-man-pink-guitar-corbis-660-80.jpg[/IMG]
Link to comment
Share on other sites
This thread is quite old. Please consider starting a new thread rather than reviving this one.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...