[WIP][1.9.x-1.12.x] Scatterer-atmospheric scattering (0.0838 - 14/08/2022) Scattering improvements, in-game atmo generation and multi-sun support

[NoMrBond]

[quote name='blackrack']Custom depth buffer is working, all high altitude artifacts and moire patterns are gone

Edited: for those who want to try it: [URL="https://mega.nz/#!6JYDSKQJ!JoSWw_pr7wH1wBbknI3k7Nfl5xhRJ7tUcYCCcx3xHyA"]ArtifactsFix.zip[/URL].[/QUOTE]

Tried it, works great (applied over 0.191 w/ OpenGL mode)

[blackrack]

[quote name='selfish_meme'][url]http://i.imgur.com/vsRPpXB.png[/url]I am seeing a noticible lag now on scene changes before scatterer kicks in, it was always behind the scene load but now it's more pronounced, no other effect of note. Linux 64bit, Intel with nvidia graphics and overidden hardware antialiasing. Happens for a second before physics kicks in. Glorius.[/QUOTE]

Try setting delayLoading = 0 in the planetslist.cfg file.

[Proot]

Eve and/or Scatterer seems to have some kind of problem/incompatibility in the last changes: atmos are loaded, but unloaded again after one or two secs, leaving the sky black (I've changed the delay with no effect). Also, environmental effects appears completely stopped (froze, no movement), and the volumetrics are gone.
I'm not able to determine the specific problem, so I'm reporting the same to you and Rbray89.
I leave you the logs here:

[URL="https://drive.google.com/file/d/0B8doOUfa8UN-WGZ5dTVvaVVGaWM/view?usp=sharing"]KSP.log
[/URL][URL="https://drive.google.com/file/d/0B8doOUfa8UN-VTk4RFQwc0Q0S0U/view?usp=sharing"]output_log.txt[/URL]

[blackrack]

[quote name='Proot']Eve and/or Scatterer seems to have some kind of problem/incompatibility in the last changes: atmos are loaded, but unloaded again after one or two secs, leaving the sky black (I've changed the delay with no effect). Also, environmental effects appears completely stopped (froze, no movement), and the volumetrics are gone.
I'm not able to determine the specific problem, so I'm reporting the same to you and Rbray89.
I leave you the logs here:

[URL="https://drive.google.com/file/d/0B8doOUfa8UN-WGZ5dTVvaVVGaWM/view?usp=sharing"]KSP.log
[/URL][URL="https://drive.google.com/file/d/0B8doOUfa8UN-VTk4RFQwc0Q0S0U/view?usp=sharing"]output_log.txt[/URL][/QUOTE]

I can see this: IsolatedStorageException: Could not find file "D:\Archivos de programa (x86)\Steam\steamapps\common\Kerbal Space Program\GameData\scatterer\CompiledDepthTexture.shader"

So the postprocessing won't work, it shouldn't affect the sky though. It seems I forgot an important shader file, and yet someone reported it as working.

Try again with this:

[URL="https://mega.nz/#!CAZ2xJTT!RFzP6vX8o55ktRZz6-L4D32fnIRbZ_fU2eLaXO931fk"]https://mega.nz/#!CAZ2xJTT!RFzP6vX8o55ktRZz6-L4D32fnIRbZ_fU2eLaXO931fk[/URL]

[Proot]

[quote name='blackrack']I can see this: IsolatedStorageException: Could not find file "D:\Archivos de programa (x86)\Steam\steamapps\common\Kerbal Space Program\GameData\scatterer\CompiledDepthTexture.shader"

So the postprocessing won't work, it shouldn't affect the sky though. It seems I forgot an important shader file, and yet someone reported it as working.

Try again with this:

[URL]https://mega.nz/#!CAZ2xJTT!RFzP6vX8o55ktRZz6-L4D32fnIRbZ_fU2eLaXO931fk[/URL][/QUOTE]

The result is the same, but the error now seems different, many thanks anyway. The new logs:

[URL="https://drive.google.com/file/d/0B8doOUfa8UN-Z2tHaTF0UE5FWEE/view?usp=sharing"]KSP.log[/URL]
[URL="https://drive.google.com/file/d/0B8doOUfa8UN-NkdqTWg5T0hZNDg/view?usp=sharing"]output_log.txt
[/URL]

[Nhawks17]

Still happening with me as well. Here are my logs if you need to compare.
[url=http://www./view/w8o7pizq36kic6x/output_log.txt]output_log[/url]
[url=http://www./download/zezm6pn20orwkw7/KSP.log]KSP[/url]

[Manwith Noname]

[quote name='blackrack']Try again with this:

[URL]https://mega.nz/#!CAZ2xJTT!RFzP6vX8o55ktRZz6-L4D32fnIRbZ_fU2eLaXO931fk[/URL][/QUOTE]

It is certainly odd how this has different issues for different people so I'm wondering what other things are at play. For example, after cleaning out my install and putting EVE, scatterer and the latest fixes in place, I get this..

[URL]http://steamcommunity.com/sharedfiles/filedetails/?id=557792501[/URL]

Maybe the blackness has something to do with Proot and Nhawks17 using higher resolution textures or something about the modified files they have. I've got some things I need to do but I'll try these latest fixes with just scatterer in place shortly.

[rbray89]

[quote name='Manwith Noname']It is certainly odd how this has different issues for different people so I'm wondering what other things are at play. For example, after cleaning out my install and putting EVE, scatterer and the latest fixes in place, I get this..

[URL]http://steamcommunity.com/sharedfiles/filedetails/?id=557792501[/URL]

Maybe the blackness has something to do with Proot and Nhawks17 using higher resolution textures or something about the modified files they have. I've got some things I need to do but I'll try these latest fixes with just scatterer in place shortly.[/QUOTE]

Does this (or something like it) still happen without Scatterer? Those look like the quads generated for EVE's volume particles.

[Manwith Noname]

[quote name='rbray89']Does this (or something like it) still happen without Scatterer? Those look like the quads generated for EVE's volume particles.[/QUOTE]

I'll test but I very much doubt it as I was using EVE with the tonemapper until scatterer was updated to 1.0.5 and I did not see this until using the latest shader fixes above.

[rbray89]

[quote name='Manwith Noname']I'll test but I very much doubt it as I was using EVE with the tonemapper until scatterer was updated to 1.0.5 and I did not see this until using the latest shader fixes above.[/QUOTE]

Ah. Carry on then :)

[Manwith Noname]

It's possible there is a connection mind, still doing a few real life things be testing shortly.

[Manwith Noname]

Uch, I don't like double posting but here goes...

With just scatterer and the latest fix with the new shading technique, the big blue rectangles are gone, however....

[url]http://steamcommunity.com/sharedfiles/filedetails/?id=557876814[/url]

[url]http://steamcommunity.com/sharedfiles/filedetails/?id=557884235[/url]

You'll probably need to zoom in on the second shot but particles appear to wipe out the atmo effect under certain circumstances. So I suspect the blue rectangles in the sky when EVE is present are in some way connected to this too.

[Bizz Keryear]

Have the black sky problem, too, but I really think that it is more of an problem caused by EVE. Since even with the old version of scatter it shows a complete black sky

Anyway while having a look at the files there are some things that hit my eye.
[list][*]Is it really necessary to have duplicates of files? I mean sunglare.png and black.png are literally the same everywhere.
How about bout a folder named global. Having all the stuff in that is used more than once. Every for every planet if it has a folder of its own but it doesn't find file X in it it uses the global one.
[*]The black png ... after starting up KSP ... not being in game, not doing something in game I am already at 3.2 Gig (not really [only] your fault, though).... is it really necessary to have a 5kb png of only one color?
.... I mean is there really a reason to make it 512 x 512 pixels, too? If I was making this my black file would probably (unless I really really need something else) be (if used to produce black pixels) a 1x1 pixel grayscale bmp. (this should make the smallest file since you don't need compression for just one pixel and one color) Size of that file is 66 bytes to 4533 bytes of yours.
On other hand I am relative clueless when it comes to compiling C scripts, I am clueless about Unity and KSP api. So ... I don't know if that would work.
But I still thought I mentioned it. Maybe you are so deep into it that it left your grasp that you could use a file like this, too.[/list]

[rbray89]

[quote name='Manwith Noname']Uch, I don't like double posting but here goes...

With just scatterer and the latest fix with the new shading technique, the big blue rectangles are gone, however....

[url]http://steamcommunity.com/sharedfiles/filedetails/?id=557876814[/url]

[url]http://steamcommunity.com/sharedfiles/filedetails/?id=557884235[/url]

You'll probably need to zoom in on the second shot but particles appear to wipe out the atmo effect under certain circumstances. So I suspect the blue rectangles in the sky when EVE is present are in some way connected to this too.[/QUOTE]

Weird... is this with the new depth buffer change?

[blackrack]

[quote name='Manwith Noname']Uch, I don't like double posting but here goes...

With just scatterer and the latest fix with the new shading technique, the big blue rectangles are gone, however....

[url]http://steamcommunity.com/sharedfiles/filedetails/?id=557876814[/url]

[url]http://steamcommunity.com/sharedfiles/filedetails/?id=557884235[/url]

You'll probably need to zoom in on the second shot but particles appear to wipe out the atmo effect under certain circumstances. So I suspect the blue rectangles in the sky when EVE is present are in some way connected to this too.[/QUOTE]

I'm not sure but I think the transparent objects might be writing to the custom depth buffer, I added the "Opaque" tags but they didn't seem to work, better stay away from the new custom depth buffer for now (replace scatterer.dll and compiledatmosphericscatter.shader with those from the current release on kerbalstuff, delete compileddepthtexture.shader, keep the other files). Edited November 18, 2015 by blackrack

[rbray89]

[quote name='Bizz Keryear']Have the black sky problem, too, but I really think that it is more of an problem caused by EVE. Since even with the old version of scatter it shows a complete black sky

Anyway while having a look at the files there are some things that hit my eye.
[list][*]Is it really necessary to have duplicates of files? I mean sunglare.png and black.png are literally the same everywhere.
How about bout a folder named global. Having all the stuff in that is used more than once. Every for every planet if it has a folder of its own but it doesn't find file X in it it uses the global one.
[*]The black png ... after starting up KSP ... not being in game, not doing something in game I am already at 3.2 Gig (not really [only] your fault, though).... is it really necessary to have a 5kb png of only one color?
.... I mean is there really a reason to make it 512 x 512 pixels, too? If I was making this my black file would probably (unless I really really need something else) be (if used to produce black pixels) a 1x1 pixel grayscale bmp. (this should make the smallest file since you don't need compression for just one pixel and one color) Size of that file is 66 bytes to 4533 bytes of yours.
On other hand I am relative clueless when it comes to compiling C scripts, I am clueless about Unity and KSP api. So ... I don't know if that would work.
But I still thought I mentioned it. Maybe you are so deep into it that it left your grasp that you could use a file like this, too.[/list][/QUOTE]

Try disabling cloud shadows in EVE. GUI: ALT-0

[blackrack]

[quote name='Bizz Keryear']Have the black sky problem, too, but I really think that it is more of an problem caused by EVE. Since even with the old version of scatter it shows a complete black sky

Anyway while having a look at the files there are some things that hit my eye.
[list][*]Is it really necessary to have duplicates of files? I mean sunglare.png and black.png are literally the same everywhere.
How about bout a folder named global. Having all the stuff in that is used more than once. Every for every planet if it has a folder of its own but it doesn't find file X in it it uses the global one.
[*]The black png ... after starting up KSP ... not being in game, not doing something in game I am already at 3.2 Gig (not really [only] your fault, though).... is it really necessary to have a 5kb png of only one color?
.... I mean is there really a reason to make it 512 x 512 pixels, too? If I was making this my black file would probably (unless I really really need something else) be (if used to produce black pixels) a 1x1 pixel grayscale bmp. (this should make the smallest file since you don't need compression for just one pixel and one color) Size of that file is 66 bytes to 4533 bytes of yours.
On other hand I am relative clueless when it comes to compiling C scripts, I am clueless about Unity and KSP api. So ... I don't know if that would work.
But I still thought I mentioned it. Maybe you are so deep into it that it left your grasp that you could use a file like this, too.[/list][/QUOTE]

The sunglare textures are the only repeating things and they're mostly insignificant, a 512x512 texture is nothing, and they're only loaded if their associated planet is loaded so at worst you see slightly more memory usage when both Laythe and Jool are loaded, for the rest it's the same. The black texture could also be removed. Both of these points are so insignificant memory-wise and the current sunglare system is only temporary anyway so I haven't bothered changing them.

[rbray89]

[quote name='blackrack']I'm not sure but I think the transparent objects might be writing to the custom depth buffer, I added the "Opaque" tags but they didn't seem to work, better stay away from the new custom depth buffer for now (replace scatterer.dll and compiledatmosphericscatter.shader with those from the current release on kerbalstuff, delete compileddepthtexture.shader, keep the other files).[/QUOTE]

What does your Camera.RenderWithShader or Camera.SetReplacementShader call look like? For replacementTag it should be "RenderType". Using null will rendder everything which is what it looks like is happening.

[blackrack]

[quote name='rbray89']What does your Camera.RenderWithShader or Camera.SetReplacementShader call look like? For replacementTag it should be "RenderType". Using null will rendder everything which is what it looks like is happening.[/QUOTE]

I actually used "Opaque" because I read somewhere that will replace the opaque shaders but I was getting nothing, went ahead with null while I debug it and then forgot about it.

Didn't know about "RenderType", does this take the type from the replacement shader itself? I guess this would fix it then.

[Manwith Noname]

[quote name='blackrack']I'm not sure but I think the transparent objects might be writing to the custom depth buffer, I added the "Opaque" tags but they didn't seem to work, better stay away from the new custom depth buffer for now (replace scatterer.dll and compiledatmosphericscatter.shader with those from the current release on kerbalstuff, delete compileddepthtexture.shader, keep the other files).[/QUOTE]

In terms of playing the game, I'll revert to 0.0191 with the files in Fix3.zip. When combined with EVE this works wonders for me. I'm mostly a sandbox dabbler so this has just been some interesting testing for me and hopefully useful to yourself and rBray. Happy to test anything out.

Edit:

[quote name='rbray89']Weird... is this with the new depth buffer change?[/QUOTE]

Yeah, the last zip file with the replacement .dll and shaders.

Another edit: This one...

[url]https://mega.nz/#!CAZ2xJTT!RFzP6vX8o55ktRZz6-L4D32fnIRbZ_fU2eLaXO931fk[/url] Edited November 19, 2015 by Manwith Noname

[rbray89]

[quote name='blackrack']I actually used "Opaque" because I read somewhere that will replace the opaque shaders but I was getting nothing, went ahead with null while I debug it and then forgot about it.

Didn't know about "RenderType", does this take the type from the replacement shader itself? I guess this would fix it then.[/QUOTE]

[url]http://docs.unity3d.com/Manual/SL-ShaderReplacement.html[/url]

Basically, it looks through the tags and plays match-up to what is set in the shaders.

So you have a replacement shader that looks like this:
[code]
Shader "Custom/DepthTexture" {
SubShader {
Tags { "RenderType"="Opaque" }
Pass {
...
[/code]

Then call Camera.RenderWithShader(MyReplacementShader, "RenderType"), it will use the RenderType tag as a mask, ignoring all materials that don't match it. In this case, the shaders replaced would have to match "RenderType"="Opaque". I believe you can add multiple sub shaders with different tags, and add multiple tags to a subshader, but don't quote me on that :)

[selfish_meme]

Some more shots for you, I have not had any of the artifacts the others reported, using 0.0191 with artifacts.zip on OpenGL Nvidia Linux, but I have seen this before with scatterer and SVE cruising through the cloud base back to the KSC, I have a video of moving through the cloud base, they look like texture edges to me that are not faded out completely. i also tried Loaddelay like you said but it still seems a lot slower than previously.

[URL]http://i.imgur.com/VyMmGsP.png[/URL]

Other direction no artifacts visible

[URL]http://i.imgur.com/y4ATuC6.png[/URL]

Yes the edges definitely move with the clouds Edited November 19, 2015 by selfish_meme

[blackrack]

[quote name='rbray89'][url]http://docs.unity3d.com/Manual/SL-ShaderReplacement.html[/url]

Basically, it looks through the tags and plays match-up to what is set in the shaders.

So you have a replacement shader that looks like this:
[code]
Shader "Custom/DepthTexture" {
SubShader {
Tags { "RenderType"="Opaque" }
Pass {
...
[/code]

Then call Camera.RenderWithShader(MyReplacementShader, "RenderType"), it will use the RenderType tag as a mask, ignoring all materials that don't match it. In this case, the shaders replaced would have to match "RenderType"="Opaque". I believe you can add multiple sub shaders with different tags, and add multiple tags to a subshader, but don't quote me on that :)[/QUOTE]

Testing this now.



[quote name='selfish_meme']Some more shots for you, I have not had any of the artifacts the others reported, using 0.0191 with artifacts.zip on OpenGL Nvidia Linux, but I have seen this before with scatterer and SVE cruising through the cloud base back to the KSC, I have a video of moving through the cloud base, they look like texture edges to me that are not faded out completely. i also tried Loaddelay like you said but it still seems a lot slower than previously.

[URL]http://i.imgur.com/VyMmGsP.png[/URL]

Other direction no artifacts visible

[URL]http://i.imgur.com/y4ATuC6.png[/URL]

Yes the edges definitely move with the clouds[/QUOTE]

[quote name='Manwith Noname']In terms of playing the game, I'll revert to 0.0191 with the files in Fix3.zip. When combined with EVE this works wonders for me. I'm mostly a sandbox dabbler so this has just been some interesting testing for me and hopefully useful to yourself and rBray. Happy to test anything out.

Edit:



Yeah, the last zip file with the replacement .dll and shaders.

Another edit: This one...

[url]https://mega.nz/#!CAZ2xJTT!RFzP6vX8o55ktRZz6-L4D32fnIRbZ_fU2eLaXO931fk[/url][/QUOTE]

Try this:

[url]https://mega.nz/#!ad5QXQKS!fbAn2AMTNT8eUFffR7xJmrHO-4E39EoGCCdFEJhRw74[/url]

[Manwith Noname]

[quote name='blackrack']Try this:

[URL]https://mega.nz/#!ad5QXQKS!fbAn2AMTNT8eUFffR7xJmrHO-4E39EoGCCdFEJhRw74[/URL][/QUOTE]

Particles are good but....

[URL]http://steamcommunity.com/sharedfiles/filedetails/?id=557917762[/URL]

I'll throw EVE back in and report if the blue rectangles appear. I should just clarify this perhaps, KSP32 (Win 8.1 x64) DX9.

Edit: OK, threw EVE back into the equation and indeed, the odd rectangles in the sky are gone. I'll go try a launch and see if anything crops up. Edited November 19, 2015 by Manwith Noname

[rbray89]

[quote name='Manwith Noname']Particles are good but....

[url]http://steamcommunity.com/sharedfiles/filedetails/?id=557917762[/url]

I'll throw EVE back in and report if the blue rectangles appear. I should just clarify this perhaps, KSP32 (Win 8.1 x64) DX9.[/QUOTE]

Ocean is of type TransparentCuttout... You'll need to add the RenderType to the tags in the replacement shader or do the ocean radius math fix thing in your sky shader.