[BugReport] New ModuleAsteroidDrill and ModuleResourceHarvester name actions incorrectly

[Diazo]

Alright, I can't find a better place to submit this so I'll put this here.

This is pretty minor really and currently only affects a few actions, but it looks like you guys (Squad) are moving to a new way of doing actions so I want to point this out now while it only affects a couple of them and not further down the road when a lot of actions have this issue.

This is a bug report intended for Squad only, there is no adverse gameplay effects from this so players shouldn't have to worry about it.

[C# code babble incoming]

When a part is placed in the editor, KSPActions that are inherited do not rename themselves as expected. So the Start Converter action in the BaseDrill class remains Start Converter when placed in the VAB. As parts such as the Drill-o-matic which has 2 of these inherited classes (ModuleAsteroidDrill and ModuleResourceHarvester), has two actions named Start Converter and the player can not tell which is which.

Once the vessel loads with the part already attached (either into the flight scene, or leave the editor and come back to it later) the action's name is displayed as intended, in this case "Start Surface Harvester" and "Start Asteroid Harvester"

My assumption is that the code to rename the action runs in the OnLoad method which doesn't fire when a part is placed in the VAB, but I can't actually confirm this.

D.

[Snark]

Oh, so THAT's what was going on!  This was driving me nuts when I want to try to set up action groups.  Specifically, the tip that saving-and-loading fixes the duplicate names is a godsend, thank you for that.

Did you file a bug?

[RoverDude]

Thanks for the report - please toss it over on the tracker

[Diazo]

@Snark No, I haven't filed a bug.

@RoverDude Is the link Snark posted the same bug tracker you mean?

D.