Jump to content

[1.12.x] KRASH - Kerbal Ramification Artificial Simulation Hub (simulation mod for KSP) - Cost settings have been change

linuxgurugamer

By linuxgurugamer
in KSP1 Mod Releases

 Share

Recommended Posts

ThreePounds

ThreePounds

Posted
Posted
36 minutes ago, linuxgurugamer said:

It was, and thank you.

Could you put the letters SIM along the side of the rocket?

The problem which  you reported is odd, I'm waiting to hear from Squad about it, something isn't working which should.

Good idea! I tried a splash of colour akin to the KSPedia logo. It's really hard to make those. 38x38 is such a weird size.

I updated the album I linked above.

Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted
19 hours ago, Three_Pounds said:

Seems to work much better now! I still have trouble getting the alternative parent body simulations to work in career. Also, I think the "Terminate at [...]" options are broken right now.

Description: Career-Only: List of available alternative parent bodies comes up empty, despite having reached such a body (example: The Mun). 

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave I (see below)
  3. Enter VAB
  4. Add Mk1 Command Pod
  5. click SIM in stock app bar
  6. click Orbit selection and/or Landed

Expected result: The Mun available as alternative parent body for simulation

Additional Information: Testvessel around the mun was spawned in using developer console.

https://www.dropbox.com/sh/aiqr3jybi4i4r4m/AAC4Y6oYNdAqoyDvky5P3Phya?dl=0

Description: Career-Only: When Terminate at SOI option is active in KRASH Config Window, Simulation is not terminated upon SOI switch to undiscovered body

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave II (see below)
  3. Enter VAB
  4. Load KRASH Testvessel
  5. start simulation in orbit with default altitude
  6. stage and immediately turn prograde, throttle up
  7. cut throttle when AP = 12,000,000m
  8. time warp forward till SOI change

Expected result: Simulation is terminated upon arrival in The Mun's SOI

https://www.dropbox.com/sh/aiqr3jybi4i4r4m/AAC4Y6oYNdAqoyDvky5P3Phya?dl=0

 

This fixes the first one, I didn't have time to check the second:  https://github.com/linuxgurugamer/KRASH/releases/tag/0.5.21.9

Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted (edited)

I just tested the 2nd scenario, worked for me.

One thing, you forgot to upload the craft file, so I built my own.

New build, fixes a small issue on the config settings screen:  https://github.com/linuxgurugamer/KRASH/releases/tag/0.5.21.10

Edited by linuxgurugamer
Link to comment
Share on other sites
ThreePounds

ThreePounds

Posted
Posted
2 minutes ago, linuxgurugamer said:

I just tested the 2nd scenario, worked for me.

One thing, you forgot to upload the craft file, so I built my own.

No. I linked the wrong dropbox folder.

https://www.dropbox.com/sh/v7h4gw66v4uo169/AACVxBX6kvPqzgq9-bKC9IKha?dl=0

I test it again with the new version then. I'll edit this post if no one has replied until then.

Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted
Just now, Three_Pounds said:

No. I linked the wrong dropbox folder.

https://www.dropbox.com/sh/v7h4gw66v4uo169/AACVxBX6kvPqzgq9-bKC9IKha?dl=0

I test it again with the new version then. I'll edit this post if no one has replied until then.

Ok, but before you do, get the new version, I found a small bug on the config screen

Link to comment
Share on other sites
ThreePounds

ThreePounds

Posted
Posted
25 minutes ago, linuxgurugamer said:

Ok, but before you do, get the new version, I found a small bug on the config screen

Okay, I can confirm it is working now. I tested it for SOI, Atmosphere and Landed.

Question: Are you supposed to gather "data" (progress needed for e.g. simulation in orbit around a body e.g. The Mun) during a simulation? e.g. you fly into the Mun's SOI during simulation and "unlock" it so to speak?

 

Link to comment
Share on other sites
ThreePounds

ThreePounds

Posted
Posted (edited)
18 minutes ago, linuxgurugamer said:

No.  You actually need to get there to allow sims to be done inside the SOI, same goes for landing

Hm... Then I might found another bug.

Description: Career-Only: Alternative bodies for simulation can be unlocked during simulations

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave II (see below)
  3. Enter VAB
  4. Load KRASH Testvessel
  5. start simulation in orbit with default altitude (note: Mun is not available)
  6. stage and immediately turn prograde, throttle up
  7. cut throttle when AP = 12,000,000m
  8. time warp forward till SOI change
  9. Terminate Simulation
  10. back in VAB: click SIM icon in stock app bar, Mun is now available.

Expected result: Mun stays unavailable

https://www.dropbox.com/sh/hwcdacb49l9pvwd/AABy5xPmubs89nd7gUrKmCmxa?dl=0

edit: fixed description

Edited by Three_Pounds
Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted
2 minutes ago, Three_Pounds said:

Hm... Then I might found another bug.

Description: Career-Only: Alternative bodies for simulation can be unlocked during simulations

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave II (see below)
  3. Enter VAB
  4. Load KRASH Testvessel
  5. start simulation in orbit with default altitude (note: Mun is not available)
  6. stage and immediately turn prograde, throttle up
  7. cut throttle when AP = 12,000,000m
  8. time warp forward till SOI change
  9. Terminate Simulation
  10. back in VAB: click SIM icon in stock app bar, Mun is now available.

Expected result: Mun stays unavailable

https://www.dropbox.com/sh/hwcdacb49l9pvwd/AABy5xPmubs89nd7gUrKmCmxa?dl=0

edit: fixed description

Interesting.  yes, it's a bug. I'll have to look at this later, at work right now.

Thanks

 

Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted
3 hours ago, Three_Pounds said:

Hm... Then I might found another bug.

Description: Career-Only: Alternative bodies for simulation can be unlocked during simulations

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave II (see below)
  3. Enter VAB
  4. Load KRASH Testvessel
  5. start simulation in orbit with default altitude (note: Mun is not available)
  6. stage and immediately turn prograde, throttle up
  7. cut throttle when AP = 12,000,000m
  8. time warp forward till SOI change
  9. Terminate Simulation
  10. back in VAB: click SIM icon in stock app bar, Mun is now available.

Expected result: Mun stays unavailable

https://www.dropbox.com/sh/hwcdacb49l9pvwd/AABy5xPmubs89nd7gUrKmCmxa?dl=0

edit: fixed description

I know what's going on, it's a result of my having to hack around a change in KSP.

It's a 5 minute fix, but I'm rather busy at work right now, I'll see what I can do.

Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted
1 hour ago, linuxgurugamer said:

Description: Career-Only: Alternative bodies for simulation can be unlocked during simulations

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave II (see below)
  3. Enter VAB
  4. Load KRASH Testvessel
  5. start simulation in orbit with default altitude (note: Mun is not available)
  6. stage and immediately turn prograde, throttle up
  7. cut throttle when AP = 12,000,000m
  8. time warp forward till SOI change
  9. Terminate Simulation
  10. back in VAB: click SIM icon in stock app bar, Mun is now available.

Expected result: Mun stays unavailable

https://www.dropbox.com/sh/hwcdacb49l9pvwd/AABy5xPmubs89nd7gUrKmCmxa?dl=0

edit: fixed description

Ok, this should do it, but I wasn't able to do a full test:

https://github.com/linuxgurugamer/KRASH/releases/tag/0.5.21.11

 

Link to comment
Share on other sites
ThreePounds

ThreePounds

Posted
Posted (edited)

 

1 hour ago, linuxgurugamer said:

Ok, this should do it, but I wasn't able to do a full test:

https://github.com/linuxgurugamer/KRASH/releases/tag/0.5.21.11

 

Testing it right now. I am seeing log spam when the config window is open:

Quote

File 'F:/games/Steam/steamapps/common/Kerbal Space Program/KSP_x64_Data/../GameData/KRASH/PluginData/KRASHCustom.cfg' does not exist

Description: Career-Only: When attempting to simulate a vessel that costs more than the current available funds, the simulation is not started giving an error message "Not enough Funds! You can't afford to launch the vessel." even though simulation costs could be paid for. "Simulation Active" is then stuck blinking on screen.

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave III (see below)
  3. Enter VAB
  4. Load Too Expensive
  5. start simulation with default settings (Kerbin, Launchpad)

Expected result: Simulation starts

https://www.dropbox.com/sh/q0rmf89fk61gza2/AAD-ZA05lIhUpn9xqH7HtdFMa?dl=0

Edited by Three_Pounds
add bugreport
Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted (edited)
13 hours ago, Three_Pounds said:

 

Testing it right now. I am seeing log spam when the config window is open:

Description: Career-Only: When attempting to simulate a vessel that costs more than the current available funds, the simulation is not started giving an error message "Not enough Funds! You can't afford to launch the vessel." even though simulation costs could be paid for. "Simulation Active" is then stuck blinking on screen.

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave III (see below)
  3. Enter VAB
  4. Load Too Expensive
  5. start simulation with default settings (Kerbin, Launchpad)

Expected result: Simulation starts

https://www.dropbox.com/sh/q0rmf89fk61gza2/AAD-ZA05lIhUpn9xqH7HtdFMa?dl=0

Fixed:  https://github.com/linuxgurugamer/KRASH/releases/tag/0.5.21.13

Have I said what an amazing job you are doing?  This particular issue was a bug in the original mod, not related to the 1.2 upgrade.

Also, no log spam.  I think that was because you got a debug version instead of a release version.

There was a missing file, I've added it and also added checks so that even if it is missing, no messages will be spammed

Edited by linuxgurugamer
Link to comment
Share on other sites
ThreePounds

ThreePounds

Posted
Posted (edited)

I also think that we're getting to the end of the bugs because we're running out of features for bugs to hide in. :confused:

2 hours ago, linuxgurugamer said:

@Three_Pounds

Looks like we are getting to the end of the bugs, thanks to you, the mod is now more reliable than ever.

In honor of your contribution to this, while I normally don't name releases, this release will be named after you.

Thank you!

I am honoured! Thank you.

I think your last fix introduced another problem namely when there aren't enough funds available to the run the simulation. Since there is a new stock option in 1.2pre called "Allow negative funds" and your mod features "Continue sim if no cash" we need to make a quick table to asses the interwoven bugs here.

continue sim if no cash→

↓allow negative funds

TRUE FALSE
TRUE  Bug#1 + Bug #2   Bug #2 
FALSE  nominal  Bug #3 

 

Subject: Bug#1

Description: Refer to table for settings. Career-Only: Less funds available than necessary to start simulation. Simulation does not start and funds are added. "Simulation Active" is then stuck blinking on screen.

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave
  3. Enter VAB
  4. Add Mk1 Command Pod
  5. start simulation with default settings (Kerbin, Launchpad)

Expected result: simulation starts, funds are deducted leading to negative funds

Observed result: simulation does not start, funds are added equal to vessel cost

Subject: Bug#2

Description: Refer to table for settings. Career-Only: Less funds available than necessary to start simulation. Simulation costs are deduced when Simulation window is opened in VAB/SPH even when no simulation is started.

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave
  3. Enter VAB
  4. Add Mk1 Command Pod
  5. click on SIM icon in stock app bar

Expected result: nothing

Subject: Bug#3

Description: Refer to table for settings. Career-Only: Less funds available than necessary to start simulation. In VAB/SPH Simulation screen says "Vessel Unlaunchable for the following reason(s):" but then comes up empty. Buttons missing.

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Open KRASH Testsave
  3. Enter VAB
  4. Add Mk1 Command Pod
  5. click on SIM ins tock app bar

Expected result: reasons for unavailability detailed, i.e. not enough funds

Dropbox with save and logs: https://www.dropbox.com/sh/1xtz1aytzrl7af9/AADSRqf24zg_T0w8ESa3vKjWa?dl=0

 
Edited by Three_Pounds
formatting
Link to comment
Share on other sites
ThreePounds

ThreePounds

Posted
Posted (edited)
36 minutes ago, linuxgurugamer said:

Those were tough ones, but I got it:

https://github.com/linuxgurugamer/KRASH/releases/tag/0.5.21.14

 

Known bug:  Saving a customized  config doesn't seem to stick around between game sessions

Bug#2 from above isn't fixed I think. I am still being charged for setup costs even without starting a simulation when "continue sim if no cash = false" and "allow negative funds = true". Simply brining up the Simulation Interface in the editor is enough.

I could understand if this edge case is too weird for you though. It's not going to happen very often that a player is this broke. :D

Edited by Three_Pounds
words
Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted
1 minute ago, Three_Pounds said:

Bug#2 from above isn't fixed I think. I am still being charged for setup costs even without starting a simulation when "continue sim if no cash = false" and "allow negative funds = true". Simply brining up the Simulation Interface in the editor is enough.

Is your starting funds = 0, or something a bit greater?

3 minutes ago, linuxgurugamer said:

Is your starting funds = 0, or something a bit greater?

Also, are you sure something has been added, or are the funds  negative?

I noticed that there is no way to tell the difference between positive and negative numbers on screen, you need to look in the file

Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted

Pretty sure this is an edge case, only occurs when funds are exactly 0

Working on it

12 minutes ago, Three_Pounds said:

Bug#2 from above isn't fixed I think. I am still being charged for setup costs even without starting a simulation when "continue sim if no cash = false" and "allow negative funds = true". Simply brining up the Simulation Interface in the editor is enough.

I could understand if this edge case is too weird for you though. It's not going to happen very often that a player is this broke. :D

The issue was that I was testing with funds = 100, now testing with funds = 0

Link to comment
Share on other sites
ThreePounds

ThreePounds

Posted
Posted
9 minutes ago, linuxgurugamer said:

Is your starting funds = 0, or something a bit greater?

Also, are you sure something has been added, or are the funds  negative?

I noticed that there is no way to tell the difference between positive and negative numbers on screen, you need to look in the file

My starting funds are 0 for my ease. You can see your funds in the alt+f12 menu under cheats easily. Funds are being deducted, so I end up with negative ones. Makes me think that it probably happens with "Allow negative funds = false" just wasn't visible to me because I was already at 0 funds. I would have to check that as well.

 

1 minute ago, linuxgurugamer said:

Pretty sure this is an edge case, only occurs when funds are exactly 0

Working on it

The issue was that I was testing with funds = 100, now testing with funds = 0

Oh... extreme edge case then. :D

Link to comment
Share on other sites
ThreePounds

ThreePounds

Posted
Posted (edited)

Well, there is another small one. Not sure if it's worth fixing:

Description: Career-Only: When attempting to simulate a vessel which couldn't be launched because: Too heavy, too many parts, too big or parts not yet researched, "Simulation Active" will be stuck flashing on screen even though no simulation has started.

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Create new career save, activate "Include Stock vessels"
  3. Enter VAB
  4. load any stock vessel with locked parts
  5. attempt to start simulation

Expected result: nothing

EDIT: well, this might be problematic after all because it prevents me from saving the game

Edited by Three_Pounds
Link to comment
Share on other sites
linuxgurugamer

linuxgurugamer

Posted
  • Author
Posted
29 minutes ago, Three_Pounds said:

Well, there is another small one. Not sure if it's worth fixing:

Description: Career-Only: When attempting to simulate a vessel which couldn't be launched because: Too heavy, too many parts, too big or parts not yet researched, "Simulation Active" will be stuck flashing on screen even though no simulation has started.

Steps to reproduce: 

  1. Launch KSP 64bit from steam
  2. Create new career save, activate "Include Stock vessels"
  3. Enter VAB
  4. load any stock vessel with locked parts
  5. attempt to start simulation

Expected result: nothing

 

The edge case is fixed here:  https://github.com/linuxgurugamer/KRASH/releases/tag/0.5.21.15

I was unable to replicate this last one, it's possible it was the same issue, please try it again

thanks

Link to comment
Share on other sites
This thread is quite old. Please consider starting a new thread rather than reviving this one.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...