[1.12.x] StageRecovery - Recover Funds+ from Dropped Stages

[vardicd]

2 minutes ago, Captain828 said:

No worries man, take care of yourself!

It could be that older versions worked fine but here we are with a newer version of KSP, RC and SR.

I will say that after further testing, I'm only noticing the lag if the parachute part count goes over about 3. If there's only 1 or 2 parachutes, I can't see any lag at all. 3 it's there, but so slight it doesn't impact anything. I don't know if that's information that helps or not?

[Captain828]

Yeah, I've noticed the same.
I guess it's also dependant on how powerful the PC is.

As a stress test, I actually have a test craft filled with chutes that hangs KSP for a few good seconds.

[linuxgurugamer]

New release, 1.9.4

• Reverted the setting to disable automatic recalc if RealChutes is installed
• Thanks to github user @Captain828 for this:
  • Added automatic recalculation delay setting instead

[Qyst]

There seems to be a bug in the latest version of this mod: after entering VAB/SPH, exiting, and then entering again, be it from flight or space center view, every edit done to the ship will result in the game freezing for a half second. This is only fixed by restarting the game.

KSP version: 1.11.1.3066 64-bit, installed from GOG

OS: Manjaro Linux 20.2.1

Mods installed (from CKAN): StageRecovery 1.9.4.0, with the required ClickThrough Blocker 0.1.10.15, SpaceTux Library 0.0.5.0 (with bundled ButtonManager 0.0.1.0 and VesselModuleSave 0.0.1.1), Toolbar Controller 0.1.9.4, and Zero MiniAVC 1.1.0.1

Player.log file: https://www.dropbox.com/s/9c6pxbwvgvb3hcy/BugReport-StageRecovery-1-9-4-Player.log?dl=0

How to reproduce:

1. Start the game with the listed mods installed.
2. Create or load a save.
3. Enter VAB/SPH then leave. Going into flight mode or back to the space center both work.
4. Enter VAB/SPH again.
5. Try to create or edit a ship in any way.
6. Get a short freeze and this in the console:

This behaviour does not seem to be present in version 1.9.3 of this mod.

[linuxgurugamer]

5 hours ago, Qyst said:

There seems to be a bug in the latest version of this mod: after entering VAB/SPH, exiting, and then entering again, be it from flight or space center view, every edit done to the ship will result in the game freezing for a half second. This is only fixed by restarting the game.

KSP version: 1.11.1.3066 64-bit, installed from GOG

OS: Manjaro Linux 20.2.1

Mods installed (from CKAN): StageRecovery 1.9.4.0, with the required ClickThrough Blocker 0.1.10.15, SpaceTux Library 0.0.5.0 (with bundled ButtonManager 0.0.1.0 and VesselModuleSave 0.0.1.1), Toolbar Controller 0.1.9.4, and Zero MiniAVC 1.1.0.1

Player.log file: https://www.dropbox.com/s/9c6pxbwvgvb3hcy/BugReport-StageRecovery-1-9-4-Player.log?dl=0

How to reproduce:

1. Start the game with the listed mods installed.
2. Create or load a save.
3. Enter VAB/SPH then leave. Going into flight mode or back to the space center both work.
4. Enter VAB/SPH again.
5. Try to create or edit a ship in any way.

Great report, I've already found the problem.

[linuxgurugamer]

New release, 1.9.5

• Changed Monobehaviour to be always loaded.  Necessary to fix a nullref in the OnVesselWas Modified in the editor.  Added benefit is a slight decrease in the time to load the various scenes
• Removed internal KSP_Log, now using KSP_Log from the SpaceTuxLibrary. This makes SpaceTuxLibrary a dependency

[PocketBrotector]

@linuxgurugamer

Unfortunately StageRecovery is no longer recovering my spent boosters in the newest version. I'm using the same ship designs that had successful recoveries before, but now StageRecovery is recording neither successful recoveries nor failed recovery attempts. I'd post my logs, but KSP.log seems to have nothing of interest in it and StageRecovery.log in Logs/SpaceTux is completely empty.

[vardicd]

@linuxgurugamer I can also confirm the latest version appears to not be recovering dropped stages as it used to. I have all dependencies, including the new SpaceTuxLibrary, as it was already needed for another mod I'm using.

Side boosters have parachutes in previous versions these are recovered for reuse.

No recovery is listed when they despawn, and they are not registered as destroyed, no messages are generated in the stock message system either.

I have included the log file for you just in case, even though PocketBrotector before me said there's nothing showing up there.

Also just for full disclosure, I did completely delete the stage recovery folder before adding the new version, I know sometimes some mods have issues if you just drag-drop-overwrite. Wanted to be clear that's not what I did.

 

https://www.dropbox.com/s/o3lrwyizhr8dlx7/Log for stagerecovery.log?dl=0

Edited February 9, 2021 by vardicd

[linuxgurugamer]

4 hours ago, PocketBrotector said:

@linuxgurugamer

Unfortunately StageRecovery is no longer recovering my spent boosters in the newest version. I'm using the same ship designs that had successful recoveries before, but now StageRecovery is recording neither successful recoveries nor failed recovery attempts. I'd post my logs, but KSP.log seems to have nothing of interest in it and StageRecovery.log in Logs/SpaceTux is completely empty.

 

50 minutes ago, vardicd said:

@linuxgurugamer I can also confirm the latest version appears to not be recovering dropped stages as it used to. I have all dependencies, including the new SpaceTuxLibrary, as it was already needed for another mod I'm using.

Side boosters have parachutes in previous versions these are recovered for reuse.

No recovery is listed when they despawn, and they are not registered as destroyed, no messages are generated in the stock message system either.

I have included the log file for you just in case, even though PocketBrotector before me said there's nothing showing up there.

Also just for full disclosure, I did completely delete the stage recovery folder before adding the new version, I know sometimes some mods have issues if you just drag-drop-overwrite. Wanted to be clear that's not what I did.

 

https://www.dropbox.com/s/o3lrwyizhr8dlx7/Log for stagerecovery.log?dl=0

Craft files would be useful

[vardicd]

1 hour ago, linuxgurugamer said:

 

Craft files would be useful

2 craft files, Linnea is heavy on the mod parts, but tester is stock and real chutes only. both craft files fail to recover spent stages tester's first stage usually hits the ground before it can despawn, but the second stage also has parachutes and will make it high enough to despawn, and fails to get recovered.

https://www.dropbox.com/sh/4ihjc96yxqd95ox/AAA6iiaiZ85VpmqZvLxxNZRoa?dl=0

Edited February 9, 2021 by vardicd

[PocketBrotector]

1 hour ago, linuxgurugamer said:

Craft files would be useful

Here you go. This is made with Kerbal Reusability Expansion and a bunch of Nertea's mods. The side boosters drop off with a tank of reserved propellant and a probe core so that StageRecovery can infer a powered landing.

[darthgently]

I haven't taken the time to define the issue enough to officially report it but just a heads-up:  the required number chutes to get the green highlight in the editor varies greatly for me on the same craft in the same session.  My guess is that it might be tweakscale related but not sure.  There are times I'm in the editor and merely move the same chutes from one part of a stage to another and the SR final velocity will change almost by an order of magnitude.  It can be like rolling dice.  Sometimes exiting the editor and coming back in fixes it without changing anything on the craft.  And the same behavior seems to affect flight mode but to a lesser degree.  I'll have a pair of SRBs that have chutes enough in the editor to be recovered at 4.5m/s and they will fail recovery at a speed well over that predicted speed, more like 15 or 20m/s.  Often the incorrect numbers in flight mode reflect the transient incorrect numbers I was seeing in the editor previously.  I'm on 1.11.1 with BG but I've been seeing similar behavior since 1.10.x

 

[darthgently]

Stage Recovery has completely stopped recovering for me.  I tried completely uninstalling it and reinstalling; same result.  It works the same as I'm used to in the editor, but in flight I get no success or failures to recover.  I can't imagine why reinstalling is having no effect.  Are there files I should look to manually for completely clearing out the previous instance?  Thanks!

[vardicd]

2 hours ago, darthgently said:

Stage Recovery has completely stopped recovering for me.  I tried completely uninstalling it and reinstalling; same result.  It works the same as I'm used to in the editor, but in flight I get no success or failures to recover.  I can't imagine why reinstalling is having no effect.  Are there files I should look to manually for completely clearing out the previous instance?  Thanks!

Yeah we reported that a few days ago, seems the most recent version is borked for some reason at least for some of us, and until the next release and hopefully a fix, just rolling back to the previous version, which you can still download on spacedock restores recovery functionality.

Edited February 11, 2021 by vardicd

[münambulist]

4 hours ago, vardicd said:

just rolling back to the previous version, which you can still download on spacedock restores recovery functionality.

Thanks for the advice - so 1.9.4? And did you leave SpaceTuxLibrary in place, or remove it from GameData?

[linuxgurugamer]

Just now, münambulist said:

Thanks for the advice - so 1.9.4? And did you leave SpaceTuxLibrary in place, or remove it from GameData?

Leave SpaceTuxLibrary in place

[vardicd]

1 hour ago, münambulist said:

Thanks for the advice - so 1.9.4? And did you leave SpaceTuxLibrary in place, or remove it from GameData?

I have another mod that uses Spacetuxlibrary as a dependency, so I already had it, and left it there, since I still needed it for the other mod, and even if you don't need it for other things, keeping it shouldn't cause you any problems, and keeps you from forgetting it should you upgrade mod versions again.

[linuxgurugamer]

Fyi, I hope to look at this in the next day or so.  I have a decent idea of what may be going on

[vardicd]

2 hours ago, linuxgurugamer said:

Fyi, I hope to look at this in the next day or so.  I have a decent idea of what may be going on

That's okay, not really a huge rush, we still have functional previous versions to fall back on. 

[ronillon]

3 hours ago, linuxgurugamer said:

Fyi, I hope to look at this in the next day or so.  I have a decent idea of what may be going on

That is great, would some logs, info or testing help? FYI: 1.9.5 Does not work for me on KSP_1.10.0.2917 @ Windows 10

49 minutes ago, vardicd said:

That's okay, not really a huge rush, we still have functional previous versions to fall back on. 

Exactly, easy to do through CKAN, Spacedock or manually from github releases.

Although I wonder if it is possible to somehow fix this for those who autoupdate, reverting to 1.9.4 on CKAN?, re-releasing 1.9.4 as 1.9.5.1 on CKAN for example. But that might make a mess in versioning... probably best to wait for fix of 1.9.5

[linuxgurugamer]

4 hours ago, ronillon said:

That is great, would some logs, info or testing help? FYI: 1.9.5 Does not work for me on KSP_1.10.0.2917 @ Windows 10

Going to be a few days, I'll release a beta before a full release, watch this thread for details.

Re. a CKAN update, I could do a revert and then a new release, but that takes time.

[linuxgurugamer]

New release, 1.9.5.1

• Reverted change to Monobehaviour
• Fixed the nullref referenced in previous fix by waiting for the scene change to be complete

This is now properly recovering stages and no more nullref

[darthgently]

This may be a bit out there, but how could I configure and/or trick Stage Recovery into allowing multiple Kerbin-side recovery locations?  I want to be able to recover at multiple sites with regards to the distance calculation.  Ideally, the sites would simply be synonymous with the additional CommNet sites on Kerbin or something like that.  But if the only viable way is to go flat-rate I suppose I could do that also. 

 

On a related note, how well does SR play with RSS and a different location for launches and recoveries, like Florida's KennedySC?  I seem to recall reading that SR alway calculates recovery distance from the stock KerbalSC location on the equator, even in RSS on earth.  Is that the case?  Does KSCSwitcher change the way SR functions in this regard?

[vardicd]

1 hour ago, darthgently said:

This may be a bit out there, but how could I configure and/or trick Stage Recovery into allowing multiple Kerbin-side recovery locations?  I want to be able to recover at multiple sites with regards to the distance calculation.  Ideally, the sites would simply be synonymous with the additional CommNet sites on Kerbin or something like that. 

There is an option in Kerbal Konstructs, which is a dependency of Kerbinside, that enable/disables using additional bases fore recovery calculations. I've always assumed this hooked into stage recovery, but maybe I'm wrong? 

[AccidentalDisassembly]

Something going a little wonky when trying (failing, here) to recover stage bits with the combination of JNSQ, Kerbal Konstructs, Sigma Dimensions (downscaled JNSQ to end up at ~1.6x stock size based on my personal preferences) and Stage Recovery - not sure if this is sufficient information, but is what I found in the log:

Spoiler

[LOG 22:14:42.604] [F: 170542]: Vessel AstRedirector Class A Debris was on-rails at 1.2 kPa pressure and was destroyed.
[LOG 22:14:42.618] KK: [StageRecovery] PreRecovery: OnVesselRecoveryRequested
[LOG 22:14:42.618] KK: [StageRecovery] PreRecovery: OnVesselRecoveryRequested is career
[LOG 22:14:42.618] KK: [StageRecovery] PreRecovery: Distance to KSC is 892694.565493538
[LOG 22:14:42.619] KK: [StageRecovery] PreRecovery: distance is: 1421637.92103428
[LOG 22:14:42.619] KK: [StageRecovery] PreRecovery: distance is: 1421620.53937732
[LOG 22:14:42.619] KK: [StageRecovery] PreRecovery: distance is: 1420576.47396286
[LOG 22:14:42.620] KK: [StageRecovery] PreRecovery: distance is: 1422000.32789427
[LOG 22:14:42.620] KK: [StageRecovery] PreRecovery: distance is: 1422197.4787732
[LOG 22:14:42.620] KK: [StageRecovery] PreRecovery: distance is: 1421538.40708906
[LOG 22:14:42.621] KK: [StageRecovery] PreRecovery: distance is: 889555.831496541
[LOG 22:14:42.621] KK: [StageRecovery] PreRecovery: KK: closest updated to KSC Harbor Heliport, distance 889555.831496541
[LOG 22:14:42.621] KK: [StageRecovery] PreRecovery: distance is: 889619.906252892
[LOG 22:14:42.621] KK: [StageRecovery] PreRecovery: distance is: 889064.806279482
[LOG 22:14:42.621] KK: [StageRecovery] PreRecovery: KK: closest updated to KSC Harbor Water, distance 889064.806279482
[LOG 22:14:42.622] KK: [StageRecovery] PreRecovery: distance is: 1793315.09444069
[LOG 22:14:42.622] KK: [StageRecovery] PreRecovery: distance is: 1796214.67492588
[LOG 22:14:42.622] KK: [StageRecovery] PreRecovery: distance is: 1794352.05492911
[LOG 22:14:42.622] KK: [StageRecovery] PreRecovery: distance is: 867537.786093777
[LOG 22:14:42.622] KK: [StageRecovery] PreRecovery: KK: closest updated to Welcome Harbor Water, distance 867537.786093777
[LOG 22:14:42.623] KK: [StageRecovery] PreRecovery: distance is: 1276430.01378608
[LOG 22:14:42.623] KK: [StageRecovery] PreRecovery: distance is: 1276507.52270186
[LOG 22:14:42.623] KK: [StageRecovery] PreRecovery: distance is: 1276702.20319688
[LOG 22:14:42.623] KK: [StageRecovery] PreRecovery: SpaceCenter set to: Welcome Harbor Water
[LOG 22:14:42.656] KK: [KerbalKonstructs] OnProcessRecoveryProcessing: OnProcessRecovery
[LOG 22:14:42.656] KK: [KerbalKonstructs] OnProcessRecoveryProcessing: Distance to KSC is 470966.037939381
[LOG 22:14:42.656] KK: [KerbalKonstructs] OnProcessRecoveryProcessing: closest updated to KSC Harbor Heliport, distance 467992.455706893
[LOG 22:14:42.656] KK: [KerbalKonstructs] OnProcessRecoveryProcessing: closest updated to KSC Harbor Water, distance 467499.530358056
[LOG 22:14:42.656] KK: [KerbalKonstructs] OnProcessRecoveryProcessing: closest updated to Welcome Harbor Water, distance 450730.064897616
[ERR 22:14:42.657] Exception handling event onVesselRecoveryProcessing in class KerbalKonstructs:System.NullReferenceException: Object reference not set to an instance of an object
  at KerbalKonstructs.KerbalKonstructs.OnProcessRecoveryProcessing (ProtoVessel vessel, KSP.UI.Screens.MissionRecoveryDialog dialog, System.Single recovery) [0x000f9] in <d148da5d5d9249218e63843d11b290e5>:0
  at EventData`3[T,U,V].Fire (T data0, U data1, V data2) [0x000b0] in <06f13185617646e5bc801baeab53ab75>:0

[EXC 22:14:42.658] NullReferenceException: Object reference not set to an instance of an object
    KerbalKonstructs.KerbalKonstructs.OnProcessRecoveryProcessing (ProtoVessel vessel, KSP.UI.Screens.MissionRecoveryDialog dialog, System.Single recovery) (at <d148da5d5d9249218e63843d11b290e5>:0)
    EventData`3[T,U,V].Fire (T data0, U data1, V data2) (at <06f13185617646e5bc801baeab53ab75>:0)
    UnityEngine.DebugLogHandler:LogException(Exception, Object)
    ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object)
    UnityEngine.Debug:LogException(Exception)
    EventData`3:Fire(ProtoVessel, MissionRecoveryDialog, Single)
    StageRecovery.RecoveryItem:FireEvent()
    StageRecovery.StageRecovery:RecoverVessel(Vessel, Boolean)
    StageRecovery.StageRecovery:VesselDestroyEvent(Vessel)
    EventData`1:Fire(Vessel)
    Vessel:Die()
    Vessel:CheckKill()
    VesselPrecalculate:MainPhysics(Boolean)
    ModularFI.ModularVesselPrecalculate:MainPhysics(Boolean)
    VesselPrecalculate:FixedUpdate()
[LOG 22:14:42.664] KK: [StageRecovery] PostRecovery: onVesselRecovered called
[LOG 22:14:42.664] [Vessel AstRedirector Class A Debris]: Vessel was destroyed.
[LOG 22:15:05.927] [FlightIntegrator]: Vessel AstRedirector Class A has been unloaded 3.79736328125, applying analytic temperature 243.120994027334
[LOG 22:15:05.953] [FlightIntegrator]: Vessel AstRedirector Class A has been unloaded 3.43701171875, applying analytic temperature 243.289693804022
[LOG 22:15:05.978] [FlightIntegrator]: Vessel AstRedirector Class A has been unloaded 3.07666015625, applying analytic temperature 243.438672534141
[LOG 22:15:05.983] [FlightIntegrator]: Vessel AstRedirector Class A has been unloaded 2.71630859375, applying analytic temperature 243.517948007375
[LOG 22:15:11.463] Unpacking AstRedirector Class A

Log is here: https://www.dropbox.com/s/p96anzx1nsz466g/ksplog_stagerecoveryKKjnsq.log?dl=0