[0.23] Targetron - Target or command vessel from a list of active flights!

[Jarcikon]

I'd like to suggest adding integration with my Toolbar Plugin to replace the minimized window with a neat little button. Pretty please?

Great plugin! I just released v1.3.1 which adds support. Also, thanks to toadicus for the wrapper class.

[blizzy78]

Great plugin! I just released v1.3.1 which adds support.

Nice! I've added it to my list of supporting plugins.

Edit: Just a minor nitpick on your code: You don't need to set a visibility for GameScenes.FLIGHT since Targetron is running during the flight scene only. And since you are destroying the toolbar button when your plugin is destroyed, you can just go without explicitly setting a visibility. It doesn't hurt, but it's also not necessary.

Edited December 26, 2013 by blizzy78

[Papa_Joe]

Great Mod, use it all the time...

Kinda wish there was a way to hi-light the different docking ports on the target tho, having a list of ports and not knowing which one is which kinda starts getting a little confusing.. - pity you can't have the docking port light up when you select it via the mod so you can see which one it is

Kerbal Crew Manifest can do it when you transfer crom from one part to another. Perhaps the same can be done here when targeting a docking port.

I actually do this in Ship Manifest, which is based on Crew manifest. Crew manifest experiences an issue where a highlighted part will become "de-highlighted" after you mouse over it and move away. So, I also added mouse exit event handlers to deal with mouse overs in the scene, so that parts don't end up de-highlighted. very clean and very visual. easy to find parts that way, especially on space stations.

Docking port illumination would indeed be a very nice feature.

Edited December 26, 2013 by Papa_Joe

[Jarcikon]

Nice! I've added it to my list of supporting plugins.

Edit: Just a minor nitpick on your code: You don't need to set a visibility for GameScenes.FLIGHT since Targetron is running during the flight scene only. And since you are destroying the toolbar button when your plugin is destroyed, you can just go without explicitly setting a visibility. It doesn't hurt, but it's also not necessary.

Thanks blizzy! I tried removing it but found it stays visible after I leave flight mode. It looks like [KSPAddon(KSPAddon.Startup.Flight, false)] only affects when the plugin is started. It isn't getting destroyed until the game is exited. Not sure if I'm missing something or if that is the intended behavior.

I actually do this in Ship Manifest, which is based on Crew manifest. Crew manifest experiences an issue where a highlighted part will become "de-highlighted" after you mouse over it and move away. So, I also added mouse exit event handlers to deal with mouse overs in the scene, so that parts don't end up de-highlighted. very clean and very visual. easy to find parts that way, especially on space stations.

Docking port illumination would indeed be a very nice feature.

Actually I just added this in the last major release. If you right click a listing that is in range (< 200m) and mouse over a listed docking port, the actual port will highlight red. At this point I don't have a problem with de-highlighting since it doesn't stay highlighted, but I plan to have any targeted docking ports highlight another color at some point. I'll check out Ship Manifest and see how you did it.

[therealcrow999]

Targetron GUI window seems to be open every time I launch something, even of I close it out to go in toolbar. I don't know if that is the way it was meant to be.

[Jarcikon]

Targetron GUI window seems to be open every time I launch something, even of I close it out to go in toolbar. I don't know if that is the way it was meant to be.

That was not the intended behavior, more an oversight on my part. I just released version 1.3.3 to fix this. It should now save the toggle state properly. Thanks!

[therealcrow999]

Thanks for fix!

That was not the intended behavior, more an oversight on my part. I just released version 1.3.3 to fix this. It should now save the toggle state properly. Thanks!

[therealcrow999]

There is a problem with 1.3.3. If I close out Targetron GUI it will show in Toolbar like normal, even when I set out another flight. Problem is when I close out game and come back to play game, Targetron icon in Toolbar is gone.

I'm using the latest Toolbar 1.3.0

[Jarcikon]

There is a problem with 1.3.3. If I close out Targetron GUI it will show in Toolbar like normal, even when I set out another flight. Problem is when I close out game and come back to play game, Targetron icon in Toolbar is gone.

I'm using the latest Toolbar 1.3.0

Thanks again. I'll get it right one of these times! Version 1.3.4 should fix this.

[therealcrow999]

Going to test it out. Thanks!

[therealcrow999]

Working good.

[kalizec]

Targetron 1.3.4 seems to spam the output_log with the following:

InvalidOperationException: Collection was modified; enumeration operation may not execute.
  at System.Collections.Generic.List`1+Enumerator[Targetron.Target].VerifyState () [0x00000] in <filename unknown>:0 

  at System.Collections.Generic.List`1+Enumerator[Targetron.Target].MoveNext () [0x00000] in <filename unknown>:0 

  at Targetron.Targetron.Update () [0x00000] in <filename unknown>:0 

(Filename:  Line: -1)

[Jarcikon]

Targetron 1.3.4 seems to spam the output_log with the following:

InvalidOperationException: Collection was modified; enumeration operation may not execute.
  at System.Collections.Generic.List`1+Enumerator[Targetron.Target].VerifyState () [0x00000] in <filename unknown>:0 

  at System.Collections.Generic.List`1+Enumerator[Targetron.Target].MoveNext () [0x00000] in <filename unknown>:0 

  at Targetron.Targetron.Update () [0x00000] in <filename unknown>:0 

(Filename:  Line: -1)

I've been seeing this message on occasion ever since KSP updated to 0.23. I seem to only get it two or three times in a row then nothing. I'll do some more investigating and see if I can find what triggers it.

[blizzy78]

In Targetron.Update(), you're doing this:

foreach (Target t in targets)
{
  if (!FlightGlobals.fetch.vessels.Contains(t.vessel) || t.vessel.Equals(FlightGlobals.fetch.activeVessel))
    targets.Remove(t);
}

Never modify a list you are iterating over at the same time.

[Jarcikon]

In Targetron.Update(), you're doing this:

foreach (Target t in targets)
{
  if (!FlightGlobals.fetch.vessels.Contains(t.vessel) || t.vessel.Equals(FlightGlobals.fetch.activeVessel))
    targets.Remove(t);
}

Never modify a list you are iterating over at the same time.

Blizzy, you are the man! I assumed as long as I don't try to access "t" after removing I would be fine. Learn something new every day

[bADiTCH]

Wow, thanks! This is the mod I needed for multi-ship missions!

[macdjord]

Feature Request: 'Focus' Button

Would it be possible to get a 3rd button next to 'target' and 'control' that focuses the map view on the craft in question?

[Shad0wCatcher]

Another feature request: Celestial bodies. Would make life much easier when you know the launch window and transfer angle and just want to burn manually or are running MJ and want to quickly set up a burn without having to switch to map; wait for render; select target; swap back to flight; wait for render; wait for physics load; select correct MJ setting; hope you aren't clicking too fast that it unfocuses the planet or moon you're attempting to transfer to and have to re-do the whole thing.

[Jarcikon]

Feature Request: 'Focus' Button

Would it be possible to get a 3rd button next to 'target' and 'control' that focuses the map view on the craft in question?

Sounds like a good idea, but I'm not sure if/how this can be done. I'll do some investigating. Anyone know of any mods that currently do something like this?

Another feature request: Celestial bodies. Would make life much easier when you know the launch window and transfer angle and just want to burn manually or are running MJ and want to quickly set up a burn without having to switch to map; wait for render; select target; swap back to flight; wait for render; wait for physics load; select correct MJ setting; hope you aren't clicking too fast that it unfocuses the planet or moon you're attempting to transfer to and have to re-do the whole thing.

Another good idea. I can add a new filter type for celestials, or one for planets/one for moons. I'll work on this for the next major release.

[KerbMav]

Sounds like a good idea, but I'm not sure if/how this can be done. I'll do some investigating. Anyone know of any mods that currently do something like this?

I read Cilph had managed to switch focus to change dish configuration on other crafts in map view in the latest RemoteTech2 version.

[LameLefty]

Personally I wish there was an option to set the Map view to hide every other object EXCEPT the active vessel and the target. I'm about 4-1/2 years into my current Career Save and I have far too many objects (tugs, stations, several interplanetary vessels that have returned and parked for possible re-use) in LKO. Now, I will almost certainly do a few things differently when 0.24 comes and I start over, but for now, it can be a real pain to keep situational awareness through the Map for a rendezvous when the Map is crowded.

[KerbMav]

Yes, more stock categories would be helpful here, too. I do miss e.g. "satellite", so I set my satellites to "base" - quite easy to realize a base in orbit is not a Munar Spa and Hotel.

[Superfluous J]

I love this mod but don't need it very often. Is there a way to make it not visible by default? It's always a click away on the toolbar but I have to close it every time I start the game.

[blizzy78]

Same here, it does not seem to always remember its "invisible" status.

[jinks]

Is this still alive?

The last reply to this thread was in January and a bug in 1.3.4 hasn't been fixed as of yet.

I'd like to play around with the code a bit, maybe even put it up on github, but there is no license for the image assets. Can these be redistributed together with modified source? (@Jarcikon: If you haven't thought of a license, might I suggest CC-BY-SA?)

Minor nitpick: The phrase "Source code is free to use for non-commercial purposes under GPL3." means that the code is in fact not GPL3, but actually a custom license based on the GPL ("modified GPL"), since the GPL itself allows no further restrictions.

While it is your right as the original author to state any license terms you want, this probably wasn't your intention.

Also, this restriction is in all likelihood invalid since you combined your plugin with todacious' ToolbarWrapper which essentially puts the whole project under "pure" GPL3 anyways. (If you're curious pay special attention to section 7 and section 10 of the GPL3 )